https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153351&action=edit Bug 33537: Add better named table_exists alias in Installer module Test plan: Run dbrev later. It is using table_exists. Run t/db_dependent/Installer.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153353&action=edit Bug 33537: Database revision, adding table mail_domain_limits Test plan: Run dbrev or new install. Verify that table is created as expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153355&action=edit Bug 33537: Add undefined default value for belongs_to in TestBuilder Test plan: See next patch. It calls build_object without specifying belongs_to. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153357&action=edit Bug 33537: REST API endpoints Test plan: Run t/db_dependent/api/v1/domain_limits.t List, add (post), get, update (put) and delete domain limit(s). Using the paths: - api/v1/smtp/domain_limits - api/v1/smtp/domain_limits/{SOME_ID} Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153359&action=edit Bug 33537: Connect the dots Use Koha::MailDomainLimits in Koha::Notice::Util->load_domain_limits. Only use koha-conf as fallback when table is still empty. (This is just like SMTP servers.) The test is adjusted accordingly and has moved more to the database oriented side, first proving that both approaches return the same. Test plan: Run t/db_dependent/Koha/Notice_Util.t NOTE: Replace A and B hereunder by two domains of your own choice. Add a limit to KOHA-CONF: domain A, 1 per 1 hour. Add another limit in WEB CONFIG: domain B, 1 per 1 hour Send 2 notices to domain B. Is 1 message delayed? Remove the table entry for B. Run process_message_queue.pl. Is the delayed notice to B sent? Send 2 notices to domain A. Is 1 delayed (using koha-conf fallback)? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note for testing and QA: Tried to keep the patches clean and clear here. Patch 3 and 4 are database oriented, introducing the new table mail_domain_limits. Patch 6 is the Koha object update. It adds a search_with_group_domain that includes a self join on the new table following the 'foreign' key to itself for grouping domains. Patch 7 is all regular REST API stuff. It uses the search_with_group_domain routine too. The render_helper routine was added to reduce the number of lines here. Note that I preferred smtp/ over config/smtp/ here. Patch 8 is the main interface work. The perl script is short and simple. The template is small too; I moved all js to a separate file. The js includes REST API calls for all CRUD operations. Patch 9 is the switch from koha-conf to table in Koha::Notice::Util in order to get all things working. A test plan per patch is provided. But things can be tested along those lines also with all patches applied. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153357|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153362&action=edit Bug 33537: REST API endpoints Test plan: Run t/db_dependent/api/v1/domain_limits.t List, add (post), get, update (put) and delete domain limit(s). Using the paths: - api/v1/smtp/domain_limits - api/v1/smtp/domain_limits/{SOME_ID} Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153359|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153364&action=edit Bug 33537: Connect the dots Use Koha::MailDomainLimits in Koha::Notice::Util->load_domain_limits. Only use koha-conf as fallback when table is still empty. (This is just like SMTP servers.) The test is adjusted accordingly and has moved more to the database oriented side, first proving that both approaches return the same. Test plan: Run t/db_dependent/Koha/Notice_Util.t NOTE: Replace A and B hereunder by two domains of your own choice. Add a limit to KOHA-CONF: domain A, 1 per 1 hour. Add another limit in WEB CONFIG: domain B, 1 per 1 hour Send 2 notices to domain B. Is 1 message delayed? Remove the table entry for B. Run process_message_queue.pl. Is the delayed notice to B sent? Send 2 notices to domain A. Is 1 delayed (using koha-conf fallback)? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please wait, rebasing time -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Will still have a look at this, aaarggg : WARN C4/Installer.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 170, now: 171) FAIL Koha/Exceptions/DomainLimit.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 4) WARN Koha/MailDomainLimit.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 1) WARN Koha/Notice/Util.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 26, now: 31) FAIL Koha/REST/V1/Config/SMTP/DomainLimits.pm FAIL forbidden patterns forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 57) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 75) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 103) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 106) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 133) WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 32) WARN admin/domain_limits.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 1) WARN installer/data/mysql/atomicupdate/bug33537.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 5) WARN t/db_dependent/Installer.t WARN tidiness The file is less tidy than before (bad/messy lines before: 18, now: 19) WARN t/db_dependent/Koha/MailDomainLimits.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 3) WARN t/db_dependent/Koha/Notice_Util.t WARN tidiness The file is less tidy than before (bad/messy lines before: 37, now: 38) WARN t/db_dependent/api/v1/domain_limits.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 7) WARN t/lib/TestBuilder.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 211, now: 212) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153352|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 154770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154770&action=edit Bug 33537: Fix some POD in Installer.pm Test plan: Run qa tools. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153354|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 154772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154772&action=edit Bug 33537: [DBIx] Schema changes for mail_domain_limits Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153361|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 154774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154774&action=edit Bug 33537: Add Koha objects Test plan: Run t/db_dependent/Koha/MailDomainLimits.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Run perltidy on MailDomainLimits.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153363|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 154776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154776&action=edit Bug 33537: Add staff template and script Test plan: Go to Administration/SMTP Servers. Click Domain limits. Do some CRUD operations. Bonus: Add another tab with domain limits. Edit or remove records on tab 1. Try CRUD on changed or removed records on tab 2. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Added some preventDefault calls, as suggested by JD. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 154778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154778&action=edit Bug 33537: (QA follow-up) Tidy updated blocks in various files Resolving: WARN C4/Installer.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 170, now: 171) FAIL Koha/Exceptions/DomainLimit.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 4) WARN Koha/MailDomainLimit.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 1) WARN Koha/Notice/Util.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 26, now: 31) WARN admin/domain_limits.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 1) WARN installer/data/mysql/atomicupdate/bug33537.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 5) WARN t/db_dependent/Installer.t WARN tidiness The file is less tidy than before (bad/messy lines before: 18, now: 19) WARN t/db_dependent/Koha/MailDomainLimits.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 3) WARN t/db_dependent/Koha/Notice_Util.t WARN tidiness The file is less tidy than before (bad/messy lines before: 37, now: 38) WARN t/db_dependent/api/v1/domain_limits.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 7) WARN t/lib/TestBuilder.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 211, now: 212) FAIL Koha/REST/V1/Config/SMTP/DomainLimits.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 32) Test plan: Run qa tools. Note: Forbidden pattern warns in Koha/REST/V1/Config/SMTP/DomainLimits.pm are handled in next patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased (tiny change), perl tidied, applied changes for bug 33556. Note the two important comments about a few qa tools warns that can be ignored. Rest is fine now: Processing files before patches |========================>| 21 / 21 (100.00%) Processing files after patches |========================>| 21 / 21 (100.00%) OK C4/Installer.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid FAIL Koha/Exceptions/DomainLimit.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 SKIP spelling OK tidiness OK valid OK Koha/MailDomainLimit.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid OK Koha/MailDomainLimits.pm OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid OK Koha/Notice/Util.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid OK Koha/REST/V1/Config/SMTP/DomainLimits.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid FAIL Koha/Schema/Result/MailDomainLimit.pm OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 SKIP spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 35) OK valid OK admin/domain_limits.pl OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling OK tidiness OK valid OK api/v1/swagger/definitions/smtp_domain_limits.yaml OK git manipulation OK rest_api_specs OK yaml_valid OK api/v1/swagger/paths/smtp_domain_limits.yaml OK git manipulation OK rest_api_specs OK yaml_valid OK api/v1/swagger/swagger.yaml OK git manipulation OK rest_api_specs OK yaml_valid OK installer/data/mysql/atomicupdate/bug33537.pl OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling OK tidiness OK valid OK installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation OK tinyint_has_boolean_flag OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/domain_limits.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/js/domain_limits.js OK git manipulation OK t/db_dependent/Installer.t OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling OK tidiness OK valid OK t/db_dependent/Koha/MailDomainLimits.t OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling OK tidiness OK valid OK t/db_dependent/Koha/Notice_Util.t OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling OK tidiness OK valid OK t/db_dependent/api/v1/domain_limits.t OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling OK tidiness OK valid OK t/lib/TestBuilder.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK tidiness OK valid -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154769|0 |1 is obsolete| | --- Comment #32 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154818&action=edit Bug 33537: Add better named table_exists alias in Installer module Test plan: Run dbrev later. It is using table_exists. Run t/db_dependent/Installer.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154771|0 |1 is obsolete| | --- Comment #34 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154820&action=edit Bug 33537: Database revision, adding table mail_domain_limits Test plan: Run dbrev or new install. Verify that table is created as expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154773|0 |1 is obsolete| | --- Comment #36 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154822&action=edit Bug 33537: Add undefined default value for belongs_to in TestBuilder Test plan: See next patch. It calls build_object without specifying belongs_to. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154775|0 |1 is obsolete| | --- Comment #38 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154824&action=edit Bug 33537: REST API endpoints Test plan: Run t/db_dependent/api/v1/domain_limits.t List, add (post), get, update (put) and delete domain limit(s). Using the paths: - api/v1/smtp/domain_limits - api/v1/smtp/domain_limits/{SOME_ID} Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154777|0 |1 is obsolete| | --- Comment #40 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154826&action=edit Bug 33537: Connect the dots Use Koha::MailDomainLimits in Koha::Notice::Util->load_domain_limits. Only use koha-conf as fallback when table is still empty. (This is just like SMTP servers.) The test is adjusted accordingly and has moved more to the database oriented side, first proving that both approaches return the same. Test plan: Run t/db_dependent/Koha/Notice_Util.t NOTE: Replace A and B hereunder by two domains of your own choice. Add a limit to KOHA-CONF: domain A, 1 per 1 hour. Add another limit in WEB CONFIG: domain B, 1 per 1 hour Send 2 notices to domain B. Is 1 message delayed? Remove the table entry for B. Run process_message_queue.pl. Is the delayed notice to B sent? Send 2 notices to domain A. Is 1 delayed (using koha-conf fallback)? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154779|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154828&action=edit Bug 33537: (QA follow-up) Resolve forbidden pattern in REST API Resolving: FAIL Koha/REST/V1/Config/SMTP/DomainLimits.pm FAIL forbidden patterns forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 57) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 75) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 103) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 106) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 133) Test plan: Run t/db_dependent/api/v1/domain_limits.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #44 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154830&action=edit Bug 33537: (QA follow-up) Use bootstrap modal native functions Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #46 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154832&action=edit Bug 33537: (QA follow-up) Add 'SMTP Servers' button to domain limits page Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #48 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Marcel, please take a look at my patches for SO, or mark obsolete if you don't agree! For reference, here is what I did to follow the test plan: 1) configured <message_domain_limits> in koha-conf.xml 2) configured an smtp server with my own google account app password 3) did an OPAC password reset which prompted an entry in the message_queue table 4) duplicated that message entry a couple times: INSERT INTO message_queue (letter_id, borrowernumber, subject, content, letter_code, message_transport_type, status, to_address) SELECT letter_id, borrowernumber, subject, content, letter_code, message_transport_type, 'pending', 'pedro.amorim@ptfs-europe.com' FROM message_queue; 5) Run: perl misc/cronjobs/process_message_queue.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154829|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 154869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154869&action=edit Bug 33537: (QA follow-up) Modal UI fixes: Use ol instead of ul in modal fieldset inputs: This ol->ul change makes the UI inputs more spaced and overall more in line with other modals in Koha. Use 'btn-primary' on 'Save' button to have it be shown yellow as other confirmation buttons in Koha. Add a11y attributes to modal form Also prettied HTML code: git show --ignore-all-space <commit_hash> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154831|0 |1 is obsolete| | --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 154871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154871&action=edit Bug 33537: (QA follow-up) Update kohastructure.sql to match atomic update script Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154833|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 154873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154873&action=edit Bug 33537: (QA follow-up) Improve process_message_queue warning message Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154819|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157018&action=edit Bug 33537: Fix some POD in Installer.pm Test plan: Run qa tools. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154821|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157020&action=edit Bug 33537: [DBIx] Schema changes for mail_domain_limits Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154823|0 |1 is obsolete| | --- Comment #61 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157022&action=edit Bug 33537: Add Koha objects Test plan: Run t/db_dependent/Koha/MailDomainLimits.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Run perltidy on MailDomainLimits.t Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154825|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157024&action=edit Bug 33537: Add staff template and script Test plan: Go to Administration/SMTP Servers. Click Domain limits. Do some CRUD operations. Bonus: Add another tab with domain limits. Edit or remove records on tab 1. Try CRUD on changed or removed records on tab 2. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Added some preventDefault calls, as suggested by JD. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154827|0 |1 is obsolete| | --- Comment #65 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157026&action=edit Bug 33537: (QA follow-up) Tidy updated blocks in various files Resolving: WARN C4/Installer.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 170, now: 171) FAIL Koha/Exceptions/DomainLimit.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 4) WARN Koha/MailDomainLimit.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 1) WARN Koha/Notice/Util.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 26, now: 31) WARN admin/domain_limits.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 1) WARN installer/data/mysql/atomicupdate/bug33537.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 5) WARN t/db_dependent/Installer.t WARN tidiness The file is less tidy than before (bad/messy lines before: 18, now: 19) WARN t/db_dependent/Koha/MailDomainLimits.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 3) WARN t/db_dependent/Koha/Notice_Util.t WARN tidiness The file is less tidy than before (bad/messy lines before: 37, now: 38) WARN t/db_dependent/api/v1/domain_limits.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 7) WARN t/lib/TestBuilder.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 211, now: 212) FAIL Koha/REST/V1/Config/SMTP/DomainLimits.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 32) Test plan: Run qa tools. Note: Forbidden pattern warns in Koha/REST/V1/Config/SMTP/DomainLimits.pm are handled in next patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154869|0 |1 is obsolete| | --- Comment #67 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157028&action=edit Bug 33537: (QA follow-up) Modal UI fixes: Use ol instead of ul in modal fieldset inputs: This ol->ul change makes the UI inputs more spaced and overall more in line with other modals in Koha. Use 'btn-primary' on 'Save' button to have it be shown yellow as other confirmation buttons in Koha. Add a11y attributes to modal form Also prettied HTML code: git show --ignore-all-space <commit_hash> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154871|0 |1 is obsolete| | --- Comment #69 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157030&action=edit Bug 33537: (QA follow-up) Update kohastructure.sql to match atomic update script Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154873|0 |1 is obsolete| | --- Comment #71 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157032&action=edit Bug 33537: (QA follow-up) Improve process_message_queue warning message Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #73 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- If I remove the line I get the response's server (better than nothing!) "Adding limit for 'eza' failed. (Status 400 - Bad request: expected columns were empty.)" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #75 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #74)

The Use bootstrap patch has my attention now. It removes some of the previously working checks.

Squashed it now too with Add staff template. Added a event stop propagation to get validation back again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157017|0 |1 is obsolete| | Attachment #157018|0 |1 is obsolete| | Attachment #157019|0 |1 is obsolete| | Attachment #157020|0 |1 is obsolete| | Attachment #157021|0 |1 is obsolete| | Attachment #157022|0 |1 is obsolete| | Attachment #157023|0 |1 is obsolete| | Attachment #157024|0 |1 is obsolete| | Attachment #157025|0 |1 is obsolete| | Attachment #157026|0 |1 is obsolete| | Attachment #157027|0 |1 is obsolete| | Attachment #157028|0 |1 is obsolete| | Attachment #157029|0 |1 is obsolete| | Attachment #157030|0 |1 is obsolete| | Attachment #157031|0 |1 is obsolete| | Attachment #157032|0 |1 is obsolete| | --- Comment #77 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157038&action=edit Bug 33537: Add better named table_exists alias in Installer module Test plan: Run dbrev later. It is using table_exists. Run t/db_dependent/Installer.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #79 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157040&action=edit Bug 33537: Database revision, adding table mail_domain_limits Test plan: Run dbrev or new install. Verify that table is created as expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #81 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157042&action=edit Bug 33537: Add undefined default value for belongs_to in TestBuilder Test plan: See next patch. It calls build_object without specifying belongs_to. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #83 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157044&action=edit Bug 33537: REST API endpoints Test plan: Run t/db_dependent/api/v1/domain_limits.t List, add (post), get, update (put) and delete domain limit(s). Using the paths: - api/v1/smtp/domain_limits - api/v1/smtp/domain_limits/{SOME_ID} Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> [EDIT] Applied the QA-follow-up-Resolve-forbidden-pattern-in-.patch here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #85 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157046&action=edit Bug 33537: Connect the dots Use Koha::MailDomainLimits in Koha::Notice::Util->load_domain_limits. Only use koha-conf as fallback when table is still empty. (This is just like SMTP servers.) The test is adjusted accordingly and has moved more to the database oriented side, first proving that both approaches return the same. Test plan: Run t/db_dependent/Koha/Notice_Util.t NOTE: Replace A and B hereunder by two domains of your own choice. Add a limit to KOHA-CONF: domain A, 1 per 1 hour. Add another limit in WEB CONFIG: domain B, 1 per 1 hour Send 2 notices to domain B. Is 1 message delayed? Remove the table entry for B. Run process_message_queue.pl. Is the delayed notice to B sent? Send 2 notices to domain A. Is 1 delayed (using koha-conf fallback)? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Bug 33537: (QA follow-up) Improve process_message_queue warning message Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Adjusted test for rewording of the warn. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #87 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 157048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157048&action=edit Bug 33537: (QA follow-up) Add 'SMTP Servers' button to domain limits page Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |jonathan.druart+koha@gmail. |.com |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Whilst I'm slightly surprised by the way the JS was written here.. I can't honestly fail it.. but it does introduce a somewhat different pattern. What I did find more apparent from an end user perspective however was the different navigation we introduce here. I find the 'Administration -> SMPT Servers -> Button in toolbar to get to Domain limits' flow a bit weird feeling. I will admit, I've forgotten exactly how the actual feature fits together with the SMTP Servers stuff.. I thought it was actually effectively independent.. in which case I would have said it should match other admin pages and have its own independent menu option from the admin home and sidebars. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy@rijksmuseum.nl |koha-bugs@lists.koha-commun | |ity.org --- Comment #92 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #91)

Thx anyone for trying to get this further but it will not be ready in time for 23.11 anymore. Will resume this later.

Changing to FQA for now. The "template/javascript does not meet Koha standards". Some other points are not clear (link with SMTP servers); perhaps that is more a documentation issue btw.

If there is additional feedback to support the current stand, please add.

Abandoning this development. It worked fine but alas. Resetting Assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.