[Bug 34817] New: New framework plugin callnumber_colors.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 Bug ID: 34817 Summary: New framework plugin callnumber_colors.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Very simple thing. Connect this to your itemcallnumber field in Administration/MARC frameworks. And when you edit the callnumber and leave the field (Change event), you will get a red or green background color telling you that the callnumber is unique (green) or not (red). It is just meant as a visual warning. The user can still continue and save. Technical detail: The js code calls items endpoint of REST API. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155817&action=edit Bug 34817: Framework plugin callnumber_colors Test plan: Add this to your IntranetUserCSS: .callnumber_green { background-color: green; } /* callnumber_colors.pl framework plugin */ .callnumber_red { background-color: red; } /* callnumber_colors.pl framework plugin */ Goto Administration/MARC bib framework. Add callnumber_colors.pl as plugin to 952$o. Goto Cataloguing/Edit items. Test the plugin with a new and existing item. Test response on existing callnumber, not existing, clearing field. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34860 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #2 from Kelly McElligott <kelly@bywatersolutions.com> --- Upon testing this, I wonder, if the red/green action should be stopping the user from continuing on through the process. Regardless if I had a new call number - green or a copy of a call number- red, it saved the item and moved on. This process was actaully super quick, like it flashed red/ green very quickly, and this could be missed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just a note: red / green is not good for accessibility - color blindness is very common. Could we add another visual element that helps to see the status? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Kelly McElligott from comment #2)
Upon testing this, I wonder, if the red/green action should be stopping the user from continuing on through the process. Regardless if I had a new call number - green or a copy of a call number- red, it saved the item and moved on. This process was actaully super quick, like it flashed red/ green very quickly, and this could be missed.
Thx for testing, Kelly. The idea was to alert staff about a duplicate call number but not stop them since it may well be a valid choice. (We are using duplicate call numbers in some cases.) The background should stay in that color. But if you are a mouse user and you are clicking Save, this might indeed be suboptimal. And you may need an extra alert. Still thinking about it. (In reply to Katrin Fischer from comment #3)
Just a note: red / green is not good for accessibility - color blindness is very common. Could we add another visual element that helps to see the status?
Hi Katrin. Another alert/popup might be handy when using mouse. And red/green can be changed via css. I now tested with lightgreen and orange. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- 1. Should the user have to add their own CSS to make this work? It would be better if we defined the colors so users don't have to find/define accessible colors on their own. 2. Use aria to define/give meaning to those who are low/no vision users? 3. Looks like a leftover debugging statement, unless you mean to keep "console.log( cn_value + ': ' + data.length );". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy@rijksmuseum.nl |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34817 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org