https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick@bywatersolutions.com |agustinmoyano@theke.io Status|NEW |ASSIGNED Severity|enhancement |new feature CC| |tomascohen@gmail.com --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This development will add pickup location groups. 1. Add a new feature checkbox to groups feature to define 'local hold groups' 2. Hold policy in circ rules - new option 'from local hold group' [effectively act as homelibrary + libraries in groups you are in] 2a. This will apply per item (C4::Reserves::CanItemBeReserved) 2b. possibly add a system preference to set home or holding as control 2c. Will check patron's homelibrary to see if possible 3. On checkin, hold policy will be checked to see if hold can be filled according to policy in 2a (dropping through all holds to find highest priority that can be satisfied) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20747 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22688 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22688 [Bug 22688] TT plugin for pickup locations code wrong -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #6 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88139&action=edit Bug 22284: (follow-up) Add schema modifications Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #8 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88141&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #10 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88143&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #12 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88145&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #15 from Agustín Moyano <agustinmoyano@theke.io> --- Hello Kyle, Unused "use" sentences removed and clarified the variable. Sorry about that. Thanks. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #18 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88561&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88138|0 |1 is obsolete| | --- Comment #20 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88793&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) run perl installer/data/mysql/updatedatabase.pl SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88140|0 |1 is obsolete| | --- Comment #22 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88795&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88143|0 |1 is obsolete| | --- Comment #24 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88797&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88145|0 |1 is obsolete| | --- Comment #26 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88799&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88561|0 |1 is obsolete| | --- Comment #28 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88801&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #30 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Agustín Moyano from comment #29)

Created attachment 88802 [details] [review] Bug 22284: (follow-up) fix test count after merge

Bad bug title.. wasn't merge.. was rebase Sorry. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #32 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Liz Rea from comment #31)

Hi Agustin,

I seem to be getting test failures like these on these current patches, have a look please?

Functionally, the dev seems to be working up to this point of testing, so don't stress too much about that. :)

Cheers, Liz

(In reply to Josef Moravec from comment #16)

...

Hi Augustín, I started to testing, overall it is looking good, I will continue on that, but just found some issues, which should be addressed:

prove t/db_dependent/Reserves.t

# Failed test 'CheckReserves Test 1' # at t/db_dependent/Reserves.t line 132. # got: '' # expected: 'Reserved'

# Failed test 'CheckReserves() include reserve_id in its response' # at t/db_dependent/Reserves.t line 134.

# Failed test 'CheckReserves Test 2' # at t/db_dependent/Reserves.t line 137. # got: '' # expected: 'Reserved'

# Failed test 'CheckReserves Test 3' # at t/db_dependent/Reserves.t line 140. # got: '' # expected: 'Reserved' t/db_dependent/Reserves.t .................... 59/60 # Looks like you failed 4 tests of 60. t/db_dependent/Reserves.t .................... Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/60 subtests

prove t/db_dependent/Holds.t # Failed test '$branch_1 patron allowed to reserve $branch_2 item with IndependentBranches OFF (bug 2394)' # at t/db_dependent/Holds.t line 270.

# Failed test '$branch_1 patron NOT allowed to reserve $branch_2 item with IndependentBranches ON ... (bug 2394)' # at t/db_dependent/Holds.t line 278.

# Failed test '... unless canreservefromotherbranches is ON (bug 2394)' # at t/db_dependent/Holds.t line 285. t/db_dependent/Holds.t .. 41/60 # Failed test 'Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled' # at t/db_dependent/Holds.t line 309. t/db_dependent/Holds.t .. 53/60 # Failed test 'Patron can reserve item with hold limit of 1, no holds placed' # at t/db_dependent/Holds.t line 594. # Structures begin differing at: # $got->{status} = 'branchNotInHoldGroup' # $expected->{status} = 'OK'

# Failed test 'Patron can reserve item with 2 reserves daily cap' # at t/db_dependent/Holds.t line 611. # Structures begin differing at: # $got->{status} = 'branchNotInHoldGroup' # $expected->{status} = 'OK'

# Failed test 'Patron can reserve item with 2 bib level hold placed on different days, 2 reserves daily cap' # at t/db_dependent/Holds.t line 630. # Structures begin differing at: # $got->{status} = 'branchNotInHoldGroup' # $expected->{status} = 'OK'

# Failed test 'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)' # at t/db_dependent/Holds.t line 649. # Structures begin differing at: # $got->{status} = 'branchNotInHoldGroup' # $expected->{status} = 'OK'

# Failed test 'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)' # at t/db_dependent/Holds.t line 656. # Structures begin differing at: # $got->{status} = 'branchNotInHoldGroup' # $expected->{status} = 'OK' # Looks like you failed 5 tests of 10. t/db_dependent/Holds.t .. 58/60 # Failed test 'CanItemBeReserved / holds_per_day tests' # at t/db_dependent/Holds.t line 676. t/db_dependent/Holds.t .. 60/60 # Looks like you failed 5 tests of 60. t/db_dependent/Holds.t .. Dubious, test returned 5 (wstat 1280, 0x500) Failed 5/60 subtests

The tests needs to reflect changes in C4::Reserves.

The Comment 13 is not reflected yet.

Hello Liz, thanks for testing.. It's weird.. I've tested it and it passes. I changed chekcout rules before testing, and get no errors (that's the only thing I can think of that may affect those tests).. could you please tell me what was your rules configuration before testing? Thanks kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=60, 9 wallclock secs ( 0.02 usr 0.01 sys + 2.81 cusr 0.39 csys = 3.23 CPU) Result: PASS kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. ok All tests successful. Files=1, Tests=61, 11 wallclock secs ( 0.02 usr 0.01 sys + 3.09 cusr 0.68 csys = 3.80 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #34 from Liz Rea <wizzyrea@gmail.com> --- This morning I've got something different: I have a test failing in Libraries.t - I've updated all the things(dbic and restart_all) and I feel like it should be good to go, but it's not >.< 1..2 # Subtest: UseBranchTransferLimits = OFF 1..5 # No tests run! not ok 1 - No tests run for subtest "UseBranchTransferLimits = OFF" # Failed test 'No tests run for subtest "UseBranchTransferLimits = OFF"' # at t/db_dependent/Koha/Libraries.t line 152. # Looks like you planned 2 tests but ran 1. # Looks like you failed 1 test of 1 run. not ok 6 - pickup_locations# Failed test 'pickup_locations' # at t/db_dependent/Koha/Libraries.t line 409. The method Koha::Items->pickup_locations is not covered by tests! I know you all want to get this feature in before slush, sorry to keep bouncing it back to you. Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88800|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88802|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88794|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88796|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88798|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88939&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) run perl installer/data/mysql/updatedatabase.pl SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88941&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88943&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88945&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #43 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 88947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88947&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15496 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 [Bug 15496] Delete bibliographic record after moving last item to another record(s) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #46 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88949&action=edit Bug 22284: (follow-up) fixes after 15496 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88941|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88945|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88947|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88949|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #48 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88956&action=edit Bug 22284: (follow-up) Add schema modifications Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #50 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88958&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #52 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88960&action=edit Bug 22284: New messages in reserve/request.tt This patch adds new messages to 'Hold' column in 'Place a hold on a specific item' table Those messages are 1) Cannot place hold from patrons's library: this message appears when patron's homebranch is not in item's hold group 2) Pickup library is not in hold group: self explanatory To test: 1) In library groups add a root group and check it as hold group. 2) Add a library to the group 3) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 4) Search a patron from a different library than step 2, select one and click 'search to hold' 5) Search by location for items in the library of step 2 6) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column 7) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 4 to 5 9) Find a biblio with items in 2 different libraries SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Pickup library is not in hold group" in 'Hold' column for the item that has no hold group 10) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #54 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88962&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #56 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88964&action=edit Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- At first glance I'd say that this patchset is going to conflict a lot with bug 18936 (and deps), that is going to remove the circ tables you are modifying. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88960|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88962|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88964|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88959|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #61 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89061&action=edit Bug 22284: (follow-up) Add schema modifications Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #63 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89063&action=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #65 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89065&action=edit Bug 22284: New methods in Koha::Library::Groups and Koha::Library This patch adds new methods in Koha::Library::Groups and Koha::Library. 1) For Koha::Library::Groups adds get_root_ancestor that returns all root groups for a given search parameters, for example Koha::Library::Groups->get_root_ancestor( { id => $group_id } ) 2) For Koha::Library adds 2.1) get_hold_libraries: returns all libraries (including self) that belongs to the same holdgroups. If $self belongs to several holdgroups it will return a distinct list of all libraries belonging to them. 2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of the libraries that belong to any of the holdgroups this library belongs. For example $library->validate_hold_sibling( { branchcode => $branchcode } ) To test: 1) apply this patch 2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t SUCCESS => green letters :-D 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #67 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89067&action=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #69 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89069&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #71 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89071&action=edit Bug 22284: (follow-up) fixes after 15496 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #72 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89072&action=edit Bug 22284: (follow-up) fixes after 18936 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89060|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89063|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89065|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89067|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89069|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89071|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #73 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89073&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #75 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89075&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #77 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89077&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #79 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89079&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #81 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89081&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #83 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89083&action=edit Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #85 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89085&action=edit Bug 22284: (follow-up) fixes after 18936 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89074|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89076|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89082|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89084|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #86 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89122&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #88 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89124&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #90 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89126&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #92 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89128&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #94 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89130&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #96 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89132&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #98 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89134&action=edit Bug 22284: (follow-up) fixes after 15496 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #99 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89135&action=edit Bug 22284: (follow-up) fixes after 18936 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #101 from Liz Rea <wizzyrea@gmail.com> --- i'll retest this tomorrow I think -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #103 from Liz Rea <wizzyrea@gmail.com> --- Alright, thanks Agustin for helping me get these patches to apply! Have gotten through a bit of testing and I have some questions about the feature generally. A note: I've attached the set of MARC records that I usually supplement my devbox with, just so we are looking at the same things. Import them using the Stage MARC for import tool. :) my groups: North: Centerville, Fairfield, Franklin South: Springfield, Troy, Union The other libraries are not in a group, they stand alone. Test, opac: Biblio: De Crasi Aristophea. Dissertatio - 3 items, Centerville, Fairview, Midway Patron: Nicole Schneider, Franklin Pickup locations seen: Fairview, Centerville, Fairfield, Franklin Seems OK? Except maybe Fairview, as it isn't in the patron's group. Biblio: The Vixens, A novel. 1 item, Midway Patron: Nicole Schneider, Franklin Pickup locations seen: Midway Hm. Why not the libraries in Nicole's group (Centerville, Fairfield, Franklin) Biblio: Gairm, 1 item, Centerville Patron: Nicole Schneider, Franklin Pickup locations seen: Centerville, Fairfield, Franklin This seems right - pick up locations in the patron's group, but it is also the item's group. Biblio: De Crasi Aristophea. Dissertatio - 3 items, Centerville, Fairview, Midway Patron: Henry Acevedo, Midway Pickup locations seen: Midway, Fairview, Centerville, Fairfield, Franklin Logic (I think? can you confirm?): Midway because it is the patron's home library. Fairview because there is an item from Fairview? Centerville, Fairfield, Franklin, in a hold group, however our patron is not in this hold group? Is this right? Biblio: The Vixens, A novel. 1 item, Midway Patron: Henry Acevedo, Midway Pickup locations seen: Midway Thoughts: Midway is not in a group. It's like an individual branch is a group unto itself? Is that correct behaviour? Biblio: Gairm, 1 item, Centerville Patron: Henry Acevedo, Midway Pickup locations seen: Centerville, Fairfield, Franklin Thoughts: The patron is not in this group, I don't understand why we are using the item's group and not the patron's group? The main question I have is, which is the location that defines which group the reserve can be picked up in, the patron's branch (which is what I believe the intent of the feature request was) or the item's homebranch? If someone from VOKAL could comment on what they are expecting in the above scenarios, I think that would be really helpful. I'm going to stop here for now, as I think this question of which location is canonical is quite core to this dev. Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #105 from Agustín Moyano <agustinmoyano@theke.io> --- Hello Liz Thanks again for testing! By your results of your tests, I infer that Hold policy was set to "From any library" and Hold pickup library match was set to "Item's hold group" Maybe I got it wrong, but I interpreted that: 1) Hold policy determines who can place a hold. 2) Hold pickup library match determines where an item could be picked up. It wasn't clear in this bug description, but I based pickup library match to item's homebranch/holdingbranch (depending on 'HomeOrHoldingBranch' preference) So now I'll reply test by test

my groups: North: Centerville, Fairfield, Franklin South: Springfield, Troy, Union

The other libraries are not in a group, they stand alone.

Test, opac:

Biblio: De Crasi Aristophea. Dissertatio - 3 items, Centerville, Fairview, Midway Patron: Nicole Schneider, Franklin Pickup locations seen: Fairview, Centerville, Fairfield, Franklin Seems OK? Except maybe Fairview, as it isn't in the patron's group.

In the test I did, I had Fairview, Centerville, Fairfield, Franklin and Midway, and that's consistent with having North holdgroup plus Franklin and Midway that have no holgroup.

Biblio: The Vixens, A novel. 1 item, Midway Patron: Nicole Schneider, Franklin Pickup locations seen: Midway Hm. Why not the libraries in Nicole's group (Centerville, Fairfield, Franklin)

As I based holdgroup on item's homebranch/holdgingbranch, and because Midway is not in a holgroup, you only see Midway

Biblio: Gairm, 1 item, Centerville Patron: Nicole Schneider, Franklin Pickup locations seen: Centerville, Fairfield, Franklin This seems right - pick up locations in the patron's group, but it is also the item's group.

Biblio: De Crasi Aristophea. Dissertatio - 3 items, Centerville, Fairview, Midway Patron: Henry Acevedo, Midway Pickup locations seen: Midway, Fairview, Centerville, Fairfield, Franklin Logic (I think? can you confirm?): Midway because it is the patron's home library.

No, it's because there is an item from Midway.

Fairview because there is an item from Fairview?

right

Centerville, Fairfield, Franklin, in a hold group, however our patron is not in this hold group? Is this right?

If Hold policy was set to 'any', means any patron can place a hold (as I may have misinterpreted), so those 3 libraries are because there is an item in Centerville, that belongs to North holdgroup. This result should be exactly as your first test.

Biblio: The Vixens, A novel. 1 item, Midway Patron: Henry Acevedo, Midway Pickup locations seen: Midway Thoughts: Midway is not in a group. It's like an individual branch is a group unto itself? Is that correct behaviour?

That's correct.. if a library isn't in a holdgroup, then it's taken as an individual holdgroup.

Biblio: Gairm, 1 item, Centerville Patron: Henry Acevedo, Midway Pickup locations seen: Centerville, Fairfield, Franklin Thoughts: The patron is not in this group, I don't understand why we are using the item's group and not the patron's group?

If you want the truth.. the plain, raw, ugly truth is that I didn't know which one to pick, based on this bug description.. so I saw that in 'Hold pickup library match', options where based on item, and I went with the flow.. :P Maybe I can add another option.. something like "Patron's hold group" in pickup library match. Agustín -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #107 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Liz Rea from comment #106)

I think we'll just want to know which way the library that requested it wants to go. I'm told there's some kind of meeting today that might shed some light. :)

All of your notes make sense - I think it's working as you coded it, and it's TBD whether that's how the requester wants it to work. Hopefully we find out today!

Liz

Maybe if VOKAL want's Patron's hold group, or if it just makes sense to have it, I can add that option to Hold Pickup Library Match in a separate bug that depends on this one. Agustín -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #109 from Liz Rea <wizzyrea@gmail.com> --- That's true, I'll retest with those set away from the defaults, maybe it will make it work the way I think they probably want it. Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89122|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89130|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89132|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89134|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #111 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89836&action=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #113 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89838&action=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #115 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89840&action=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #117 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89842&action=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #119 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89844&action=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #121 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89846&action=edit Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #123 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89848&action=edit Bug 22284: (follow-up) fixes after 15496 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #126 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Liz Rea from comment #125)

Hi Agustin,

Thanks for updating your patches, I've had a look over them and the behaviour seems better to me. I'm willing to sign this off, but I'd really like for VOKAL to test it with their real-life requirements and scenarios in mind - I'm not with that institution and I can't purport to speak to their functional requirements.

I've approached Joy at ByWater to see if she can arrange a testing setup for them with this patchset, hopefully we'll hear something soon about that - I know how frustrating it is to endlessly rebase.

Note to QA: I haven't attached signed off patches, pending VOKAL's testing/comments. Let me know if you'd like me to do something differently.

The dev itself looks solid, passes the QA scripts and all of your new tests are passing. The functionality seems good so far as I can see, thank you for all of that and nice job!

Liz

Hello Liz, thanks for letting me know. I won't touch this bug untill we've got feedback from VOKAL, but I can't help thinking on how ReserveControlBranch and HomeOrHolding preferences interact with each other. I think maybe (please correct me if I'm wrong) they work in the following way ReserveControlBranch tell's you which circulation rules should be applied.. for example: We got two libraries: Franklin and Centerville We got a patron from Franklin that want's to place a hold on an item from Centerville, so if ReserveControlBranch is set to patron's home library, we should use Franklin's rules.. else we should use Centerville's rules.. So, in this example: 1. If ReserveControlBranch is set to "patron's home library", and Franklin has a rule of "home library" the hold wouldn't be allowed. 2. If ReserveControlBranch is set to "item's home library" and Centerville has a rule of "any library" the hold would be allowed. Now for HomeOrHolding, I think this tell's you to which library it should be compared when checking the item.. so let's suppose in this same example that the item has as home library Centerville, but as holding library Franklin.. If ReserveControlBranch is set to "patron's home library" (and Franklin still has a rule of "home library") 1. If HomeOrHolding is set to "home", the hold would not be allowed 2. If HomeOrHolding is set to "holding", in this case hold would be allowed, because we would be comparing patron's home library with items holding library. What makes some noise to me, is that the rule name says "From home library", so maybe HomeOrHolding really doesn't apply at all, and we should always check for home library. Other thing I'm not sure is, let's suppose ReserveControBranch is set to "item's home library", should HomeOrHolding affect also which rule should we use?.. I mean, using the same example, if HomeOrHolding is set to "home", we should use Centerville's rules, else we shoul use Franklin's rules?... of course, if HomeOrHolding doesn't apply at all, this question has no sense also. Sorry for spitting all this out.. Agustín -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #128 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90133&action=edit Bug 22284: (follow-up) Remove HomeOrHolding from reserves -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #130 from Agustín Moyano <agustinmoyano@theke.io> --- Test will be fixed in next follow-up -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #132 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90198&action=edit Bug 22284: (follow-up) Fix tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #133 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90199&action=edit Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #135 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 90201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90201&action=edit Bug 22284: (follow-up) Fix tests -- You are receiving this mail because: You are watching all bug changes.