https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Liz Rea <wizzyrea@gmail.com> --- Hi Agustin, I seem to be getting test failures like these on these current patches, have a look please? Functionally, the dev seems to be working up to this point of testing, so don't stress too much about that. :) Cheers, Liz (In reply to Josef Moravec from comment #16)
Hi Augustín, I started to testing, overall it is looking good, I will continue on that, but just found some issues, which should be addressed:
prove t/db_dependent/Reserves.t
# Failed test 'CheckReserves Test 1' # at t/db_dependent/Reserves.t line 132. # got: '' # expected: 'Reserved'
# Failed test 'CheckReserves() include reserve_id in its response' # at t/db_dependent/Reserves.t line 134.
# Failed test 'CheckReserves Test 2' # at t/db_dependent/Reserves.t line 137. # got: '' # expected: 'Reserved'
# Failed test 'CheckReserves Test 3' # at t/db_dependent/Reserves.t line 140. # got: '' # expected: 'Reserved' t/db_dependent/Reserves.t .................... 59/60 # Looks like you failed 4 tests of 60. t/db_dependent/Reserves.t .................... Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/60 subtests
prove t/db_dependent/Holds.t # Failed test '$branch_1 patron allowed to reserve $branch_2 item with IndependentBranches OFF (bug 2394)' # at t/db_dependent/Holds.t line 270.
# Failed test '$branch_1 patron NOT allowed to reserve $branch_2 item with IndependentBranches ON ... (bug 2394)' # at t/db_dependent/Holds.t line 278.
# Failed test '... unless canreservefromotherbranches is ON (bug 2394)' # at t/db_dependent/Holds.t line 285. t/db_dependent/Holds.t .. 41/60 # Failed test 'Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled' # at t/db_dependent/Holds.t line 309. t/db_dependent/Holds.t .. 53/60 # Failed test 'Patron can reserve item with hold limit of 1, no holds placed' # at t/db_dependent/Holds.t line 594. # Structures begin differing at: # $got->{status} = 'branchNotInHoldGroup' # $expected->{status} = 'OK'
# Failed test 'Patron can reserve item with 2 reserves daily cap' # at t/db_dependent/Holds.t line 611. # Structures begin differing at: # $got->{status} = 'branchNotInHoldGroup' # $expected->{status} = 'OK'
# Failed test 'Patron can reserve item with 2 bib level hold placed on different days, 2 reserves daily cap' # at t/db_dependent/Holds.t line 630. # Structures begin differing at: # $got->{status} = 'branchNotInHoldGroup' # $expected->{status} = 'OK'
# Failed test 'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)' # at t/db_dependent/Holds.t line 649. # Structures begin differing at: # $got->{status} = 'branchNotInHoldGroup' # $expected->{status} = 'OK'
# Failed test 'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)' # at t/db_dependent/Holds.t line 656. # Structures begin differing at: # $got->{status} = 'branchNotInHoldGroup' # $expected->{status} = 'OK' # Looks like you failed 5 tests of 10. t/db_dependent/Holds.t .. 58/60 # Failed test 'CanItemBeReserved / holds_per_day tests' # at t/db_dependent/Holds.t line 676. t/db_dependent/Holds.t .. 60/60 # Looks like you failed 5 tests of 60. t/db_dependent/Holds.t .. Dubious, test returned 5 (wstat 1280, 0x500) Failed 5/60 subtests
The tests needs to reflect changes in C4::Reserves.
The Comment 13 is not reflected yet.
-- You are receiving this mail because: You are watching all bug changes.