http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13035 Rafal Kopaczka <rkopaczka@afm.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13035 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32033|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32324&action=edit Bug 13035: Overdue notices send notices for due date in future. Overdue notices, script uses method days_between which returns always positive value of days, no mater if due_date is higher or lower from date_to_run. This causes overdue notices to be send for real overdue and for checkouts with due date in future, which have same days_between as in notice triggers. To reproduce: 1. Set up overdue notice triggers for eg. 2 day. 2. Checkout items for 2 borrowers first gets item with due date 2 days in past and second gets 2 days in future. 3. run ./misc/cronjobs/overdue_notices.pl -n -t 4. watch that notices was generated for both of them. To test: 1. Repeat steps 1,2 2. Apply patch 3. run ./misc/cronjobs/overdue_notices.pl -n -t 4. should be 1 notice for borrower with overdue item. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13035 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32324|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32406&action=edit [PASSED QA] Bug 13035: Overdue notices send notices for due date in future. Overdue notices, script uses method days_between which returns always positive value of days, no mater if due_date is higher or lower from date_to_run. This causes overdue notices to be send for real overdue and for checkouts with due date in future, which have same days_between as in notice triggers. To reproduce: 1. Set up overdue notice triggers for eg. 2 day. 2. Checkout items for 2 borrowers first gets item with due date 2 days in past and second gets 2 days in future. 3. run ./misc/cronjobs/overdue_notices.pl -n -t 4. watch that notices was generated for both of them. To test: 1. Repeat steps 1,2 2. Apply patch 3. run ./misc/cronjobs/overdue_notices.pl -n -t 4. should be 1 notice for borrower with overdue item. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, just adds an additional test. -- You are receiving this mail because: You are watching all bug changes.