[Bug 12862] New: HTML fixes triggered by cleaning up language="javascript"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Bug ID: 12862 Summary: HTML fixes triggered by cleaning up language="javascript" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Browser compatibility Assignee: oleonard@myacpl.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org Tweak the <script> tags to remove or modify the obsolete tag in question, perhaps move the script to fix another bug, tweak the one other simple HTML bug while I'm at it in a file, and fix a hardcoded opac-tmpl when koha-qa complains. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 31325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31325&action=edit Bug 12862: Staff client tweaks related to obsolete language="javascript" As a result, this patch removed the deprecated tag from the intranet templates. And since there was just 1 other tiny error in the same template file, the checked="checked" was removed from a text box. TEST PLAN --------- 1) Install the HTML Validator 0.9.5.8 for FireFox. 2) Open Intranet to Home -> Tools -> News 3) View Page Source -- you'll notice the message about language="javascript" being one of the error messages. 4) Click Edit beside one of the news items. 5) View Page Source -- you'll notice the message about language="javascript" being one of the error messages. 6) Apply patch 7) Repeat steps 2 to 5 without "language="javascript" related error messages. 8) Run koha QA test tools. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 31326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31326&action=edit Bug 12862: OPAC bootstrap - clean up language="javascript" There was a <script language="javascript"> tag. It was cleaned up to be <script type="text/javascript">. Also, the div was being chopped because the script was in the middle of the div. Moving it to head solved the issues. This is difficult to test, since the printslip is triggered when you click Finish. TEST PLAN --------- 1) Home -> Koha administration -> Global system parameters -> OPAC 2) Set the OPAC system preference 'opacthemes' to 'bootstrap'. 3) Start the self-checkout client (/cgi-bin/koha/sco/sco-main.pl) 4) Log in. 5) Check something out. 6) Change the address url text box to .../cgi-bin/koha/sco/printslip.pl?borrowernumber=##&print=qslip Where ## is your borrower number which just checked something out. 7) Click Cancel on the print dialogue 8) View Page Source -- The HTML validation plugin will point out multiple errors. 9) Apply patch 10) Refresh page 11) View Page Source -- Much happier validation results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 31327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31327&action=edit Bug 12862: CCSR and Prog - language="javascript" is obsolete. Corrected/removed the obsolete HTML. Fixed a hard coded opac-tmpl, as per koha-qa's demand. Trigger all the templates and check of the language="javascript" error is listed in the validation done by the HTML Validator plugin for FireFox that Owen pointed me at. TEST PLAN --------- 1) Test with opactheme set to ccsr. Any opac page with opac-bottom.inc will do. 2) Test with opactheme set to prog. - Any opac page with opac-bottom.inc - Any opac page with doc-head-close.inc - Advanced search - Authority search -> Submit -> View full heading -> MARC View - staff client, home, serials, submit by the title text box, click one of the subscriptions (you don't have subscriptions?! can't help you), determine the biblionumber, opac, search for the biblio number and get to an opac details page, click on more details 3) Test the self-checkout printslip, just like the bootstrap one previously. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- I split up the prog and ccsr from the boot strap, so that this could potentially be included as a backport. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31325|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32186&action=edit [SIGNED-OFF] Bug 12862: Staff client tweaks related to obsolete language="javascript" As a result, this patch removed the deprecated tag from the intranet templates. And since there was just 1 other tiny error in the same template file, the checked="checked" was removed from a text box. TEST PLAN --------- 1) Install the HTML Validator 0.9.5.8 for FireFox. 2) Open Intranet to Home -> Tools -> News 3) View Page Source -- you'll notice the message about language="javascript" being one of the error messages. 4) Click Edit beside one of the news items. 5) View Page Source -- you'll notice the message about language="javascript" being one of the error messages. 6) Apply patch 7) Repeat steps 2 to 5 without "language="javascript" related error messages. 8) Run koha QA test tools. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31326|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32187&action=edit [SIGNED-OFF] Bug 12862: OPAC bootstrap - clean up language="javascript" There was a <script language="javascript"> tag. It was cleaned up to be <script type="text/javascript">. Also, the div was being chopped because the script was in the middle of the div. Moving it to head solved the issues. This is difficult to test, since the printslip is triggered when you click Finish. TEST PLAN --------- 1) Home -> Koha administration -> Global system parameters -> OPAC 2) Set the OPAC system preference 'opacthemes' to 'bootstrap'. 3) Start the self-checkout client (/cgi-bin/koha/sco/sco-main.pl) 4) Log in. 5) Check something out. 6) Change the address url text box to .../cgi-bin/koha/sco/printslip.pl?borrowernumber=##&print=qslip Where ## is your borrower number which just checked something out. 7) Click Cancel on the print dialogue 8) View Page Source -- The HTML validation plugin will point out multiple errors. 9) Apply patch 10) Refresh page 11) View Page Source -- Much happier validation results. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31327|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32188&action=edit [SIGNED-OFF] Bug 12862: CCSR and Prog - language="javascript" is obsolete. Corrected/removed the obsolete HTML. Fixed a hard coded opac-tmpl, as per koha-qa's demand. Trigger all the templates and check of the language="javascript" error is listed in the validation done by the HTML Validator plugin for FireFox that Owen pointed me at. TEST PLAN --------- 1) Test with opactheme set to ccsr. Any opac page with opac-bottom.inc will do. 2) Test with opactheme set to prog. - Any opac page with opac-bottom.inc - Any opac page with doc-head-close.inc - Advanced search - Authority search -> Submit -> View full heading -> MARC View - staff client, home, serials, submit by the title text box, click one of the subscriptions (you don't have subscriptions?! can't help you), determine the biblionumber, opac, search for the biblio number and get to an opac details page, click on more details 3) Test the self-checkout printslip, just like the bootstrap one previously. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think there is a line in the first patch, that does not belong there, could you please check? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #8)
I think there is a line in the first patch, that does not belong there, could you please check?
Which one? You can't have checked="checked" on a text box. It is a scope creep, but it is a valid clean up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I didn't see why it was there - if you scope creep, please put a note in your commit message ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #10)
I didn't see why it was there - if you scope creep, please put a note in your commit message ;)
That's why I tweaked the title to "HTML clean up triggered by", so it would include it. ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #0)
Tweak the <script> tags to remove or modify the obsolete tag in question, perhaps move the script to fix another bug, tweak the one other simple HTML bug while I'm at it in a file, and fix a hardcoded opac-tmpl when koha-qa complains.
I also did mention it indirectly here "tweak the other simple HTML bug". You'll also notice how the script was moved to the head block, and I did fix the hardcoded opac-tmpl too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32186|0 |1 is obsolete| | Attachment #32187|0 |1 is obsolete| | Attachment #32188|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32508&action=edit [PASSED QA] Bug 12862: Staff client tweaks related to obsolete language="javascript" As a result, this patch removed the deprecated tag from the intranet templates. And since there was just 1 other tiny error in the same template file, the checked="checked" was removed from a text box. TEST PLAN --------- 1) Install the HTML Validator 0.9.5.8 for FireFox. 2) Open Intranet to Home -> Tools -> News 3) View Page Source -- you'll notice the message about language="javascript" being one of the error messages. 4) Click Edit beside one of the news items. 5) View Page Source -- you'll notice the message about language="javascript" being one of the error messages. 6) Apply patch 7) Repeat steps 2 to 5 without "language="javascript" related error messages. 8) Run koha QA test tools. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32509&action=edit [PASSED QA] Bug 12862: OPAC bootstrap - clean up language="javascript" There was a <script language="javascript"> tag. It was cleaned up to be <script type="text/javascript">. Also, the div was being chopped because the script was in the middle of the div. Moving it to head solved the issues. This is difficult to test, since the printslip is triggered when you click Finish. TEST PLAN --------- 1) Home -> Koha administration -> Global system parameters -> OPAC 2) Set the OPAC system preference 'opacthemes' to 'bootstrap'. 3) Start the self-checkout client (/cgi-bin/koha/sco/sco-main.pl) 4) Log in. 5) Check something out. 6) Change the address url text box to .../cgi-bin/koha/sco/printslip.pl?borrowernumber=##&print=qslip Where ## is your borrower number which just checked something out. 7) Click Cancel on the print dialogue 8) View Page Source -- The HTML validation plugin will point out multiple errors. 9) Apply patch 10) Refresh page 11) View Page Source -- Much happier validation results. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32510&action=edit [PASSED QA] Bug 12862: CCSR and Prog - language="javascript" is obsolete. Corrected/removed the obsolete HTML. Fixed a hard coded opac-tmpl, as per koha-qa's demand. Trigger all the templates and check of the language="javascript" error is listed in the validation done by the HTML Validator plugin for FireFox that Owen pointed me at. TEST PLAN --------- 1) Test with opactheme set to ccsr. Any opac page with opac-bottom.inc will do. 2) Test with opactheme set to prog. - Any opac page with opac-bottom.inc - Any opac page with doc-head-close.inc - Advanced search - Authority search -> Submit -> View full heading -> MARC View - staff client, home, serials, submit by the title text box, click one of the subscriptions (you don't have subscriptions?! can't help you), determine the biblionumber, opac, search for the biblio number and get to an opac details page, click on more details 3) Test the self-checkout printslip, just like the bootstrap one previously. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Mark! Note: I didn't understand the description of the bug. Keep in mind that non-english speakers (as I am) might need a more detailed explanation. RMaints: I ommited the CCSR/Prog patch for master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Tomás Cohen Arazi from comment #16)
Note: I didn't understand the description of the bug. Keep in mind that non-english speakers (as I am) might need a more detailed explanation.
When I went to fix that one specific error, I noticed 3 other errors as well. Hence, the fixing of language="javascript" HTML problems caused me to want to clean up and do (triggered) clean up of three other nearby HTML issues. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org