[Bug 40076] New: Add --skip-no-email parameter to borrowers-force-messaging-defaults.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 Bug ID: 40076 Summary: Add --skip-no-email parameter to borrowers-force-messaging-defaults.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz I use this script a lot during migrations to set the default preferences from the categories to all the patrons. However, recently I've had cases where about half the patrons did not have email addresses in their accounts. This means that I either set everyone's preferences and the library has to go back and remove the preferences from the patrons without email addresses, or I don't do it, and the library has to set the preferences for those with email addresses. (I think I've had back-to-back cases like this because in their old system it was set up as if the patron has an email address, they get the email notices, and if they want to opt-out, they remove their email address from their account.) It would be great if the script could skip the patrons without email addresses. (Note : we never set SMS messages by default, only email; I don't know if someone does this, but it is not a requirement for us to manage sms messaging with this script.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | CC| |hammat.wele@inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 --- Comment #1 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 183769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183769&action=edit Bug 40076: Add --skip-no-email parameter to borrowers-force-messaging-defaults.pl This patch adds a new parameter to skip borrowers without an email address. To test: 1 - Create a new patron without an email address and note their borrowernumber. 2 - Run ./misc/maintenance/borrowers-force-messaging-defaults.pl ==> The patron created in step 1 should be processed. 3 - Repeat step 2 with the --skip-no-email parameter. ==> The patron created in step 1 should not be processed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 Noah <noah.tremblay@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183769|0 |1 is obsolete| | --- Comment #2 from Noah <noah.tremblay@inlibro.com> --- Created attachment 186208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186208&action=edit Bug 40076: Add --skip-no-email parameter to borrowers-force-messaging-defaults.pl This patch adds a new parameter to skip borrowers without an email address. To test: 1 - Create a new patron without an email address and note their borrowernumber. 2 - Run ./misc/maintenance/borrowers-force-messaging-defaults.pl ==> The patron created in step 1 should be processed. 3 - Repeat step 2 with the --skip-no-email parameter. ==> The patron created in step 1 should not be processed. Signed-off-by: noah <noah@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 Noah <noah.tremblay@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noah.tremblay@inlibro.com --- Comment #3 from Noah <noah.tremblay@inlibro.com> --- Works well for me, but ideally we’d need another developer, not from inLibro, to Signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Testing here... 1) QA checks - passing! 2) Code review a) Check for existence of email (question) The script uses an SQL statement that checks, if email, emailpro and B_email are empty to determine that the settings should not be set. I wonder if it would make sense to take the system preferences like EmailFieldPrimary into account, using Koha's method for determining the email address to send a notice to is not empty? b) Missing documentation (blocker) The new option is added, but wasn't added to the help. As the script already runs without any options, the new option is not discoverable apart from reading the code. It might also be worth noting how it works (see a) ). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com --- Comment #5 from Marion Durand <marion.durand@biblibre.com> --- Something similar for other transport type (mainly SMS) would be great (we don't want to set up SMS preferences if the patron has no SMS number). Do you think it should be treated in it's own bug or here ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I think adding an SMS skip could be it's own bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 --- Comment #7 from Marion Durand <marion.durand@biblibre.com> --- Thank you for your answer, I just submitted Bug 41822 for the SMS one (it's true that it's a bit more complexe so no need to block this one for that). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41822 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 --- Comment #8 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 205446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205446&action=edit Bug 40076: (follow-up) Use EmailFieldPrimary and add documentation Patch from commit 6db8974 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Hammat wele <hammat.wele@inlibro.com> --- (In reply to Katrin Fischer from comment #4)
Testing here...
1) QA checks - passing!
2) Code review
a) Check for existence of email (question)
The script uses an SQL statement that checks, if email, emailpro and B_email are empty to determine that the settings should not be set.
I wonder if it would make sense to take the system preferences like EmailFieldPrimary into account, using Koha's method for determining the email address to send a notice to is not empty?
b) Missing documentation (blocker)
The new option is added, but wasn't added to the help. As the script already runs without any options, the new option is not discoverable apart from reading the code.
It might also be worth noting how it works (see a) ).
Thanks for the feedback a) The filter now takes EmailFieldPrimaryinto account, following the same logic used by notice_email_address to determine the email field I also tested using notice_email_address directly, but it slowed down the script. b) Documentation for the --skip-no-email option has been added -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org