https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40076 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Hammat wele <hammat.wele@inlibro.com> --- (In reply to Katrin Fischer from comment #4)
Testing here...
1) QA checks - passing!
2) Code review
a) Check for existence of email (question)
The script uses an SQL statement that checks, if email, emailpro and B_email are empty to determine that the settings should not be set.
I wonder if it would make sense to take the system preferences like EmailFieldPrimary into account, using Koha's method for determining the email address to send a notice to is not empty?
b) Missing documentation (blocker)
The new option is added, but wasn't added to the help. As the script already runs without any options, the new option is not discoverable apart from reading the code.
It might also be worth noting how it works (see a) ).
Thanks for the feedback a) The filter now takes EmailFieldPrimaryinto account, following the same logic used by notice_email_address to determine the email field I also tested using notice_email_address directly, but it slowed down the script. b) Documentation for the --skip-no-email option has been added -- You are receiving this mail because: You are watching all bug changes.