[Bug 39741] New: xt/author/valid-templates.t should setting dirs to skip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 Bug ID: 39741 Summary: xt/author/valid-templates.t should setting dirs to skip Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 38340 added a bunch of form includes that all live in the same dir, to the exclusion list. We should refactor those tests so one can set a directory for exclusion instead of listing each file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |38340 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 [Bug 38340] Translatability - Standard form include files are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181462&action=edit Bug 39741: Make valid-templates.t handle dirs This patch changes the regex so it doesn't expect the exclusion parameters to only be files but accept directories too. The risk of this is we might at some point catch more than we want. I don't think it is worth spending more time in it, though. To test: 1. Run: $ ktd --shell k$ prove xt/author/valid-templates.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! We don't need to list each individual file anymore and it will still work! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Another option could be to properly refactor the parameters so the exclusion lists are two: files and dirs. And each use a different regex. I leave my 2 cents here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181462|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 181559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181559&action=edit Bug 39741: Make valid-templates.t handle dirs This patch changes the regex so it doesn't expect the exclusion parameters to only be files but accept directories too. The risk of this is we might at some point catch more than we want. I don't think it is worth spending more time in it, though. To test: 1. Run: $ ktd --shell k$ prove xt/author/valid-templates.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! We don't need to list each individual file anymore and it will still work! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Tests pass before and after the patch. 2. Getting lots of output with these lines - not sure whether this is a good or bad thing: - Argument "" isn't numeric in numeric gt (>)... - # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc because it cannot stand on its own -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181559|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181903&action=edit Bug 39741: Make valid-templates.t handle dirs This patch changes the regex so it doesn't expect the exclusion parameters to only be files but accept directories too. The risk of this is we might at some point catch more than we want. I don't think it is worth spending more time in it, though. To test: 1. Run: $ ktd --shell k$ prove xt/author/valid-templates.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! We don't need to list each individual file anymore and it will still work! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 Bug 39741 depends on bug 38340, which changed state. Bug 38340 Summary: Translatability - Standard form include files are not translatable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 --- Comment #8 from David Nind <david@davidnind.com> --- Changes to the test suite, no update to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #9 from David Nind <david@davidnind.com> --- Actual update the bug status! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 Bug 39741 depends on bug 38340, which changed state. Bug 38340 Summary: Translatability - Standard form include files are not translatable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39741 Bug 39741 depends on bug 38340, which changed state. Bug 38340 Summary: Translatability - Standard form include files are not translatable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org