[Bug 7314] New: Remove singleBranchMode system preference in favour of counting configured branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7314 Bug #: 7314 Summary: Remove singleBranchMode system preference in favour of counting configured branches Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: minor Priority: P4 Component: Architecture, internals, and plumbing AssignedTo: ian.walls@bywatersolutions.com ReportedBy: ian.walls@bywatersolutions.com QAContact: jonathan.druart@biblibre.com Instead of relying on a system preference to determine whether there is only a single branch in the system or not, why not just count how many distinct branches are in the branches table? This will reduce the number of moving parts, so to speak. Proposed subroutine in C4::Branch: GetBranchCount(). No inputs, returns integer value 0 or greater, corresponding to the output of SELECT count(*) FROM branches; Once this subroutine is in place, we can slowly remove references to singleBranchMode syspref, which will fix numerous bugs involved with that particular feature. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7314 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7156, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4941 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-12-14 14:14:58 UTC --- Ian, the description for singlebranchmode says "Allow/Don't allow patrons to select their branch on the OPAC." but it doesn't actually just do that. It also controls whether staff can choose their branch in the staff client. I think we need some such preference to let the libraries decide if their patrons and staff can choose a branch in the opac and staff client. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-14 14:21:39 UTC --- I think the description makes no sense as is. By design the SingleBranchMode is made to hide all things related to branches if you only have 1 branch. Because it makes no sense to have a branch facet, a pickup library or search for branches when there is only 1 branch. And the same applies to the staff interface. If there is only 1 branch, hiding the options is supposed to make it less confusing. So I think correcting the system preference description is the fix here, but there might be some additional functionality that is desirable. For example: - Make it possible to specify which branches are visible in the OPAC (so you could have an ILL library, internal departments as branches and such) - Make it possible to specify which libraries can be pickup locations - Make it a permission, if a staff user can change the library from his home library to another -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7314 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- Is this kind of duplicate of Bug 4941 ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7314 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 4941 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org