[Bug 41870] New: Warning "Use of uninitialized value $borrowernumber" in opac-detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41870 Bug ID: 41870 Summary: Warning "Use of uninitialized value $borrowernumber" in opac-detail.pl Initiative type: --- Sponsorship Sponsored status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: januszop@gmail.com Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org Under some circumstances (OPACShowHoldQueueDetails set, hold made, OPAC user not logged in) a warning like: [WARN] Use of uninitialized value $borrowernumber in numeric eq (==) at /kohadevbox/koha/opac/opac-detail.pl line 598. is being generated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41870 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41870 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 193340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193340&action=edit Bug 41870: Warning "Use of uninitialized value $borrowernumber" in opac-detail.pl Under some circumstances (OPACShowHoldQueueDetails set, hold made, OPAC user not logged in) a warning like: [WARN] Use of uninitialized value $borrowernumber in numeric eq (==) at /kohadevbox/koha/opac/opac-detail.pl line 598. is being generated. Test plan: ========== 1. Set OPACShowHoldQueueDetails to 'Show holds and their priority levels'. 2. From staff interface, place a hold on a record for any borrower. 3. Open a fresh browser (private mode or different browser), confirm that you are not logged in, go to this record. 4. Check the content of plack-opac-error.log. You should see a warning like: [WARN] Use of uninitialized value $borrowernumber in numeric eq (==) at /kohadevbox/koha/opac/opac-detail.pl line 598 5. Apply the patch ; restart_all. 6. Repeat p. 3 & 4. There should be no new warning now. Sponsored-by: Ignatianum University in Cracow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41870 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41870 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193340|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 193363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193363&action=edit Bug 41870: Warning "Use of uninitialized value $borrowernumber" in opac-detail.pl Under some circumstances (OPACShowHoldQueueDetails set, hold made, OPAC user not logged in) a warning like: [WARN] Use of uninitialized value $borrowernumber in numeric eq (==) at /kohadevbox/koha/opac/opac-detail.pl line 598. is being generated. Test plan: ========== 1. Set OPACShowHoldQueueDetails to 'Show holds and their priority levels'. 2. From staff interface, place a hold on a record for any borrower. 3. Open a fresh browser (private mode or different browser), confirm that you are not logged in, go to this record. 4. Check the content of plack-opac-error.log. You should see a warning like: [WARN] Use of uninitialized value $borrowernumber in numeric eq (==) at /kohadevbox/koha/opac/opac-detail.pl line 598 5. Apply the patch ; restart_all. 6. Repeat p. 3 & 4. There should be no new warning now. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41870 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41870 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41870 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 197059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197059&action=edit Bug 41870: Warning "Use of uninitialized value $borrowernumber" in opac-detail.pl Under some circumstances (OPACShowHoldQueueDetails set, hold made, OPAC user not logged in) a warning like: [WARN] Use of uninitialized value $borrowernumber in numeric eq (==) at /kohadevbox/koha/opac/opac-detail.pl line 598. is being generated. Test plan: ========== 1. Set OPACShowHoldQueueDetails to 'Show holds and their priority levels'. 2. From staff interface, place a hold on a record for any borrower. 3. Open a fresh browser (private mode or different browser), confirm that you are not logged in, go to this record. 4. Check the content of plack-opac-error.log. You should see a warning like: [WARN] Use of uninitialized value $borrowernumber in numeric eq (==) at /kohadevbox/koha/opac/opac-detail.pl line 598 5. Apply the patch ; restart_all. 6. Repeat p. 3 & 4. There should be no new warning now. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41870 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41870 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41870 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41870 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org