[Bug 41942] New: Hiding primary contact method hides lang with PatronSelfModificationBorrowerUnwantedField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 Bug ID: 41942 Summary: Hiding primary contact method hides lang with PatronSelfModificationBorrowerUnwantedField Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 34438 added lang in opac registration/modification form. But it is linked to primary contact method hidden or not. Looks like this is not on purpose. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34438 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 [Bug 34438] OPAC self registration form does not include lang (preferred language for notices) field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 193976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193976&action=edit Bug 41942: Fix lang hidding in opac patron modification Bug 34438 added lang in opac registration/modification form. But it is linked to primary contact method hidden or not. Looks like this is not on purpose. This patch removes this link. Test plan: 1) Verify system preference 'PatronSelfModificationBorrowerUnwantedField' is empty 2) Go to OPAC user account > Personal details 3) You see 'Preferred language for notices' 4) In system preference 'PatronSelfModificationBorrowerUnwantedField' check 'primary_contact_method' 5) Go to OPAC user account > Personal details => Without patch lang is also hidden => With patch lang is not hidden -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193976|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 193982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193982&action=edit Bug 41942: Fix lang hidding in opac patron modification Bug 34438 added lang in opac registration/modification form. But it is linked to primary contact method hidden or not. Looks like this is not on purpose. This patch removes this link. Test plan: 1) Verify system preference 'PatronSelfModificationBorrowerUnwantedField' is empty 2) Go to OPAC user account > Personal details 3) You see 'Preferred language for notices' 4) In system preference 'PatronSelfModificationBorrowerUnwantedField' check 'primary_contact_method' 5) Go to OPAC user account > Personal details => Without patch lang is also hidden => With patch lang is not hidden Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193982|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 198125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198125&action=edit Bug 41942: Fix lang hidding in opac patron modification Bug 34438 added lang in opac registration/modification form. But it is linked to primary contact method hidden or not. Looks like this is not on purpose. This patch removes this link. Test plan: 1) Verify system preference 'PatronSelfModificationBorrowerUnwantedField' is empty 2) Go to OPAC user account > Personal details 3) You see 'Preferred language for notices' 4) In system preference 'PatronSelfModificationBorrowerUnwantedField' check 'primary_contact_method' 5) Go to OPAC user account > Personal details => Without patch lang is also hidden => With patch lang is not hidden Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org