[Bug 38547] New: Improve the code for the MARC ordering process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Bug ID: 38547 Summary: Improve the code for the MARC ordering process Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org There are some improvements needed to the code in bug 34355 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34355 Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 [Bug 34355] Automated MARC record ordering process -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Comments from bug 34355 1. Missing tests! 2. Useless lines + my @messages; +use Net::FTP; 3. Plugin hook added without being advertised (wiki, kitchenzink?) + 'before_orderline_create', 4. Code for acq not in Koha::Acquisition? 5. controller poorly written and not following standard admin/marc_order_accounts.pl * useless use statements * 51 my $crypt = Koha::Encryption->new; wtf? * values for '$op' not following "standard" * no error handling, no user messages/alerts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175018&action=edit Bug 38547: Move code to Koha/Acquisitions and add more tests Test plan: 1) prove t/db_dependent/Koha/Acquisition/MarcOrder.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175019&action=edit Bug 38547: Bring controller in line with modern standards Test plan: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Enable MarcOrderingAutomation 3) In the administration homepage, under Acquisition parameters there should now be a link called "MARC order accounts" 4) Click on this and click the New account button 5) Create a new account and then experiment with editing and deleting the account. 6) These actions should all work and there should be bootstrap messages displayed for each action -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Hi Matt! Could you please rebase this? Thanks, --Laura E. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175018|0 |1 is obsolete| | --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181676&action=edit Bug 38547: Move code to Koha/Acquisitions and add more tests Test plan: 1) prove t/db_dependent/Koha/Acquisition/MarcOrder.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175019|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181677&action=edit Bug 38547: Bring controller in line with modern standards Test plan: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Enable MarcOrderingAutomation 3) In the administration homepage, under Acquisition parameters there should now be a link called "MARC order accounts" 4) Click on this and click the New account button 5) Create a new account and then experiment with editing and deleting the account. 6) These actions should all work and there should be bootstrap messages displayed for each action -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lin-wei.li@inLibro.com --- Comment #7 from Lin Wei <lin-wei.li@inLibro.com> --- # Test Execution 1. Applied 181676. 2. Ran `prove t/db_dependent/Koha/Acquisition/MarcOrder.t`. 3. See [Test Results] below. 4. Applied both 181676 and 181677. 5. Ran `prove t/db_dependent/Koha/Acquisition/MarcOrder.t`. 6. Same output. # Test Results prove t/db_dependent/Koha/Acquisition/MarcOrder.t t/db_dependent/Koha/Acquisition/MarcOrder.t .. 1/10 # Looks like you planned 5 tests but ran 1. # Failed test 'add_biblio_from_import_record()' # at t/db_dependent/Koha/Acquisition/MarcOrder.t line 276. Undefined subroutine &Koha::MarcOrder::add_biblio_from_import_record called at t/db_dependent/Koha/Acquisition/MarcOrder.t line 247. # Looks like your test exited with 255 just after 3. t/db_dependent/Koha/Acquisition/MarcOrder.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 8/10 subtests Test Summary Report ------------------- t/db_dependent/Koha/Acquisition/MarcOrder.t (Wstat: 65280 (exited 255) Tests: 3 Failed: 1) Failed test: 3 Non-zero exit status: 255 Parse errors: Bad plan. You planned 10 tests but ran 3. Files=1, Tests=3, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.87 cusr 0.07 csys = 0.95 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181676|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182435&action=edit Bug 38547: Move code to Koha/Acquisitions and add more tests Test plan: 1) prove t/db_dependent/Koha/Acquisition/MarcOrder.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181677|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182436&action=edit Bug 38547: Bring controller in line with modern standards Test plan: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Enable MarcOrderingAutomation 3) In the administration homepage, under Acquisition parameters there should now be a link called "MARC order accounts" 4) Click on this and click the New account button 5) Create a new account and then experiment with editing and deleting the account. 6) These actions should all work and there should be bootstrap messages displayed for each action -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Lin Wei <lin-wei.li@inLibro.com> --- # Test Results Unit tests pass. Webpage of new feature fails to load. # Test Execution 1. Apply 182435. 2. Run `prove t/db_dependent/Koha/Acquisition/MarcOrder.t`. => success. 3. Apply 182436. 4. Run `prove t/db_dependent/Koha/Acquisition/MarcOrder.t`. => success. 5. In "Koha administration", search for "MarcOrderingAutomation" and set to "Enable." 6. Go to "Acquisitions." 7. Under "Administration," click on "MARC order accounts." => Page fails to load with Error 500 Internal Server Error. # Additional Notes - URL that crashed: /cgi-bin/koha/admin/marc_order_accounts.pl - Apache2 error log: [Wed May 14 16:00:02.166822 2025] [cgid:error] [pid 310819] [client 127.0.0.1:60780] End of script output before headers: marc_order_accounts.pl, referer: http://master-intranet/cgi-bin/koha/acqui/acqui-home.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Hi, you might need to run a restart_all after applying the patches - the web page is working normally for me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- [FAIL] admin/marc_order_accounts.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl admin/marc_order_accounts.pl` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182435|0 |1 is obsolete| | --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189387&action=edit Bug 38547: Move code to Koha/Acquisitions and add more tests Test plan: 1) prove t/db_dependent/Koha/Acquisition/MarcOrder.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182436|0 |1 is obsolete| | --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 189388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189388&action=edit Bug 38547: Bring controller in line with modern standards Test plan: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Enable MarcOrderingAutomation 3) In the administration homepage, under Acquisition parameters there should now be a link called "MARC order accounts" 4) Click on this and click the New account button 5) Create a new account and then experiment with editing and deleting the account. 6) These actions should all work and there should be bootstrap messages displayed for each action -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org