[Bug 16405] New: Fix Circulation/NoIssuesChargeGuarantees.t test 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Bug ID: 16405 Summary: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: m.de.rooy@rijksmuseum.nl QA Contact: gmcharlt@gmail.com Resolve: # Failed test 'Patron cannot check out item due to debt for guarantee' # at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63. # got: '10' # expected: '10.00' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51053&action=edit Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Resolves: Failed test 'Patron cannot check out item due to debt for guarantee' at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63. got: '10' expected: '10.00' Test plan: Run the test again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51053|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51061&action=edit [SIGNED-OFF] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Resolves: Failed test 'Patron cannot check out item due to debt for guarantee' at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63. got: '10' expected: '10.00' Test plan: Run the test again. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass, no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Bernardo Gonzalez Kriegel from comment #2)
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Thx for your signoffs, Bernardo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14577 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51076&action=edit [ALTERNATIVE-PATCH] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Resolves: Failed test 'Patron cannot check out item due to debt for guarantee' at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63. got: '10' expected: '10.00' Test plan: Run the test again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marcel, I think it's better to keep `is`, could you have a look at my alternative patch please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51061|0 |1 is obsolete| | Attachment #51076|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51079&action=edit Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Resolves: Failed test 'Patron cannot check out item due to debt for guarantee' at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63. got: '10' expected: '10.00' Test plan: Run the test again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- No problem. is( $issuingimpossible->{DEBT_GUARANTEES} == 10.00 , 1, '') and is( $issuingimpossible->{DEBT_GUARANTEES} + 0, '10.00' + 0, '') look the same to me btw -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy@rijksmuseum.nl |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51079|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 51113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51113&action=edit Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Resolves: Failed test 'Patron cannot check out item due to debt for guarantee' at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63. got: '10' expected: '10.00' Test plan: Run the test again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org