https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51051&action=edit Bug 16404: Fix Circulation/Branch.t (tests 8-11) Resolves: Failed test 'GetBranchitem returns holdallowed and return branch' at t/db_dependent/Circulation/Branch.t line 226. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'Without parameters GetBranchItemRule returns the values in default_circ_rules' at t/db_dependent/Circulation/Branch.t line 234. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules' at t/db_dependent/Circulation/Branch.t line 239. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'With only one parametern GetBranchItemRule returns default values' at t/db_dependent/Circulation/Branch.t line 244. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Test plan: Run test before and after applying this patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51051|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 51052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51052&action=edit Bug 16404: Fix Circulation/Branch.t (tests 8-11) Resolves: Failed test 'GetBranchitem returns holdallowed and return branch' at t/db_dependent/Circulation/Branch.t line 226. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'Without parameters GetBranchItemRule returns the values in default_circ_rules' at t/db_dependent/Circulation/Branch.t line 234. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules' at t/db_dependent/Circulation/Branch.t line 239. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'With only one parametern GetBranchItemRule returns default values' at t/db_dependent/Circulation/Branch.t line 244. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Test plan: Run test before and after applying this patch. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15534 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51052|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51075&action=edit Bug 16404: Fix Circulation/Branch.t (tests 8-11) Resolves: Failed test 'GetBranchitem returns holdallowed and return branch' at t/db_dependent/Circulation/Branch.t line 226. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'Without parameters GetBranchItemRule returns the values in default_circ_rules' at t/db_dependent/Circulation/Branch.t line 234. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules' at t/db_dependent/Circulation/Branch.t line 239. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Failed test 'With only one parametern GetBranchItemRule returns default values' at t/db_dependent/Circulation/Branch.t line 244. Structures begin differing at: $got->{hold_fulfillment_policy} = 'any' $expected->{hold_fulfillment_policy} = Does not exist Test plan: Run test before and after applying this patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Note: I do not see the usefulness of the lazy_any variable, I don't think it make things easier to read. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |julian.maurice@biblibre.com Resolution|--- |FIXED --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.