[Bug 25838] New: Sort facets values by number of occurrences (Zebra)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 Bug ID: 25838 Summary: Sort facets values by number of occurrences (Zebra) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com Actually with Zebra facets values are sorted alphabetically. This is a comment from Bug 12478 : << Bug 12478: Display facet terms ordered by number of occurrences By default ES returns the facet terms ordered by most used, which makes sense. This patch removes resort done in the scripts (catalogue/search.pl and opac/opac-search.pl) and moves it to the module. For Zebra it's now done in C4::Search::getRecords, and there is no change to expect (still alphabetically).
Looks like the sort by number of occurrences is already done in C4::Search::getRecords, it is an additionnal code that re-sort alphabetically. This patch proposes to remove it in order to have same sort order between Zebra and ES. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 106145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106145&action=edit Bug 25838: Sort facets values by number of occurrences (Zebra) Actually with Zebra facets values are sorted alphabetically. This is a comment from Bug 12478 : << Bug 12478: Display facet terms ordered by number of occurrences By default ES returns the facet terms ordered by most used, which makes sense. This patch removes resort done in the scripts (catalogue/search.pl and opac/opac-search.pl) and moves it to the module. For Zebra it's now done in C4::Search::getRecords, and there is no change to expect (still alphabetically).
Looks like the sort by number of occurrences is already done in C4::Search::getRecords, it is an additionnal code that re-sort alphabetically. This patch proposes to remove it in order to have same sort order between Zebra and ES. Test plan : 1) Use Zebra searchengine and enable system preference 'displayFacetCount' 2) Without patch : 3) Perform a search with a lot of results 4) Look at facet author => You see sort is alphabetical (A to Z) 5) Apply patch : 6) Perform the same search 7) Look at facet author => You see sort is by number of occurrences decreasing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure about this change for Zebra. We have turned off Zebra facets (using Koha Zebra facets) in almost all installations because it creates a huge hit on performance. If you use Koha facetting it will only count the first pages occurrences... and sorting by that is really bad. I'd prefer the alphabetic for Zebra Koha facets at least. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #2)
I am not sure about this change for Zebra. We have turned off Zebra facets (using Koha Zebra facets) in almost all installations because it creates a huge hit on performance. If you use Koha facetting it will only count the first pages occurrences... and sorting by that is really bad. I'd prefer the alphabetic for Zebra Koha facets at least.
Indeed this appears with Zebra facets OFF, its pure perl code in C4/Search.pm. Even with the first pages limitation, consistency with ES is good i think. Or a system preference ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Elastic gives you real facets... so I am torn. Maybe good to get another opinion here. My worry is that it might give a wrong impression... but our limited Zebra facets might always do that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Looks like a fairly trivial change at a glance? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe it works, the question is about presentation in the OPAC - sorting alphabetic or by occurrence. As we only look for occurrences on the first page the numbers are inaccurate (with no Zebra facets). So I was saying I prefer alphabetic because it does maybe give less of a false impression. Comparing to Elastic facets doesn't work here I think as they work very differently and results should be much more trustable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #6)
I believe it works, the question is about presentation in the OPAC - sorting alphabetic or by occurrence. As we only look for occurrences on the first page the numbers are inaccurate (with no Zebra facets). So I was saying I prefer alphabetic because it does maybe give less of a false impression.
Comparing to Elastic facets doesn't work here I think as they work very differently and results should be much more trustable.
That's true, although maybe that's all the more reason to get rid of non-Zebra facets, and to more fully embrace Elasticsearch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We can't yet. Elasticsearch is not widely used yet and won't be for quite a while (maybe some will never use it because of its requirements) and the Zebra facets are too slow. We tried, search times were horrible. We had to switch back. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Indeed non-Zebra facets are limited, what ever the sorting of the values. But giving values by number of occurrences is in the definition of a facet in my opinion. I'm trying to get more opinions by email. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Frido, I think you are right for "real" facets... but ours are not in case of Zebra. The occurence you sort after is only for the result set we look at - the first 20 records. I think it will cause a lot more questions about this wonky feature than help :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 Stefano Bargioni <bargioni@pusc.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bargioni@pusc.it --- Comment #11 from Stefano Bargioni <bargioni@pusc.it> --- Zebra facetes are not reliable. One of the most important reasons for introducing Elasticsearch was this limitation. With Elastic, I suggest to sort by number of occurrences by default (or even by syspref). And if possible, also add sort by key. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Ok its indeed not simple to choose. I set in discussion, and will close if does not move for a while. Thanks for your time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- *** This bug has been marked as a duplicate of bug 28826 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org