https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85925&action=edit Bug 22445: Add new prefs *CustomCoverImages* This patch set adds a new method to display cover images for bibliographic records. The idea is to provide a flexible way allowing several use cases: - local path - remote url - webservice which would follow a given pattern. So far only the following patterns are available: - %isbn% will be replaced byt the isbn of the record - %issn% - using MARC subfields: %024$a% to replace with the value in 024$a For example - /your/local/images/%isbn%.png - https://covers.openlibrary.org/b/isbn/%isbn%-M.jpb - etc. There are 3 new sysprefs: CustomCoverImagesURL => Define the path/url CustomCoverImages => Turn on/off the display of the custom cover image in the staff client OPACCustomCoverImages => Turn on/off the display of the custom cover image at the OPAC Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85927&action=edit Bug 22445: Add tests for Koha::Biblio->custom_cover_image_url Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85929&action=edit Bug 22445: Custom cover images - opac shelfbrowser Test plan: Go to the detail page of a bibliographic record (at the OPAC) and confirm the at custom cover images are displayed in the shelf browser Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85931&action=edit Bug 22445: Custom cover images - opac detail Test plan: Go to the bibliographic record detail page at the OPAC, you should see the custom cover image. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85933&action=edit Bug 22445: Custom cover images - opac shelves Test plan: Add a bibliographic record (that has a custom image) to a shelf, view the shelf (OPAC). You should see the image. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85935&action=edit Bug 22445: Custom cover images - opac reviews (rss) Test plan: Same as previous patch, then click on the feeds link Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85937&action=edit Bug 22445: Custom cover images - detail (staff) Test plan: Staff side now, go the detail page of a bibliographic record You should see the cover image. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |hayleymapley@catalyst.net.n | |z --- Comment #15 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- These patches don't seem to work fully as expected for me, as outlined below. When clicking Edit on the bibliographic record details page and uploading a custom image, all test plans pass except for: - OPAC reviews (Comment #11 rss - template is still broken it seems), - OPAC reviews (Comment #10 Recent Comments), - OPAC user (Comment #12 checkout list). In the case of the latter two scenarios, instead of displaying the image or the 'no cover image' placeholder image, a link that says 'Cover image' is displayed. In terms of the url/local path options in the system prefs, is there anything that needs to be done apart from allowing display, setting the path/url and ensuring that the biblio has a url that is present in the path/url? I'm having trouble testing this (I'm pretty new) Additionally, in most places where the cover image is displayed (such as the item detail page, etc.), the 'Cover image' link is also displayed underneath. I'm assuming this is a bug? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Haley, 'Failed QA' is ok for getting answers to your questions. Thx for testing! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #18 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #17)

(In reply to Hayley Mapley from comment #15)

...

These patches don't seem to work fully as expected for me, as outlined below.

When clicking Edit on the bibliographic record details page and uploading a custom image, all test plans pass except for: - OPAC reviews (Comment #11 rss - template is still broken it seems), - OPAC reviews (Comment #10 Recent Comments), - OPAC user (Comment #12 checkout list). In the case of the latter two scenarios, instead of displaying the image or the 'no cover image' placeholder image, a link that says 'Cover image' is displayed.

In terms of the url/local path options in the system prefs, is there anything that needs to be done apart from allowing display, setting the path/url and ensuring that the biblio has a url that is present in the path/url? I'm having trouble testing this (I'm pretty new)

Additionally, in most places where the cover image is displayed (such as the item detail page, etc.), the 'Cover image' link is also displayed underneath. I'm assuming this is a bug?

Hello Hayley, Did you fill CustomCoverImagesURL in? What value? You are not supposed to attach an image to the record (this is the LocalCoverImages feature) neither add "an url to a biblio" (I did not understand that part in your comment).

To test easily you can use "https://covers.openlibrary.org/b/isbn/%isbn%-M.jpg" (and not .jpb as written in the test plan, sorry it's a typo!)

Then the feature will behave the same as OpenLibraryCovers (it will pick the same covers).

Gah! As confusingly written as my comment was (and excluding the fact that I was mistakenly also testing the local cover images), I was simply missing the -M part of that URL which was stopping it from working. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85938|0 |1 is obsolete| | --- Comment #19 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 86214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86214&action=edit Bug 22445: Custom cover images - search resulta (staff) Test plan: Search for bibliographic records, the custom covers should be displayed. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> All test plans pass using URL in CustomcoverImages syspref -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #20 from Hugo Agud <hagud@orex.es> --- I have checked all test plan and it works fine, JUST the image size is the original image size, then if the thumbnail is bigger the image appear big... it can be fixed by css for sure.. but perhaps some kind of code limitation? it is just a suggestions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #21)

We should deal with that problem globally, but on a separate bug report of course as it will complexity this patch set a lot.

All other cover image sources provide a generally-acceptable image size for all cover images. With local cover images, we provide the option for users to upload images but then we have Koha generate a thumbnail. For this feature to all any size image to be displayed is inconsistent with what we have now. I'm going to submit patches to add classes to the display of cover images and add CSS to specify a maximum width for these covers. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86726&action=edit Bug 22455: (follow-up) Use CSS to set a max-width for images - OPAC This patch adds some CSS and markup to OPAC templates so that custom cover images have a maximum width of 140px (to match the width of generated local cover image thumbnails). This prevents oversized images from displaying inconsistently compared to images from other services. To test, apply the patch and regenerate the OPAC CSS. Post an oversized image which corresponds to a record in your OPAC which can be added to a user's checkouts and to a list. View the following pages to confirm that the image displays well: - OPAC search results - Bibliographic detail page - Shelf browser - List contents - Recent comments - "Your summary" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- I have a concern which I think may be a blocker for this feature: All other cover image sources use a "normalized_isbn" variable which is provided to the templates. This feature doesn't use a normalized ISBN, so a library might upload an image file with a name like this: "0553573403.png" ...and find that Koha is trying to load an image with this file name: "0553573403 | 9780553573404 (pbk.).png" I think it would be more consistent to have custom cover images use a normalized ISBN too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #27 from Hugo Agud <hagud@orex.es> --- I have applied the patch, it appears the class Cover Image, but src is emtpy then no image is published -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 87434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87434&action=edit Bug 22445: Add new pattern %normalized_isbn% Quite bad to use C4::Koha from Koha::Biblio :-/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Maria <mbugz2@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mbugz2@yahoo.com --- Comment #31 from Maria <mbugz2@yahoo.com> --- Tried to test. Test plan is divided into pieces and difficult to follow. When we turned on the new sysprefs (CustomCoverImagesURL etc) the result was that we got a few images. The images that were added in result list had a link to the image itself, not to the OPAC record. Would be good with new consolidated test plan. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89974&action=edit Bug 22445: Add new method Koha::Biblio->custom_cover_image_url Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89976&action=edit Bug 22445: Allow marc fields as pattern %tag$field% There is a limitation here, only one replacement will work. Let see if it is needed later to support several patterns Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89978&action=edit Bug 22445: Custom cover images - opac results Test plan: Search for bibliographic records at the OPAC, the custom cover should be displayed Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89980&action=edit Bug 22445: Custom cover images - opac result (rss) This cannot be tested, it seems that the template is broken. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89982&action=edit Bug 22445: Custom cover images - opac reviews Test plan: - enable OpacShowRecentComments - make a comment (OPAC) - approve it (staff) - click 'Recent comments' (OPAC) => You should see the custom cover Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89984&action=edit Bug 22445: Custom cover images - opac user (checkout list) Test plan: - Check an item out to a patron - At the OPAC loggin as this patron On the checkout list you should see the cover image. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89986&action=edit Bug 22445: Custom cover images - search resulta (staff) Test plan: Search for bibliographic records, the custom covers should be displayed. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> All test plans pass using URL in CustomcoverImages syspref -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89988&action=edit Bug 22445: (follow-up) Use CSS to set a max-width for images - Staff client This patch adds some CSS and markup to staff client templates so that custom cover images have a maximum width of 140px (to match the width of generated local cover image thumbnails). This prevents oversized images from displaying inconsistently compared to images from other services. This patch also adds a missing </a> to fix display problems. To test, apply the patch and regenerate the staff client CSS. Post an oversized image which corresponds to a record in your catalog. View the following pages to confirm that the image displays well: - Catalog search results - Bibliographic detail page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #52 from Michal Denar <black23@gmail.com> --- Created attachment 89997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89997&action=edit Bug 22445: Add new method Koha::Biblio->custom_cover_image_url Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #54 from Michal Denar <black23@gmail.com> --- Created attachment 89999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89999&action=edit Bug 22445: Allow marc fields as pattern %tag$field% There is a limitation here, only one replacement will work. Let see if it is needed later to support several patterns Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #56 from Michal Denar <black23@gmail.com> --- Created attachment 90001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90001&action=edit Bug 22445: Custom cover images - opac results Test plan: Search for bibliographic records at the OPAC, the custom cover should be displayed Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #58 from Michal Denar <black23@gmail.com> --- Created attachment 90003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90003&action=edit Bug 22445: Custom cover images - opac result (rss) This cannot be tested, it seems that the template is broken. Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #60 from Michal Denar <black23@gmail.com> --- Created attachment 90005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90005&action=edit Bug 22445: Custom cover images - opac reviews Test plan: - enable OpacShowRecentComments - make a comment (OPAC) - approve it (staff) - click 'Recent comments' (OPAC) => You should see the custom cover Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #62 from Michal Denar <black23@gmail.com> --- Created attachment 90007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90007&action=edit Bug 22445: Custom cover images - opac user (checkout list) Test plan: - Check an item out to a patron - At the OPAC loggin as this patron On the checkout list you should see the cover image. Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #64 from Michal Denar <black23@gmail.com> --- Created attachment 90010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90010&action=edit Bug 22445: Custom cover images - search resulta (staff) Test plan: Search for bibliographic records, the custom covers should be displayed. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> All test plans pass using URL in CustomcoverImages syspref Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #66 from Michal Denar <black23@gmail.com> --- Created attachment 90012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90012&action=edit Bug 22445: (follow-up) Use CSS to set a max-width for images - Staff client This patch adds some CSS and markup to staff client templates so that custom cover images have a maximum width of 140px (to match the width of generated local cover image thumbnails). This prevents oversized images from displaying inconsistently compared to images from other services. This patch also adds a missing </a> to fix display problems. To test, apply the patch and regenerate the staff client CSS. Post an oversized image which corresponds to a record in your catalog. View the following pages to confirm that the image displays well: - Catalog search results - Bibliographic detail page Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | --- Comment #68 from Kyle M Hall <kyle@bywatersolutions.com> --- This -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #71 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #69)

This looks pretty good, but I have one request; can you use Template Toolkit syntax instead of yet another bespoke syntax? If we standardize on TT for all templating we'll make everyone's lives much simpler.

I am not sure about that tbh, because the TT syntax is hard for users. With the notices we still have trouble because of lack of documentation, lack of 'knowing the right variable names'. There is also a security risk we discussed in other spots, as it allows you to use regex and similar and possibly do harm with it. That said, I think this is stuck on Jonathan's question about the MARC syntax. Would it be possible to move this forward as is and treat the TT as possible enhancement later on? Or allow TT syntax additionally? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #73 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #72)

With the plethora of schemes out there I must admit I'm not entirely comfortable with the choice of `%` character being used:

...

Of the ASCII character set, the characters : / ? # [ ] @ are reserved for use as delimiters of the generic URI components and must be percent-encoded – for example, %3F for a question mark.[15] The characters ! $ & ' ( ) * + , ; = are permitted by generic URI syntax to be used unencoded in the user information, host, and path as delimiters.[10][16] Additionally, : and @ may appear unencoded within the path, query, and fragment; and ? and / may appear unencoded as data within the query or fragment.

So, given the above quote, one could find that we are misinterpreting % in our regex when it's being used as an escape character.

I'm not too worried about whether we mimic TT syntax here or not so long as what we do offer is well documented alongside the preference itself.

Which character would you suggest then? :) The substitutions are like: $url =~ s|%normalized_isbn%|$normalized_isbn|g So whichever we pick should be safe. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Happy with bash style.. or just plain moustache templating style might be even simpler for end users. https://my_url/{normalized_isbn}.png -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like {} too, it's also used in other prefs like SearchForTitleIn. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #79 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I agree, 3 out of 4 commenters have agreed on {}. Let's get this into master ASAP! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89996|0 |1 is obsolete| | Attachment #89997|0 |1 is obsolete| | Attachment #89998|0 |1 is obsolete| | Attachment #89999|0 |1 is obsolete| | Attachment #90000|0 |1 is obsolete| | Attachment #90001|0 |1 is obsolete| | Attachment #90002|0 |1 is obsolete| | Attachment #90003|0 |1 is obsolete| | Attachment #90004|0 |1 is obsolete| | Attachment #90005|0 |1 is obsolete| | Attachment #90006|0 |1 is obsolete| | Attachment #90007|0 |1 is obsolete| | Attachment #90009|0 |1 is obsolete| | Attachment #90010|0 |1 is obsolete| | Attachment #90011|0 |1 is obsolete| | Attachment #90012|0 |1 is obsolete| | Attachment #90013|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94227&action=edit Bug 22445: Add new prefs *CustomCoverImages* This patch set adds a new method to display cover images for bibliographic records. The idea is to provide a flexible way allowing several use cases: - local path - remote url - webservice which would follow a given pattern. So far only the following patterns are available: - {isbn} will be replaced byt the isbn of the record - {issn} - using MARC subfields: {024$a} to replace with the value in 024$a (Note that the selector has been changed from %% to {} in a coming patch) For example - /your/local/images/{isbn}.png - https://covers.openlibrary.org/b/isbn/{isbn}-M.jpb - etc. There are 3 new sysprefs: CustomCoverImagesURL => Define the path/url CustomCoverImages => Turn on/off the display of the custom cover image in the staff client OPACCustomCoverImages => Turn on/off the display of the custom cover image at the OPAC Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #82 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94229&action=edit Bug 22445: Add tests for Koha::Biblio->custom_cover_image_url Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #84 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94231&action=edit Bug 22445: Custom cover images - opac shelfbrowser Test plan: Go to the detail page of a bibliographic record (at the OPAC) and confirm the at custom cover images are displayed in the shelf browser Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #86 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94233&action=edit Bug 22445: Custom cover images - opac detail Test plan: Go to the bibliographic record detail page at the OPAC, you should see the custom cover image. Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #88 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94235&action=edit Bug 22445: Custom cover images - opac shelves Test plan: Add a bibliographic record (that has a custom image) to a shelf, view the shelf (OPAC). You should see the image. Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #90 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94237&action=edit Bug 22445: Custom cover images - opac reviews (rss) Test plan: Same as previous patch, then click on the feeds link Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #92 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94239&action=edit Bug 22445: Custom cover images - detail (staff) Test plan: Staff side now, go the detail page of a bibliographic record You should see the cover image. Sponsored-by: Orex Digital Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #94 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94241&action=edit Bug 22445: (follow-up) Use CSS to set a max-width for images - OPAC This patch adds some CSS and markup to OPAC templates so that custom cover images have a maximum width of 140px (to match the width of generated local cover image thumbnails). This prevents oversized images from displaying inconsistently compared to images from other services. To test, apply the patch and regenerate the OPAC CSS. Post an oversized image which corresponds to a record in your OPAC which can be added to a user's checkouts and to a list. View the following pages to confirm that the image displays well: - OPAC search results - Bibliographic detail page - Shelf browser - List contents - Recent comments - "Your summary" Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #96 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94243&action=edit Bug 22445: Add new pattern %normalized_isbn% Quite bad to use C4::Koha from Koha::Biblio :-/ Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #98 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks everybody for your feedback, much appreciated! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94228|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94560&action=edit Bug 22445: Add new method Koha::Biblio->custom_cover_image_url Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94230|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94562&action=edit Bug 22445: Allow marc fields as pattern %tag$field% There is a limitation here, only one replacement will work. Let see if it is needed later to support several patterns Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94232|0 |1 is obsolete| | --- Comment #104 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94564&action=edit Bug 22445: Custom cover images - opac results Test plan: Search for bibliographic records at the OPAC, the custom cover should be displayed Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94234|0 |1 is obsolete| | --- Comment #106 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94567&action=edit Bug 22445: Custom cover images - opac result (rss) This cannot be tested, it seems that the template is broken. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94236|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94569&action=edit Bug 22445: Custom cover images - opac reviews Test plan: - enable OpacShowRecentComments - make a comment (OPAC) - approve it (staff) - click 'Recent comments' (OPAC) => You should see the custom cover Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94238|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94571&action=edit Bug 22445: Custom cover images - opac user (checkout list) Test plan: - Check an item out to a patron - At the OPAC loggin as this patron On the checkout list you should see the cover image. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94240|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94573&action=edit Bug 22445: Custom cover images - search resulta (staff) Test plan: Search for bibliographic records, the custom covers should be displayed. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94242|0 |1 is obsolete| | --- Comment #114 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94575&action=edit Bug 22445: (follow-up) Use CSS to set a max-width for images - Staff client This patch adds some CSS and markup to staff client templates so that custom cover images have a maximum width of 140px (to match the width of generated local cover image thumbnails). This prevents oversized images from displaying inconsistently compared to images from other services. This patch also adds a missing </a> to fix display problems. To test, apply the patch and regenerate the staff client CSS. Post an oversized image which corresponds to a record in your catalog. View the following pages to confirm that the image displays well: - Catalog search results - Bibliographic detail page Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94244|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94577&action=edit Bug 22445: Replace %% with {} Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #117 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks good and works well.. passes the QA scripts... Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #118 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi --- Comment #119 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- The database upgrade breaks on my kohadevbox setup (mysql-server package version 5.7.27-0ubuntu0.18.04.1):

$ updatedatabase Upgrade to 19.06.00.042 done (Bug 22445 - Add new pref *CustomCoverImages*) DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IGNORE TABLE accountlines ADD debit_type_code ' at line 1 [for Statement " ALTER IGNORE TABLE accountlines ADD debit_type_code varchar(80) DEFAULT NULL AFTER accounttype "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 19888. DBD::mysql::db do failed: Key column 'debit_type_code' doesn't exist in table [for Statement " ALTER TABLE accountlines ADD CONSTRAINT `accountlines_ibfk_debit_type` FOREIGN KEY (`debit_type_code`) REFERENCES `account_debit_types` (`code`) ON DELETE RESTRICT ON UPDATE CASCADE "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 19901. DBD::mysql::db do failed: Unknown column 'debit_type_code' in 'field list' [for Statement " UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL WHERE accounttype IN (SELECT code from account_debit_types) "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 19910. Upgrade to 19.06.00.043 done (Bug 23049 - Add account debit_types) DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IGNORE TABLE accountlines ADD credit_type_code' at line 1 [for Statement " ALTER IGNORE TABLE accountlines ADD credit_type_code varchar(80) DEFAULT NULL AFTER accounttype "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 19992. DBD::mysql::db do failed: Key column 'credit_type_code' doesn't exist in table [for Statement " ALTER TABLE accountlines ADD CONSTRAINT `accountlines_ibfk_credit_type` FOREIGN KEY (`credit_type_code`) REFERENCES `account_credit_types` (`code`) ON DELETE RESTRICT ON UPDATE CASCADE "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 20005. DBD::mysql::db do failed: Unknown column 'credit_type_code' in 'field list' [for Statement " UPDATE accountlines SET credit_type_code = accounttype, accounttype = NULL WHERE accounttype IN (SELECT code from account_credit_types) "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 20067. Upgrade to 19.06.00.044 done (Bug 23805 - Add account credit_types) Upgrade to 19.06.00.045 done (Bug 23866 - Set HEA syspref to prompt for review) Upgrade to 19.06.00.046 done (Bug 15260 - Option for extended loan with useDaysMode) Upgrade to 19.06.00.047 done (Bug 14697 - Extend and enhance 'Claims returned' lost status) Upgrade to 19.06.00.048 done (Bug 22581 - add new OPACShowMusicalInscripts and OPACPlayMusicalInscripts system preferences) Upgrade to 19.06.00.049 done (Bug 13958 - Add a SuspensionsCalendar syspref) Upgrade to 19.06.00.050 done (Bug 23293 - Add 'OPACFineNoRenewalsIncludeCredits' system preference)

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #121 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Fix pushed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patchset adds three |This development adds the release notes|new system preferences: |ability to use alternative |* |cover art providers who |`CustomCoverImagesURL` - A |provide covers openly via |URL string from which to |consistent URLs. It adds |fetch cover images. |three new system |* |preferences: |`CustomCoverImages` - |* |Allowing administrators to |`CustomCoverImagesURL` - A |enable custom cover images |URL string from which to |display in the staff |fetch cover images. |client. |* |* |`CustomCoverImages` - |`OPACCustomCoverImages` - |Allowing administrators to |Allowing administrators to |enable custom cover images |enable custom cover images |display in the staff |display at the OPAC. |client. | |* | |`OPACCustomCoverImages` - | |Allowing administrators to | |enable custom cover images | |display at the OPAC. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This development adds the |This development adds the release notes|ability to use alternative |ability to use alternative |cover art providers who |cover art providers who |provide covers openly via |provide covers openly via |consistent URLs. Three new |consistent URLs. |system preferences are |Three new |introduced, |system preferences are |`CustomCoverImagesURL`, |introduced, |`CustomCoverImages` and |`CustomCoverImagesURL`, |`OPACCustomCoverImages`. |`CustomCoverImages` and | |`OPACCustomCoverImages`. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #123 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Hugo Agud from comment #122)

We have identified one issue this this functionality, when there is no value in the variable isbn, issn.. or wathever the patch generate the <img src> anyway generating an empty thumnail link.

Please move this to a separate bug report linked to this one - this is already in released versions so it needs to be fixed on a new bug report. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 [Bug 26921] Create cover image even when there is no record identificator -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #124 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I did't manage to use 001 - is there a special syntax to use for control fields? -- You are receiving this mail because: You are watching all bug changes.