[Bug 16232] New: Edit as new (duplicate) doesn't work correctly with Rancor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Bug ID: 16232 Summary: Edit as new (duplicate) doesn't work correctly with Rancor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: jweaver@bywatersolutions.com Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Marked as bug because the behavior is confusing (shows empty record but saves over old record). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Brian <bklein@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bklein@dubuque.lib.ia.us --- Comment #1 from Brian <bklein@dubuque.lib.ia.us> --- Any updates Carnegie Team -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like the current record is opened instead of a 'copy' of it that will save as new. This can cause unwanted data loss, updating severity. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|jweaver@bywatersolutions.co |koha-bugs@lists.koha-commun |m |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22748 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22748 [Bug 22748] Wrong permission check in addbiblio.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 --- Comment #3 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 88401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88401&action=edit Bug 16232: Fix edit as new in Rancor When you edit a biblio as new, and you have enabled advanced editor, current record was opened, and was overwritten when saved. This patch effectively opens a new record based on the one selected. To test: 1) Enable "EnableAdvancedCatalogingEditor" preference 2) Go to cataloguing and click on advanced editor to save preference to the cookie 3) Search for an item in catalog 4) Click in "Edit as new (duplicate)" 5) Advanced editor should appear. CHECK => browser url ends with #catalog/{original biblionumber} => Title above toolbar is "Editing catalog record #{original biblionumber}" 6) Apply this patch 7) Repeat steps 3 to 5 SUCCESS => browser url ends with #duplicate/{original biblionumber} => Title above toolbar is "Editing duplicate record of #{original biblionumber}" 8) Save SUCCESS => browser url ends with #catalog/{new biblionumber} => Title above toolbar is "Editing catalog record #{new biblionumber}" 9) Sign off Sponsored-by: Carnegie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88401|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88617&action=edit Bug 16232: Fix edit as new in Rancor When you edit a biblio as new, and you have enabled advanced editor, current record was opened, and was overwritten when saved. This patch effectively opens a new record based on the one selected. To test: 1) Enable "EnableAdvancedCatalogingEditor" preference 2) Go to cataloguing and click on advanced editor to save preference to the cookie 3) Search for an item in catalog 4) Click in "Edit as new (duplicate)" 5) Advanced editor should appear. CHECK => browser url ends with #catalog/{original biblionumber} => Title above toolbar is "Editing catalog record #{original biblionumber}" 6) Apply this patch 7) Repeat steps 3 to 5 SUCCESS => browser url ends with #duplicate/{original biblionumber} => Title above toolbar is "Editing duplicate record of #{original biblionumber}" 8) Save SUCCESS => browser url ends with #catalog/{new biblionumber} => Title above toolbar is "Editing catalog record #{new biblionumber}" 9) Sign off Sponsored-by: Carnegie Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88617|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88618&action=edit Bug 16232: Fix edit as new in Rancor When you edit a biblio as new, and you have enabled advanced editor, current record was opened, and was overwritten when saved. This patch effectively opens a new record based on the one selected. To test: 1) Enable "EnableAdvancedCatalogingEditor" preference 2) Go to cataloguing and click on advanced editor to save preference to the cookie 3) Search for an item in catalog 4) Click in "Edit as new (duplicate)" 5) Advanced editor should appear. CHECK => browser url ends with #catalog/{original biblionumber} => Title above toolbar is "Editing catalog record #{original biblionumber}" 6) Apply this patch 7) Repeat steps 3 to 5 SUCCESS => browser url ends with #duplicate/{original biblionumber} => Title above toolbar is "Editing duplicate record of #{original biblionumber}" 8) Save SUCCESS => browser url ends with #catalog/{new biblionumber} => Title above toolbar is "Editing catalog record #{new biblionumber}" 9) Sign off Sponsored-by: Carnegie Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Bug 16232 depends on bug 22748, which changed state. Bug 22748 Summary: Wrong permission check in addbiblio.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22748 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependency for 18.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> --- This give me a new "undefined" value in save target list. What is it supposed to be ? Clicking on it simply save the record in database, like if i just click on "Save to catalog". -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org