[Bug 23198] New: Wrong icons/paths in 18.11 for self check modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Bug ID: 23198 Summary: Wrong icons/paths in 18.11 for self check modules Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- It looks like some icons were updated during SCSS changes, and some paths adjusted, these were not updated for 18.11 selfcheck modules (in/out) To recreate: 1 - Load the SCO modules 2 - Open developer tab in browser (Press F12) 3 - Go to Network tab 4 - Note help.png has a 404 5 - Sign in to SCO as a patron - note stop.png also doesn't load 6 - Test for similar issues in SCI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com, | |lucas@bywatersolutions.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90998&action=edit Bug 23198: Wrong icons/paths in 18.11 for self check modules This patch amends the CSS in self checkout and self check-in modules so that paths to icon images are correct. To test, apply the patch and make sure the WebBasedSelfCheck and SelfCheckInModule preferences are enabled. In self-checkout and self-check-in, confirm that the following icons appear correctly: - "Help" (?) icon in the upper right. - "Finish" (stop sign) icon -- Shown to logged-in self checkout users from the start. Shown to self-check-in users after they check in an item. - "Cancel" (X) icon -- Shown for instance when you try to check out an item which is already checked out to you and can be renewed. - Also in this dialog: "Return" (Book with arrow) and "Renew" (refresh icon). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90998|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 91101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91101&action=edit Bug 23198: Wrong icons/paths in 18.11 for self check modules This patch amends the CSS in self checkout and self check-in modules so that paths to icon images are correct. To test, apply the patch and make sure the WebBasedSelfCheck and SelfCheckInModule preferences are enabled. In self-checkout and self-check-in, confirm that the following icons appear correctly: - "Help" (?) icon in the upper right. - "Finish" (stop sign) icon -- Shown to logged-in self checkout users from the start. Shown to self-check-in users after they check in an item. - "Cancel" (X) icon -- Shown for instance when you try to check out an item which is already checked out to you and can be renewed. - Also in this dialog: "Return" (Book with arrow) and "Renew" (refresh icon). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Wrong icons/paths in 18.11 |[18.11] Wrong icons/paths |for self check modules |in 18.11 for self check | |modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91101|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91169&action=edit Bug 23198: Wrong icons/paths in 18.11 for self check modules This patch amends the CSS in self checkout and self check-in modules so that paths to icon images are correct. To test, apply the patch and make sure the WebBasedSelfCheck and SelfCheckInModule preferences are enabled. In self-checkout and self-check-in, confirm that the following icons appear correctly: - "Help" (?) icon in the upper right. - "Finish" (stop sign) icon -- Shown to logged-in self checkout users from the start. Shown to self-check-in users after they check in an item. - "Cancel" (X) icon -- Shown for instance when you try to check out an item which is already checked out to you and can be renewed. - Also in this dialog: "Return" (Book with arrow) and "Renew" (refresh icon). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- pushed to 18.11.x for 18.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |martin.renvoize@ptfs-europe | |.com Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23198 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |18.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org