[Bug 34355] New: Automated Marc record ordering process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Bug ID: 34355 Summary: Automated Marc record ordering process Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org This is a bug to create a process for automatically creating order lines from a MARC record. Users can nominate a directory for a particular vendor and then set a cronjob to periodically check that directory for new files. The cronjob will then stage the file, import biblios/items as required and then create order lines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/PTFS-Eur | |ope/koha/commits/bws_marc_o | |rdering -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault@biblibre.com --- Comment #1 from Laurence Rault <laurence.rault@biblibre.com> --- Koha has already EDI functionnality, that can do what you describe. See https://koha-community.org/manual/23.05/en/html/acquisitions.html#edi-proces... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com --- Comment #2 from Jessie Zairo <jzairo@bywatersolutions.com> --- This enhancement would be for non-edi vendors and libraries who receive marc files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automated Marc record |Automated MARC record |ordering process |ordering process -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 154705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154705&action=edit Bug 34355: DB schema and atomic update file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 154706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154706&action=edit Bug 34355: Update menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 154707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154707&action=edit Bug 34355: Add account creation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 154708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154708&action=edit Bug 34355: Add cronjob, MarcOrder object and refactored addorderiso2709 script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 154709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154709&action=edit Bug 34355: Make item addition dependent on MarcItemFieldsToOrder mappings and introduce MarcFieldsToOrder to cronjob -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 154710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154710&action=edit Bug 34355: Fix form rendering issue This patch also fixes the referencing of import_record_id_selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://github.com/PTFS-Eur | |ope/koha/commits/bws_marc_o | |rdering | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like we will need a nice and concise test plan here as there already was some confusion about the functionality! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- There is a nice, detailed (ish) test plan that I've written but I'm trying to write unit tests before submitting everything and marking as needing signoff. I'm also weighing up Nick's point from Kohacon about splitting this into multiple bugs as there's some refactoring of the addorderiso2709.pl script at the heart of the enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Matt Blenkinsop from comment #10)
There is a nice, detailed (ish) test plan that I've written but I'm trying to write unit tests before submitting everything and marking as needing signoff.
I'm also weighing up Nick's point from Kohacon about splitting this into multiple bugs as there's some refactoring of the addorderiso2709.pl script at the heart of the enhancement
+1 :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35026 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 [Bug 35026] Refactor addorderiso2709.pl to use object methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154705|0 |1 is obsolete| | --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 157092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157092&action=edit Bug 34355: DB schema and atomic update file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154706|0 |1 is obsolete| | --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 157093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157093&action=edit Bug 34355: Update menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154707|0 |1 is obsolete| | --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 157094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157094&action=edit Bug 34355: Add account creation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154708|0 |1 is obsolete| | --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 157095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157095&action=edit Bug 34355: Add cronjob, MarcOrder object and refactored addorderiso2709 script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154709|0 |1 is obsolete| | --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 157096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157096&action=edit Bug 34355: Make item addition dependent on MarcItemFieldsToOrder mappings and introduce MarcFieldsToOrder to cronjob -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154710|0 |1 is obsolete| | --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 157097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157097&action=edit Bug 34355: Fix form rendering issue This patch also fixes the referencing of import_record_id_selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 157098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157098&action=edit Bug 34355: Add match_field and match_value to allow multiple accounts in the same file directory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 157099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157099&action=edit Bug 34355: Add a plugin hook - before_orderline_create -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #20 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 157100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157100&action=edit Bug 34355: Rebase changes made in bug 33170 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35026 |33170 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33170 [Bug 33170] Refactor MarcItemFieldsToOrder code to make adding more fields simpler https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 [Bug 35026] Refactor addorderiso2709.pl to use object methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35026 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 [Bug 35026] Refactor addorderiso2709.pl to use object methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Bug 34355 depends on bug 33170, which changed state. Bug 33170 Summary: Refactor MarcItemFieldsToOrder code to make adding more fields simpler https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33170 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We need a test plan please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #21)
We need a test plan please.
... and in general please more commit messages ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157092|0 |1 is obsolete| | --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160858&action=edit Bug 34355: DB schema and atomic update file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157093|0 |1 is obsolete| | --- Comment #24 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160859&action=edit Bug 34355: Update menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157094|0 |1 is obsolete| | --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160860&action=edit Bug 34355: Add account creation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157095|0 |1 is obsolete| | --- Comment #26 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160861&action=edit Bug 34355: Add cronjob, MarcOrder object and refactored addorderiso2709 script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157096|0 |1 is obsolete| | --- Comment #27 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160862&action=edit Bug 34355: Make item addition dependent on MarcItemFieldsToOrder mappings and introduce MarcFieldsToOrder to cronjob -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157097|0 |1 is obsolete| | --- Comment #28 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160863&action=edit Bug 34355: Fix form rendering issue This patch also fixes the referencing of import_record_id_selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157098|0 |1 is obsolete| | --- Comment #29 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160864&action=edit Bug 34355: Add match_field and match_value to allow multiple accounts in the same file directory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157099|0 |1 is obsolete| | --- Comment #30 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160865&action=edit Bug 34355: Add a plugin hook - before_orderline_create -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157100|0 |1 is obsolete| | --- Comment #31 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160866&action=edit Bug 34355: Rebase changes made in bug 33170 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160858|0 |1 is obsolete| | --- Comment #32 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160867&action=edit Bug 34355: DB schema and atomic update file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160859|0 |1 is obsolete| | --- Comment #33 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160868&action=edit Bug 34355: Update menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160860|0 |1 is obsolete| | --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160869&action=edit Bug 34355: Add account creation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160861|0 |1 is obsolete| | --- Comment #35 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160870&action=edit Bug 34355: Add cronjob, MarcOrder object and refactored addorderiso2709 script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160862|0 |1 is obsolete| | --- Comment #36 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160871&action=edit Bug 34355: Make item addition dependent on MarcItemFieldsToOrder mappings and introduce MarcFieldsToOrder to cronjob -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160863|0 |1 is obsolete| | --- Comment #37 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160872&action=edit Bug 34355: Fix form rendering issue This patch also fixes the referencing of import_record_id_selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160864|0 |1 is obsolete| | --- Comment #38 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160873&action=edit Bug 34355: Add match_field and match_value to allow multiple accounts in the same file directory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160865|0 |1 is obsolete| | --- Comment #39 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160874&action=edit Bug 34355: Add a plugin hook - before_orderline_create -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160866|0 |1 is obsolete| | --- Comment #40 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 160875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160875&action=edit Bug 34355: Rebase changes made in bug 33170 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #41 from Jessie Zairo <jzairo@bywatersolutions.com> --- Test Plan 1) Create an sFTP server (1 set up for each unique vendor) and share the credentials with the vendor who will be sending the test data 2)apply patch 3) navigate to Administration -> Acquisition parameters -> MARC order accounts 4) click New Account 5)Enter the following details a) Vendor: b) Budget:This budget will be used as the fallback value if the MARC records do not contain a mapped value for a budget code. c)Description: d)Download directory:The download directory specifies the directory in your koha installation that should be searched for new files. e)Match field:(Optional): If you have files from multiple vendors in the same file directory, the match field is the field in the marc record that will be checked to see if the file should be processed by this account. f)Match value: (Optional): This is the value that will be checked against the match field to see if the file matches this account. If it does it will be processed by this account, if not it will be skipped. 6) enter File import settings 7) enter Record matching settings 8) select if it should check for embedded item record data 9) click submit 10) drop test file in sFTP server (run manually or have a cron run to pick up the file) 11) file should load in basket for said vendor and create orders. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is the setup of the mentioned SFTP server something done in Koha or something done outside? Are you expected to set it up on the Koha server itself? Maybe this works similar like picking up files for EDI? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #43 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169896&action=edit Bug 34355: DB schemas and atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160868|0 |1 is obsolete| | --- Comment #44 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169897&action=edit Bug 34355: Update menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160869|0 |1 is obsolete| | --- Comment #45 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169898&action=edit Bug 34355: Add account creation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #46 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169899&action=edit Bug 34355: Add cronjob and required methods This patch adds a cronjob to take a marc file from the Koha file directory system and import it before creating order lines Test plan: This test plan involves running a cronjob, not sure how easy this is in the sandboxes 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Enable MarcOrderingAutomation 3) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 4) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Now save the sysprefs 5) In the administration homepage, under Acquisition parameters there should now be a link called "MARC order accounts" 6) Click on this and click the New account button 7) Choose a vendor and a budget 8) Enter a description 9) Enter the following in download directory - "/var/lib/koha/kohadev/tmp/koha_kohadev_upload" 10) Select any record matching settings you want (not important for the test plan, this uses the same code as the marc file staging that already exists in Koha) 11) Check Yes under Check for embedded item record data 12) Click submit 13) We now need to upload a MARC file into the directory that we put in the account. The easiest way to do this is through the marc staging tool 14) Navigate to Cataloging > Stage MARC records for import 15) Upload the file attached to this bug using the Choose file button 16) Click Upload file. 17) Leave the page without completing the new form that appears, we don't want to stage this file. The file we uploaded is now in the directory ready for the cronjob to process as if it had been transferred via SFTP. 18) In the CLI run, perl misc/cronjobs/marc_ordering_process.pl -v -c 19) The logging should show that the file has been processed for that account 20) Navigate to Acquisitions 21) Search for the Vendor that you put in the MARC ordering account 22) There should be a basket created on the vendor with the name of the file you uploaded (there will also be a reference at the start e.g. ea2323966faef2c59a6056dbd1f7d658_filename.marcxml. This is because we used the marc staging tool to upload the file and that adds a reference to filenames. This will not appear when using files from an SFTP location). 23) Click in the basket 24) There should be three orderlines, complete with accounting details that have been mapped from the file. One line should have a fund of Fund 1_2, quantity of 4 and a replacement price of 6.75, one should have Secondary fund, 2, 6.40 and one should have Main fund,2, 6.30 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160871|0 |1 is obsolete| | --- Comment #47 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169900&action=edit Bug 34355: Make item addition dependent on MarcItemFieldsToOrder mappings and introduce MarcFieldsToOrder to cronjob -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160872|0 |1 is obsolete| | --- Comment #48 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169901&action=edit Bug 34355: Fix form rendering issue This patch also fixes the referencing of import_record_id_selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160873|0 |1 is obsolete| | --- Comment #49 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169902&action=edit Bug 34355: Add match_field and match_value to allow multiple accounts in the same file directory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160874|0 |1 is obsolete| | --- Comment #50 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169903&action=edit Bug 34355: Add a plugin hook - before_orderline_create -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #51 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169904&action=edit Bug 34355: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #52 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Background: This bug is intended for non-EDI vendors who wish to receive MARC files and automatically create order lines from these using the mappings in MarcFieldsToOrder and MarcItemFieldsToOrder. A vendor can supply MARC files to an SFTP location in the Koha installation and a cronjob can pick up those files and process them into order lines in a new basket for each file. A file has been attached to test with, but you can use your own files. You just need to ensure that there is a mapping in the file consistent with what you put into the system preferences as per the test plan below. Test plan: This test plan involves running a cronjob, not sure how easy this is in the sandboxes 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Enable MarcOrderingAutomation 3) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 4) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Now save the sysprefs 5) In the administration homepage, under Acquisition parameters there should now be a link called "MARC order accounts" 6) Click on this and click the New account button 7) Choose a vendor and a budget 8) Enter a description 9) Enter the following in download directory - "/var/lib/koha/kohadev/tmp/koha_kohadev_upload" 10) Select any record matching settings you want (not important for the test plan, this uses the same code as the marc file staging that already exists in Koha) 11) Check Yes under Check for embedded item record data 12) Click submit 13) We now need to upload a MARC file into the directory that we put in the account. The easiest way to do this is through the marc staging tool 14) Navigate to Cataloging > Stage MARC records for import 15) Upload the file attached to this bug using the Choose file button 16) Click Upload file. 17) Leave the page without completing the new form that appears, we don't want to stage this file. The file we uploaded is now in the directory ready for the cronjob to process as if it had been transferred via SFTP. 18) In the CLI run, perl misc/cronjobs/marc_ordering_process.pl -v -c 19) The logging should show that the file has been processed for that account 20) Navigate to Acquisitions 21) Search for the Vendor that you put in the MARC ordering account 22) There should be a basket created on the vendor with the name of the file you uploaded (there will also be a reference at the start e.g. ea2323966faef2c59a6056dbd1f7d658_filename.marcxml. This is because we used the marc staging tool to upload the file and that adds a reference to filenames. This will not appear when using files from an SFTP location). 23) Click in the basket 24) There should be three orderlines, complete with accounting details that have been mapped from the file. One line should have a fund of Fund 1_2, quantity of 4 and a replacement price of 6.75, one should have Secondary fund, 2, 6.40 and one should have Main fund,2, 6.30 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160867|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160870|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160875|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #53 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 170395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170395&action=edit Test file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169896|0 |1 is obsolete| | --- Comment #54 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 170401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170401&action=edit Bug 34355: DB schemas and atomicupdate Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169897|0 |1 is obsolete| | --- Comment #55 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 170402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170402&action=edit Bug 34355: Update menus Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169898|0 |1 is obsolete| | --- Comment #56 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 170403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170403&action=edit Bug 34355: Add account creation Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169899|0 |1 is obsolete| | --- Comment #57 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 170404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170404&action=edit Bug 34355: Add cronjob and required methods This patch adds a cronjob to take a marc file from the Koha file directory system and import it before creating order lines Test plan: This test plan involves running a cronjob, not sure how easy this is in the sandboxes 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Enable MarcOrderingAutomation 3) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 4) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Now save the sysprefs 5) In the administration homepage, under Acquisition parameters there should now be a link called "MARC order accounts" 6) Click on this and click the New account button 7) Choose a vendor and a budget 8) Enter a description 9) Enter the following in download directory - "/var/lib/koha/kohadev/tmp/koha_kohadev_upload" 10) Select any record matching settings you want (not important for the test plan, this uses the same code as the marc file staging that already exists in Koha) 11) Check Yes under Check for embedded item record data 12) Click submit 13) We now need to upload a MARC file into the directory that we put in the account. The easiest way to do this is through the marc staging tool 14) Navigate to Cataloging > Stage MARC records for import 15) Upload the file attached to this bug using the Choose file button 16) Click Upload file. 17) Leave the page without completing the new form that appears, we don't want to stage this file. The file we uploaded is now in the directory ready for the cronjob to process as if it had been transferred via SFTP. 18) In the CLI run, perl misc/cronjobs/marc_ordering_process.pl -v -c 19) The logging should show that the file has been processed for that account 20) Navigate to Acquisitions 21) Search for the Vendor that you put in the MARC ordering account 22) There should be a basket created on the vendor with the name of the file you uploaded (there will also be a reference at the start e.g. ea2323966faef2c59a6056dbd1f7d658_filename.marcxml. This is because we used the marc staging tool to upload the file and that adds a reference to filenames. This will not appear when using files from an SFTP location). 23) Click in the basket 24) There should be three orderlines, complete with accounting details that have been mapped from the file. One line should have a fund of Fund 1_2, quantity of 4 and a replacement price of 6.75, one should have Secondary fund, 2, 6.40 and one should have Main fund,2, 6.30 Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169900|0 |1 is obsolete| | --- Comment #58 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 170405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170405&action=edit Bug 34355: Make item addition dependent on MarcItemFieldsToOrder mappings and introduce MarcFieldsToOrder to cronjob Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169901|0 |1 is obsolete| | --- Comment #59 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 170406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170406&action=edit Bug 34355: Fix form rendering issue This patch also fixes the referencing of import_record_id_selected Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169902|0 |1 is obsolete| | --- Comment #60 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 170407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170407&action=edit Bug 34355: Add match_field and match_value to allow multiple accounts in the same file directory Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169903|0 |1 is obsolete| | --- Comment #61 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 170408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170408&action=edit Bug 34355: Add a plugin hook - before_orderline_create Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169904|0 |1 is obsolete| | --- Comment #62 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 170409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170409&action=edit Bug 34355: Add unit tests Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Bug 34355 depends on bug 35026, which changed state. Bug 35026 Summary: Refactor addorderiso2709.pl to use object methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #63 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Doubled pref in patches: pref: SerialsDefaultReplyTo looks like rebase issues A user can CRUD Marc Order Accounts with only catalogue permissions - I think it needs to be a new subpermission of acquisitions A full search of vendors is used on the marc order accounts page - this should be a select2 and not load all into template (we have partners with thousands of vendors) create_items is not set for basket - I think 'ordering' is required? maybe this setting is just ignored for this process? you mention _stage_file is a clone from the background job. it should be moved into a place that can be shared with the background job to dry the code match_file_to_account - POD should indicate only the first record is checked on the account page it should specify the format, dollar sign for subfields, i.e. 245$a Commit titles below don't match the patches, can you explain? Bug 34355: Make item addition dependent on MarcItemFieldsToOrder mappings and introduce MarcFieldsToOrder to cronjob Bug 34355: Add a plugin hook - before_orderline_create koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_order_accounts.tt The selected option choices are split by the conditionals, include the full option selected or not You remove the use of tools-overlay-action.inc / tools-nomatch-action / tools-item-action - I think we should keep this to not repeat - the selection variables lok unsused so can be updated to work with the data here (e.g. git grep overlay_action_replace ) Warning when processing test file: Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 5. Maybe a data problem with the file? The cronjob deletes the file - I think we want an option to rename/move the file, rather than full deletion - if something is wrong, we want the file for reference It looks like a few fields were not included in _create_item_fields_from_syspref: coded_location_qualifier, barcode, and enumchron - special field quantity -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170401|0 |1 is obsolete| | --- Comment #64 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173054&action=edit Bug 34355: DB schemas and atomicupdate Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170402|0 |1 is obsolete| | --- Comment #65 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173055&action=edit Bug 34355: Update menus Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170403|0 |1 is obsolete| | --- Comment #66 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173056&action=edit Bug 34355: Add account creation Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170404|0 |1 is obsolete| | --- Comment #67 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173057&action=edit Bug 34355: Add cronjob and required methods This patch adds a cronjob to take a marc file from the Koha file directory system and import it before creating order lines Test plan: This test plan involves running a cronjob, not sure how easy this is in the sandboxes 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Enable MarcOrderingAutomation 3) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 4) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Now save the sysprefs 5) In the administration homepage, under Acquisition parameters there should now be a link called "MARC order accounts" 6) Click on this and click the New account button 7) Choose a vendor and a budget 8) Enter a description 9) Enter the following in download directory - "/var/lib/koha/kohadev/tmp/koha_kohadev_upload" 10) Select any record matching settings you want (not important for the test plan, this uses the same code as the marc file staging that already exists in Koha) 11) Check Yes under Check for embedded item record data 12) Click submit 13) We now need to upload a MARC file into the directory that we put in the account. The easiest way to do this is through the marc staging tool 14) Navigate to Cataloging > Stage MARC records for import 15) Upload the file attached to this bug using the Choose file button 16) Click Upload file. 17) Leave the page without completing the new form that appears, we don't want to stage this file. The file we uploaded is now in the directory ready for the cronjob to process as if it had been transferred via SFTP. 18) In the CLI run, perl misc/cronjobs/marc_ordering_process.pl -v -c 19) The logging should show that the file has been processed for that account 20) Navigate to Acquisitions 21) Search for the Vendor that you put in the MARC ordering account 22) There should be a basket created on the vendor with the name of the file you uploaded (there will also be a reference at the start e.g. ea2323966faef2c59a6056dbd1f7d658_filename.marcxml. This is because we used the marc staging tool to upload the file and that adds a reference to filenames. This will not appear when using files from an SFTP location). 23) Click in the basket 24) There should be three orderlines, complete with accounting details that have been mapped from the file. One line should have a fund of Fund 1_2, quantity of 4 and a replacement price of 6.75, one should have Secondary fund, 2, 6.40 and one should have Main fund,2, 6.30 Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170406|0 |1 is obsolete| | --- Comment #68 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173058&action=edit Bug 34355: Fix form rendering issue This patch also fixes the referencing of import_record_id_selected Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170407|0 |1 is obsolete| | --- Comment #69 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173059&action=edit Bug 34355: Add match_field and match_value to allow multiple accounts in the same file directory Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170408|0 |1 is obsolete| | --- Comment #70 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173060&action=edit Bug 34355: Add a plugin hook - before_orderline_create Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170409|0 |1 is obsolete| | --- Comment #71 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173061&action=edit Bug 34355: Add unit tests Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #72 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173062&action=edit Bug 34355: (QA follow-up) Add permission marc_order_manage to govern control of account creation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #73 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173063&action=edit Bug 34355: (QA follow-up) Migrate vendor dropdown to a kohaSelect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #74 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173064&action=edit Bug 34355: (QA follow-up) Add a delete flag to the cronjob This patch adds a 'delete' flag to the cronjob to select whether a file should be deleted or archived once processed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #75 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173065&action=edit Bug 34355: (QA follow-up) Fix template errors This patch addresses the following issues: - Fixes a duplication of the SerialsDefaultReplyTo syspref - Re-introduces include files for overlay rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #76 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173066&action=edit Bug 34355: (QA follow-up) Make record staging code DRY -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170405|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #77 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- (In reply to Nick Clemens (kidclamp) from comment #63)
Doubled pref in patches: pref: SerialsDefaultReplyTo looks like rebase issues
Corrected
A user can CRUD Marc Order Accounts with only catalogue permissions - I think it needs to be a new subpermission of acquisitions
Added a new permission marc_order_manage
A full search of vendors is used on the marc order accounts page - this should be a select2 and not load all into template (we have partners with thousands of vendors)
Migrated to kohaSelect
create_items is not set for basket - I think 'ordering' is required? maybe this setting is just ignored for this process?
I think we should set it - I've amended it to be set
you mention _stage_file is a clone from the background job. it should be moved into a place that can be shared with the background job to dry the code
Done - moved to Koha::ImportBatch
match_file_to_account - POD should indicate only the first record is checked on the account page it should specify the format, dollar sign for subfields, i.e. 245$a
Done
Commit titles below don't match the patches, can you explain? Bug 34355: Make item addition dependent on MarcItemFieldsToOrder mappings and introduce MarcFieldsToOrder to cronjob Bug 34355: Add a plugin hook - before_orderline_create
I think this is the result of rebases - the plugin hook had been lost and is now restored. The other commit I have squashed as it is no longer necessary as a separate commit as the history has been broken by other squashes/rebases
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_order_accounts.tt The selected option choices are split by the conditionals, include the full option selected or not You remove the use of tools-overlay-action.inc / tools-nomatch-action / tools-item-action - I think we should keep this to not repeat - the selection variables lok unsused so can be updated to work with the data here (e.g. git grep overlay_action_replace )
Amended the templates to reflect this
Warning when processing test file: Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 5. Maybe a data problem with the file?
This comes from the MARC library we import from CPAN and happens with the file when running a normal staged import
The cronjob deletes the file - I think we want an option to rename/move the file, rather than full deletion - if something is wrong, we want the file for reference
I've added a delete flag - if this isn't set the cronjob now moves processed files to an 'archived' folder
It looks like a few fields were not included in _create_item_fields_from_syspref: coded_location_qualifier, barcode, and enumchron - special field quantity
Updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #78 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173709&action=edit Bug 34355: (QA follow-up) Permissions fixes This patch addresses some permissions errors and updates the breadcrumbs to reflect this -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #79 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173805&action=edit Bug 34355: (QA follow-up) Restore MarcFieldsToOrder prices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173805|0 |1 is obsolete| | --- Comment #80 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173806&action=edit Bug 34355: (QA follow-up) Restore MarcFieldsToOrder prices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173806|0 |1 is obsolete| | --- Comment #81 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173809&action=edit Bug 34355: (QA follow-up) Restore MarcFieldsToOrder prices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173809|0 |1 is obsolete| | --- Comment #82 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173824&action=edit Bug 34355: (QA follow-up) Restore MarcFieldsToOrder prices and budgets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #83 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173825&action=edit Bug 34355: (QA follow-up) Respect AcqCreateItem syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173054|0 |1 is obsolete| | Attachment #173055|0 |1 is obsolete| | Attachment #173056|0 |1 is obsolete| | Attachment #173057|0 |1 is obsolete| | Attachment #173058|0 |1 is obsolete| | Attachment #173059|0 |1 is obsolete| | Attachment #173060|0 |1 is obsolete| | Attachment #173061|0 |1 is obsolete| | Attachment #173062|0 |1 is obsolete| | Attachment #173063|0 |1 is obsolete| | Attachment #173064|0 |1 is obsolete| | Attachment #173065|0 |1 is obsolete| | Attachment #173066|0 |1 is obsolete| | Attachment #173709|0 |1 is obsolete| | Attachment #173824|0 |1 is obsolete| | Attachment #173825|0 |1 is obsolete| | --- Comment #84 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173993&action=edit Bug 34355: DB schemas and atomicupdate Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #85 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173994&action=edit Bug 34355: Update menus Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #86 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173995&action=edit Bug 34355: Add account creation Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #87 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173996&action=edit Bug 34355: Add cronjob and required methods This patch adds a cronjob to take a marc file from the Koha file directory system and import it before creating order lines Test plan: This test plan involves running a cronjob, not sure how easy this is in the sandboxes 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Enable MarcOrderingAutomation 3) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 4) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Now save the sysprefs 5) In the administration homepage, under Acquisition parameters there should now be a link called "MARC order accounts" 6) Click on this and click the New account button 7) Choose a vendor and a budget 8) Enter a description 9) Enter the following in download directory - "/var/lib/koha/kohadev/tmp/koha_kohadev_upload" 10) Select any record matching settings you want (not important for the test plan, this uses the same code as the marc file staging that already exists in Koha) 11) Check Yes under Check for embedded item record data 12) Click submit 13) We now need to upload a MARC file into the directory that we put in the account. The easiest way to do this is through the marc staging tool 14) Navigate to Cataloging > Stage MARC records for import 15) Upload the file attached to this bug using the Choose file button 16) Click Upload file. 17) Leave the page without completing the new form that appears, we don't want to stage this file. The file we uploaded is now in the directory ready for the cronjob to process as if it had been transferred via SFTP. 18) In the CLI run, perl misc/cronjobs/marc_ordering_process.pl -v -c 19) The logging should show that the file has been processed for that account 20) Navigate to Acquisitions 21) Search for the Vendor that you put in the MARC ordering account 22) There should be a basket created on the vendor with the name of the file you uploaded (there will also be a reference at the start e.g. ea2323966faef2c59a6056dbd1f7d658_filename.marcxml. This is because we used the marc staging tool to upload the file and that adds a reference to filenames. This will not appear when using files from an SFTP location). 23) Click in the basket 24) There should be three orderlines, complete with accounting details that have been mapped from the file. One line should have a fund of Fund 1_2, quantity of 4 and a replacement price of 6.75, one should have Secondary fund, 2, 6.40 and one should have Main fund,2, 6.30 Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #88 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173997&action=edit Bug 34355: Fix form rendering issue This patch also fixes the referencing of import_record_id_selected Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #89 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173998&action=edit Bug 34355: Add match_field and match_value to allow multiple accounts in the same file directory Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #90 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173999&action=edit Bug 34355: Add a plugin hook - before_orderline_create Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #91 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174000&action=edit Bug 34355: Add unit tests Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #92 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174001&action=edit Bug 34355: (QA follow-up) Add permission marc_order_manage to govern control of account creation Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #93 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174002&action=edit Bug 34355: (QA follow-up) Migrate vendor dropdown to a kohaSelect Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #94 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174003&action=edit Bug 34355: (QA follow-up) Add a delete flag to the cronjob This patch adds a 'delete' flag to the cronjob to select whether a file should be deleted or archived once processed Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #95 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174004&action=edit Bug 34355: (QA follow-up) Fix template errors This patch addresses the following issues: - Fixes a duplication of the SerialsDefaultReplyTo syspref - Re-introduces include files for overlay rules Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #96 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174005&action=edit Bug 34355: (QA follow-up) Make record staging code DRY Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #97 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174006&action=edit Bug 34355: (QA follow-up) Permissions fixes This patch addresses some permissions errors and updates the breadcrumbs to reflect this Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #98 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174007&action=edit Bug 34355: (QA follow-up) Restore MarcFieldsToOrder prices and budgets Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #99 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174008&action=edit Bug 34355: (QA follow-up) Respect AcqCreateItem syspref Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #100 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174009&action=edit Bug 34355: (QA follow-up) Remove debugging comment from archiving command Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #101 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174010&action=edit Bug 34355: (QA follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #102 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I think we can do more in the future to improve readability, but this one moves more ordering code into modules to make it easier for testing and gets my vote. I tested all combinations I could think of, and orders are generated correctly from Marc. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #103 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't combine database update and schema update. We have a conflict now in the first patch: Bug 34355: DB schemas and atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #104 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am trying to remove the schema files from the patches, so they apply... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173993|0 |1 is obsolete| | --- Comment #105 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174362&action=edit Bug 34355: DB schemas and atomicupdate Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #106 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174363&action=edit Bug 34355: DBIC files Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173994|0 |1 is obsolete| | --- Comment #107 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174364&action=edit Bug 34355: Update menus Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173995|0 |1 is obsolete| | --- Comment #108 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174365&action=edit Bug 34355: Add account creation Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173996|0 |1 is obsolete| | --- Comment #109 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174366&action=edit Bug 34355: Add cronjob and required methods This patch adds a cronjob to take a marc file from the Koha file directory system and import it before creating order lines Test plan: This test plan involves running a cronjob, not sure how easy this is in the sandboxes 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Enable MarcOrderingAutomation 3) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 4) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Now save the sysprefs 5) In the administration homepage, under Acquisition parameters there should now be a link called "MARC order accounts" 6) Click on this and click the New account button 7) Choose a vendor and a budget 8) Enter a description 9) Enter the following in download directory - "/var/lib/koha/kohadev/tmp/koha_kohadev_upload" 10) Select any record matching settings you want (not important for the test plan, this uses the same code as the marc file staging that already exists in Koha) 11) Check Yes under Check for embedded item record data 12) Click submit 13) We now need to upload a MARC file into the directory that we put in the account. The easiest way to do this is through the marc staging tool 14) Navigate to Cataloging > Stage MARC records for import 15) Upload the file attached to this bug using the Choose file button 16) Click Upload file. 17) Leave the page without completing the new form that appears, we don't want to stage this file. The file we uploaded is now in the directory ready for the cronjob to process as if it had been transferred via SFTP. 18) In the CLI run, perl misc/cronjobs/marc_ordering_process.pl -v -c 19) The logging should show that the file has been processed for that account 20) Navigate to Acquisitions 21) Search for the Vendor that you put in the MARC ordering account 22) There should be a basket created on the vendor with the name of the file you uploaded (there will also be a reference at the start e.g. ea2323966faef2c59a6056dbd1f7d658_filename.marcxml. This is because we used the marc staging tool to upload the file and that adds a reference to filenames. This will not appear when using files from an SFTP location). 23) Click in the basket 24) There should be three orderlines, complete with accounting details that have been mapped from the file. One line should have a fund of Fund 1_2, quantity of 4 and a replacement price of 6.75, one should have Secondary fund, 2, 6.40 and one should have Main fund,2, 6.30 Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173997|0 |1 is obsolete| | --- Comment #110 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174367&action=edit Bug 34355: Fix form rendering issue This patch also fixes the referencing of import_record_id_selected Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173998|0 |1 is obsolete| | --- Comment #111 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174368&action=edit Bug 34355: Add match_field and match_value to allow multiple accounts in the same file directory Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173999|0 |1 is obsolete| | --- Comment #112 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174369&action=edit Bug 34355: Add a plugin hook - before_orderline_create Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174000|0 |1 is obsolete| | --- Comment #113 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174370&action=edit Bug 34355: Add unit tests Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174001|0 |1 is obsolete| | --- Comment #114 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174371&action=edit Bug 34355: (QA follow-up) Add permission marc_order_manage to govern control of account creation Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174002|0 |1 is obsolete| | --- Comment #115 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174372&action=edit Bug 34355: (QA follow-up) Migrate vendor dropdown to a kohaSelect Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174003|0 |1 is obsolete| | --- Comment #116 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174373&action=edit Bug 34355: (QA follow-up) Add a delete flag to the cronjob This patch adds a 'delete' flag to the cronjob to select whether a file should be deleted or archived once processed Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174004|0 |1 is obsolete| | --- Comment #117 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174374&action=edit Bug 34355: (QA follow-up) Fix template errors This patch addresses the following issues: - Fixes a duplication of the SerialsDefaultReplyTo syspref - Re-introduces include files for overlay rules Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174005|0 |1 is obsolete| | --- Comment #118 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174375&action=edit Bug 34355: (QA follow-up) Make record staging code DRY Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174006|0 |1 is obsolete| | --- Comment #119 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174376&action=edit Bug 34355: (QA follow-up) Permissions fixes This patch addresses some permissions errors and updates the breadcrumbs to reflect this Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174007|0 |1 is obsolete| | --- Comment #120 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174377&action=edit Bug 34355: (QA follow-up) Restore MarcFieldsToOrder prices and budgets Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174008|0 |1 is obsolete| | --- Comment #121 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174378&action=edit Bug 34355: (QA follow-up) Respect AcqCreateItem syspref Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174009|0 |1 is obsolete| | --- Comment #122 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174379&action=edit Bug 34355: (QA follow-up) Remove debugging comment from archiving command Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174010|0 |1 is obsolete| | --- Comment #123 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174380&action=edit Bug 34355: (QA follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #124 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Rebased, although the conflict must be coming from something you've applied locally and not yet pushed as it applies cleanly for me - if there is still conflict then let me know when you've pushed all your local patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #125 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 174382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174382&action=edit Bug 34355: DBIC schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #126 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 174383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174383&action=edit Bug 34355: (QA follow-up) Terminology and capitalization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #127 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate |release-notes-needed --- Comment #128 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Might need some follow-ups for style (Bootstrap 5). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |A parallel to EDI Ordering release notes| |for MARC-file based | |ordering systems. | | | |**Sponsored by** *ByWater | |Solutions* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #129 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should we treat this as "new feature"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #130 from Jonathan Druart <jonathan.druart@gmail.com> --- There are so many things to say here, but I don't have time right now for a full QA review... Just let say the main points that shall have been raised by QA: 1. Missing tests! 2. Useless lines + my @messages; +use Net::FTP; 3. Plugin hook added without being advertised (wiki, kitchenzink?) + 'before_orderline_create', 4. Code for acq not in Koha::Acquisition? 5. controller poorly written and not following standard admin/marc_order_accounts.pl * useless use statements * 51 my $crypt = Koha::Encryption->new; wtf? * values for '$op' not following "standard" * no error handling, no user messages/alerts Everybody wants their stuffs pushed, but we really need more eyes and spend more time on QA IMO. I have been fighting for years to clean the code, but what's the point if we don't enforce the quality and prevent new legacy code to be pushed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|A parallel to EDI Ordering |Adds a parallel process to release notes|for MARC-file based |EDI ordering for MARC-file |ordering systems. |based ordering systems. | | |**Sponsored by** *ByWater |**Sponsored by** *ByWater |Solutions* |Solutions* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #131 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am currently validating that an updated database will have the same structure as a new installation. There is some difference caused by these patches: @@ -4503,6 +4544,8 @@ CREATE TABLE `marc_order_accounts` ( `match_field` varchar(10) DEFAULT NULL COMMENT 'the field that a vendor account has been mapped to in a marc record', `match_value` varchar(50) DEFAULT NULL COMMENT 'the value to be matched against the marc record', PRIMARY KEY (`id`), + KEY `marc_ordering_account_ibfk_1` (`vendor_id`), + KEY `marc_ordering_account_ibfk_2` (`budget_id`), CONSTRAINT `marc_ordering_account_ibfk_1` FOREIGN KEY (`vendor_id`) REFERENCES `aqbooksellers` (`id`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `marc_ordering_account_ibfk_2` FOREIGN KEY (`budget_id`) REFERENCES `aqbudgets` (`budget_id`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; @@ -4831,6 +4874,25 @@ CREATE TABLE `need_merge_authorities` ( ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */; I am not sure about these keys here, please verify. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #132 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #131)
I am currently validating that an updated database will have the same structure as a new installation. There is some difference caused by these patches:
@@ -4503,6 +4544,8 @@ CREATE TABLE `marc_order_accounts` ( `match_field` varchar(10) DEFAULT NULL COMMENT 'the field that a vendor account has been mapped to in a marc record', `match_value` varchar(50) DEFAULT NULL COMMENT 'the value to be matched against the marc record', PRIMARY KEY (`id`), + KEY `marc_ordering_account_ibfk_1` (`vendor_id`), + KEY `marc_ordering_account_ibfk_2` (`budget_id`), CONSTRAINT `marc_ordering_account_ibfk_1` FOREIGN KEY (`vendor_id`) REFERENCES `aqbooksellers` (`id`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `marc_ordering_account_ibfk_2` FOREIGN KEY (`budget_id`) REFERENCES `aqbudgets` (`budget_id`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; @@ -4831,6 +4874,25 @@ CREATE TABLE `need_merge_authorities` ( ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */;
I am not sure about these keys here, please verify.
We came to the conflusion that this difference is harmless due to how the dump works vs the database update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 --- Comment #133 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #130)
There are so many things to say here, but I don't have time right now for a full QA review...
Just let say the main points that shall have been raised by QA:
1. Missing tests!
2. Useless lines
+ my @messages;
+use Net::FTP;
3. Plugin hook added without being advertised (wiki, kitchenzink?)
+ 'before_orderline_create',
4. Code for acq not in Koha::Acquisition?
5. controller poorly written and not following standard admin/marc_order_accounts.pl * useless use statements * 51 my $crypt = Koha::Encryption->new; wtf? * values for '$op' not following "standard" * no error handling, no user messages/alerts
Everybody wants their stuffs pushed, but we really need more eyes and spend more time on QA IMO.
I have been fighting for years to clean the code, but what's the point if we don't enforce the quality and prevent new legacy code to be pushed?
Looking at these, will add a follow-up bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38547 [Bug 38547] Improve the code for the MARC ordering process -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38726 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38726 [Bug 38726] marc vs. MARC in admin-home.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39282 [Bug 39282] When adding an order from file, if the file does not include item data, the item data entered into the "Item information" tab is not saved and invalid items are created -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39518 [Bug 39518] Add the option to define the basket name in a MARC file when adding to a basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39530 [Bug 39530] The MARC ordering cronjob needs to respect the AcqCreateItems syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Irene <i.tortorella@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.tortorella@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk --- Comment #134 from Ray Delahunty <r.delahunty@arts.ac.uk> --- Point 13 in comment 109 suggests that in testing, files can be uploaded using the marc staging tool for the marc_ordering_process.pl script to process. And in the Marc Order accounts the Match field and Match value fields are described as optional. These combine to create a risk. The marc staging tool will upload to /var/lib/koha/###/tmp/koha_###_upload which is the reservoir. Unless there is a Match field and Match value (even where a site has only one vendor supplying Marc Order data) the script will attempt to process any files in the reservoir (historical files!). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40953 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 [Bug 40953] marc_ordering_process.pl broken due to accidental newline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42568 [Bug 42568] Match maxlength attributes to marc_order_accounts column sizes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk --- Comment #135 from Aude Charillon <aude.charillon@openfifth.co.uk> --- For documentation: see also bug 42821. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org