[Bug 17859] New: Move JavaScript to the footer on about and auth pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Bug ID: 17859 Summary: Move JavaScript to the footer on about and auth pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 17418 Blocks: 17858 Two "standalone" templates which can have the JavaScript moved to the footer: The about page and the login page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58649&action=edit Bug 17859 - Move JavaScript to the footer on about and auth pages This patch modifies the about page and the login page templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test each page to confirm that JavaScript-based interactions are unaffected: - On the About page tabs and header menu dropdowns should work correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Hiya. On the Koha About page I found that all the tabs were missing and being listed as bullet points. The content from all the tabs was being displayed in one go on the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58649|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58650&action=edit [SIGNED-OFF] Bug 17859 - Move JavaScript to the footer on about and auth pages This patch modifies the about page and the login page templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test each page to confirm that JavaScript-based interactions are unaffected: - On the About page tabs and header menu dropdowns should work correctly Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 [Bug 17870] Call to include file incorrectly moved into the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58650|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58728&action=edit Bug 17859 - Move JavaScript to the footer on about and auth pages This patch modifies the about page and the login page templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test each page to confirm that JavaScript-based interactions are unaffected: - On the About page tabs and header menu dropdowns should work correctly Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Claire Gravely from comment #2)
Hiya. On the Koha About page I found that all the tabs were missing and being listed as bullet points. The content from all the tabs was being displayed in one go on the page.
It works for me, I suppose you did not correctly refreshed your browser cache. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Bug 17859 depends on bug 17870, which changed state. Bug 17870 Summary: Call to include file incorrectly moved into the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17418 | CC| |martin.renvoize@openfifth.c | |o.uk Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org