[Bug 43599] New: auth_val_cat.sql should be updated for is_integer_only column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 Bug ID: 43599 Summary: auth_val_cat.sql should be updated for is_integer_only column Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- Bug 27512 added is_integer_only column but we don;t update the defaults in auth_val_cat.sql. The following is_system categories should be is_interger_only = 1 +---------------+-----------+-----------------+ | category_name | is_system | is_integer_only | +---------------+-----------+-----------------+ | DAMAGED | 1 | 1 | | LOST | 1 | 1 | | NOT_LOAN | 1 | 1 | | RESTRICTED | 0 | 1 | | STACK | 0 | 1 | | WITHDRAWN | 1 | 1 | +---------------+-----------+-----------------+ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 206581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206581&action=edit Bug 43599: Update auth_val_cat.sql to ccount for is_integer_only column To test: 0. APPLY PATCH 1. reset_all 2. Check to make sure the columns are right: select * from authorised_value_categories where is_integer_only = 1; +---------------+-----------+-----------------+ | category_name | is_system | is_integer_only | +---------------+-----------+-----------------+ | DAMAGED | 1 | 1 | | LOST | 1 | 1 | | NOT_LOAN | 1 | 1 | | RESTRICTED | 0 | 1 | | STACK | 0 | 1 | | WITHDRAWN | 1 | 1 | +---------------+-----------+-----------------+ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 [Bug 27512] Block creation of invalid authorised values for LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jvinke@austinseminary.edu --- Comment #2 from John Vinke <jvinke@austinseminary.edu> --- When I try to test this, is_integer_only has a value of 0 for every column, even after running reset_all && updatedatabase && dbic && restart_all. Is there something else that needs to happen? Also, line 77 is ('ILL_STATUS_ALIAS, 0'); and I think you meant ('ILL_STATUS_ALIAS', 0); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 209223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209223&action=edit Bug 43599: (follow-up) Fix typos -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to John Vinke from comment #2)
When I try to test this, is_integer_only has a value of 0 for every column, even after running reset_all && updatedatabase && dbic && restart_all.
Is there something else that needs to happen?
Also, line 77 is ('ILL_STATUS_ALIAS, 0'); and I think you meant ('ILL_STATUS_ALIAS', 0);
Hey John, thanks for testing! I think the problem was the exact typo you pointed out, nice catch. I have provided a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206581|0 |1 is obsolete| | Attachment #209223|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 --- Comment #5 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 209242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209242&action=edit Bug 43599: Update auth_val_cat.sql to ccount for is_integer_only column To test: 0. APPLY PATCH 1. reset_all 2. Check to make sure the columns are right: select * from authorised_value_categories where is_integer_only = 1; +---------------+-----------+-----------------+ | category_name | is_system | is_integer_only | +---------------+-----------+-----------------+ | DAMAGED | 1 | 1 | | LOST | 1 | 1 | | NOT_LOAN | 1 | 1 | | RESTRICTED | 0 | 1 | | STACK | 0 | 1 | | WITHDRAWN | 1 | 1 | +---------------+-----------+-----------------+ Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 --- Comment #6 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 209243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209243&action=edit Bug 43599: (follow-up) Fix typos Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |bibliothek@th-wildau.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 --- Comment #7 from Jan Kissig <bibliothek@th-wildau.de> --- Hi Lucas, how should we handle updates here, as this applies only to new installations? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org