[Bug 9252] New: Add option to send patron's home branch in AF field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Bug ID: 9252 Summary: Add option to send patron's home branch in AF field Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com CC: colin.campbell@ptfs-europe.com There are two pieces of information that SIP needs to pass along to Overdrive when authenticating: Patron type and Home library. We are getting Patron type just fine. However, it appears that there is no mechanism in SIP at this time to pass along Home library. It is critical that we get this information though as we need to be able to break down actual patron usage among individual patron home libraries. Since Overdrive logs in through SIP using a single SIP login, it becomes obvious AO does not work for this. According to Overdrive, putting the patron home branch in an AF field will work just fine for them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13976&action=edit Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13976|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13977&action=edit Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Do we need to repeat AF in this case? I would think replacing the Greetings AF by one containing branch would make for simpler processing on the client side -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #3)
Do we need to repeat AF in this case? I would think replacing the Greetings AF by one containing branch would make for simpler processing on the client side
Is the AF field traditionally displayed by SIP self checkout machines? I had assumed they did, which would make having them display the branchcode on the screen odd if not confusing for patrons. That is why I made add this AF field configurable on a per SIP account basis. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Yes AF is for screen display. If there are multiple AFs they should result in a multiple line display. (one AF per line). (How much we can rely on units doing that is up for discussion) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #5)
Yes AF is for screen display. If there are multiple AFs they should result in a multiple line display. (one AF per line). (How much we can rely on units doing that is up for discussion)
I think it's probably best we assume they do, even if many don't. The idea behind the account-level configuration for this, is so we can send this extra AF to Overdrive ( or any other SIP using service ) and not to SCO units ( in case one library is using both ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13977|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 18210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18210&action=edit Bug 9243: Bad delete order in sub index-records If we have in the zebraqueue table for the same record, one line "update" and another "delete", the index_records sub in rebuild_zebra.pl treats the delete line first. The result is that the record still exists in zebra. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by George Williams <georgew@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18210|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 18211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18211&action=edit Bug 9243: Bad delete order in sub index-records If we have in the zebraqueue table for the same record, one line "update" and another "delete", the index_records sub in rebuild_zebra.pl treats the delete line first. The result is that the record still exists in zebra. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=9252 Signed-off-by: George Williams <georgew@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18211|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13977|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- My name is Christopher Brannon with the Coeur d'Alene Public Library, and we have tested the patch and can verify that the patch works as intended. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #12 from Christopher Brannon <cbrannon@cdalibrary.org> --- My name is Christopher Brannon with the Coeur d'Alene Public Library, and we have tested the patch and can verify that the patch works as intended. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13977|0 |1 is obsolete| | --- Comment #13 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18212&action=edit [Signed off] Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. Signed-off-by: George Williams <georgew@latahlibrary.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #14 from Melia Meggs <melia@bywatersolutions.com> --- This patch was tested by George and Christopher. They have verified it works, so I am signing it off on their behalf. (We had some weirdness trying to use the sandbox.) Thanks, Melia -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18212|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19083&action=edit Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. Signed-off-by: George Williams <georgew@latahlibrary.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19083|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19084&action=edit Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. Signed-off-by: George Williams <georgew@latahlibrary.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Comment on attachment 19084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19084 Bug 9252 - Add option to send patron's home branch in AF field Review of attachment 19084: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9252&attachment=19084) ----------------------------------------------------------------- ::: C4/SIP/Sip/MsgType.pm @@ +453,5 @@
}
+ $resp .= maybe_add( FID_SCREEN_MSG, $patron->screen_msg ); + $resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode} ) + if ( $server->{account}->{send_patron_home_library_in_af} );
I see at line 492 $resp = build_patron_status($patron, $lang, $fields, $server ); but line 742 has $resp = build_patron_status($patron, $patron->language, $fields); In the handle_block_patron subroutine. This means that $server will be undefined and throw a warn. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19469&action=edit Bug 9252 - Add option to send patron's home branch in AF field - QA Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19084|0 |1 is obsolete| | --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20264&action=edit Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. Signed-off-by: George Williams <georgew@latahlibrary.org> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19469|0 |1 is obsolete| | --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20265&action=edit Bug 9252 - Add option to send patron's home branch in AF field - QA Followup Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #21 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org