[Bug 10769] New: Simplify clearing of input fields when duplicating a patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 Bug ID: 10769 Summary: Simplify clearing of input fields when duplicating a patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently the patron entry template has a lot of logic handling form fields when the operation being performed is "duplicate:" [% IF ( opduplicate ) %] <input type="text" name="altcontactphone" id="altcontactphone" value="[% altcontactphone %]" onclick="this.value=''" /> [% ELSE %] <input type="text" name="altcontactphone" id="altcontactphone" value="[% altcontactphone %]" /> [% END %] I propose to set a class on fields which require this behavior so that the event can be handled in the script block. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20503&action=edit Bug 10769 - Simplify clearing of input fields when duplicating a patron When duplicating a patron record an onclick event is added to many fields in order to make then clear when focused. This patch updates the template so that the logic for this can be simplified. A template variable is set based on the 'opduplicate' variable, and a class added to the relevant fields. All fields with that class are cleared on focus. Also changed are several markup issues which were causing validation errors. To test, find or create a patron record which has all standard text fields filled with data. Use the "duplicate" button on the detail view of that patron to initiate the duplication process. Focus on each field in the patron entry form in succession. Fields which contain data should be cleared in the same way they were before the patch. Also test a regular edit operation to confirm that fields are not cleared. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 Campbell Reid-Tait <campbellreidtait@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20503|0 |1 is obsolete| | Status|Needs Signoff |Signed Off CC| |campbellreidtait@gmail.com Assignee|koha-bugs@lists.koha-commun |campbellreidtait@gmail.com |ity.org | --- Comment #2 from Campbell Reid-Tait <campbellreidtait@gmail.com> --- Created attachment 20683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20683&action=edit Signed Off: Bug 10769 - Simplify clearing of input fields when duplicating a patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20683|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20735&action=edit Bug 10769 - Simplify clearing of input fields when duplicating a patron When duplicating a patron record an onclick event is added to many fields in order to make then clear when focused. This patch updates the template so that the logic for this can be simplified. A template variable is set based on the 'opduplicate' variable, and a class added to the relevant fields. All fields with that class are cleared on focus. Also changed are several markup issues which were causing validation errors. To test, find or create a patron record which has all standard text fields filled with data. Use the "duplicate" button on the detail view of that patron to initiate the duplication process. Focus on each field in the patron entry form in succession. Fields which contain data should be cleared in the same way they were before the patch. Also test a regular edit operation to confirm that fields are not cleared. Signed-off-by: Campbell Reid-Tait <campbellreidtait@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10769 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org