[Bug 34359] New: Can we get rid of Koha/BiblioUtils ?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Bug ID: 34359 Summary: Can we get rid of Koha/BiblioUtils ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org This is not used (only by itself): git grep BiblioUtils::Iterator Koha/BiblioUtils/Iterator.pm:package Koha::BiblioUtils::Iterator; Koha/BiblioUtils/Iterator.pm:Koha::BiblioUtils::Iterator - iterates over biblios provided by a DBIx::Class::ResultSet Koha/BiblioUtils/Iterator.pm: use Koha::BiblioUtils::Iterator; Koha/BiblioUtils/Iterator.pm: my $iterator = Koha::BiblioUtils::Iterator->new($rs); t/db_dependent/Koha/BiblioUtils/Iterator.t:use_ok('Koha::BiblioUtils::Iterator'); t/db_dependent/Koha/BiblioUtils/Iterator.t:my $iterator = Koha::BiblioUtils::Iterator->new($rs, items => 1 ); I know that someone kind of hates Util modules :) Unfortunately we cannot (yet) remove Koha::BiblioUtils module: Koha/BiblioUtils.pm:package Koha::BiblioUtils; Koha/BiblioUtils.pm:Koha::BiblioUtils - contains fundamental biblio-related functions Koha/BiblioUtils.pm: my $biblio = Koha::BiblioUtils->new($marc_record, [$biblionumber]); Koha/BiblioUtils.pm:Creates an instance of C<Koha::BiblioUtils> based on the marc record. If known, Koha/BiblioUtils.pm: my $biblio = Koha::BiblioUtils->get_from_biblionumber($biblionumber, %options); Koha/BiblioUtils.pm:This will give you an instance of L<Koha::BiblioUtils> that is the biblio that Koha/BiblioUtils.pm: my $it = Koha::BiblioUtils->get_all_biblios_iterator(%options); Koha/BiblioUtils.pm:Koha::BiblioUtils of each biblio. This will include the item data. Koha/BiblioUtils.pm: my $marc = Koha::BiblioUtils->get_marc_biblio($bibnum, %options); misc/release_notes/release_notes_22_05_00.html:<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625">[29625]</a> Wrong var name in Koha::BiblioUtils get_all_biblios_iterator</li> misc/release_notes/release_notes_22_05_00.md:- [[29625]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625) Wrong var name in Koha::BiblioUtils get_all_biblios_iterator misc/search_tools/rebuild_elasticsearch.pl:use Koha::BiblioUtils; misc/search_tools/rebuild_elasticsearch.pl: return ($r, Koha::BiblioUtils->get_from_biblionumber($r, item_data => 1 )); misc/search_tools/rebuild_elasticsearch.pl: my $records = Koha::BiblioUtils->get_all_biblios_iterator(%iterator_options); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153839&action=edit Bug 34359: Remove unneeded module Koha/BiblioUtils/Iterator.pm with test Test plan: git grep BiblioUtils::Iterator Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can we get rid of |Can we get rid of |Koha/BiblioUtils ? |Koha/BiblioUtils/Iterator ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12478 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This has actually been replaced with Koha::BiblioUtils::get_all_biblios_iterator, since the very beginning (12478). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153839|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153854&action=edit Bug 34359: Remove unneeded module Koha/BiblioUtils/Iterator.pm with test Test plan: git grep BiblioUtils::Iterator Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153854|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154079&action=edit Bug 34359: Remove unneeded module Koha/BiblioUtils/Iterator.pm with test Test plan: git grep BiblioUtils::Iterator Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|Can we get rid of |Get rid of |Koha/BiblioUtils/Iterator ? |Koha/BiblioUtils/Iterator -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- I propose not to backport to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org