https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24781 Bug ID: 24781 Summary: Parse and build query strings more reliably Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Throughout the code, you'll see a lot of string mangling to manipulate query strings. Examples from opac-search.pl: $query_cgi = "tag=" . uri_escape_utf8( $tag ) . "&" . $query_cgi; $pasarParams .= '&query=' . uri_escape_utf8($query); $pasarParams .= '&count=' . uri_escape_utf8($results_per_page); $pasarParams .= '&simple_query=' . uri_escape_utf8($simple_query); $limit_cgi_not_availablity =~ s/&limit=available//g if defined $limit_cgi_not_availablity; It would be good to have a more reliable unit-tested way of creating and editing query strings. I have a module called Koha::Util::URL which should be able to help. I'm hoping to put together a patch tomorrow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.