[Bug 17355] New: Allow deletion of authorised value categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Bug ID: 17355 Summary: Allow deletion of authorised value categories Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This will be a follow-up to bug 17216 that adds a separate table for authorised value categories. Now that we store them, we need a way to delete accidentally added categories easily. Jonathan wrote about this: - There is no way to delete a category (TODO). But to do so it would be good to have a authorised_value_categories.is_internal field to mark some categories as "cannot be deleted". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17216 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 [Bug 17216] Add a new table to store authorized value categories -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64102&action=edit Bug 17355 - Allow deletion of authorised value categories This is jsut a ptach I was toying with - as Jonathan mentions we need a way to prevent deletion of internal categories, I just listed them here (we would list more) Partial patch, so would need work but poking this bug as reminder :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com Summary|Allow deletion of |Authorised value categories |authorised value categories |cannot be deleted Severity|enhancement |normal --- Comment #2 from Barton Chittenden <barton@bywatersolutions.com> --- *** Bug 18813 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64102|0 |1 is obsolete| | --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 65782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65782&action=edit Bug 17355 - Allow deletion of authorised value categories This is jsut a ptach I was toying with - as Jonathan mentions we need a way to prevent deletion of internal categories, I just listed them here (we would list more) Partial patch, so would need work but poking this bug as reminder :-) Signed-off-by: Liz Rea <liz@catalyst.net.nz> This is a good start -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65782|0 |1 is obsolete| | --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 65869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65869&action=edit Bug 17355 - Allow deletion of authorised value categories Note that this does not capture all internal fields, and isn't a database solution to the problem of marking internal fields. To test: Add an empty authorised value category, delete it. Make sure it stays deleted. Try to delete an empty system authorised value, like ccode. You should not see the button. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 65870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65870&action=edit Bug 17355 - fixing typo in success message -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should this be 'Needs Sign-off'? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66022&action=edit [SIGNED OFF] Bug 17355 - Allow deletion of authorised value categories Note that this does not capture all internal fields, and isn't a database solution to the problem of marking internal fields. To test: Add an empty authorised value category, delete it. Make sure it stays deleted. Try to delete an empty system authorised value, like ccode. You should not see the button. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66023&action=edit [SIGNED OFF] Bug 17355 - fixing typo in success message Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66024&action=edit Bug 17355 - Follow-up - Fix page structure and alert on delete - Fixes page structure in 2 spots. Without the patch the second problem was manifesting in a display problem with the right side tool navigation. - Adds a specific 'Are you sure you want to...' question instead of reusing the one for authorised values also for categories. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65869|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65870|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Do not you think that my suggestion to add a new "is_internal" (or whatever) new DB field could be better? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just noticed that + LOC => 1, is doubled up in the patch. I think the idea of a database field is good, but maybe this could be done in a separate patch? We filed the bug a year ago :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- QA comment: 1. It is possible to delete protected categories by changing the URL, e.g. /cgi-bin/koha/admin/authorised_values.pl?op=del_category&category=Bsort1 The deletion must be prevented on the server side. 2. The 'Delete category' button is inside the message box for "There are no authorised values ...". Why not in the toolbar like the other buttons ? 3. After a successful deletion, there is no redirect, so if we refresh the page the deletion is tried again and we end up with the following error message: "error_on_delete_cat". This message should be more human-friendly and IMO there should be a redirect after the deletion. 4. As comment 11 says, LOC appears twice in the hash, as well as LOST. These duplicates must be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila@collect | |o.ca | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we revive this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #14 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #13)
Can we revive this?
I think that sounds like a good idea. I just had someone ask me to delete a category for them that they added by accident. It seemed unfortunate that they couldn't do it themself. I was thinking "user_defined" might be a better column for the database than "is_internal". Anything without that flag would be considered to be an internal/system value. I think this would future-proof us against new internal/system authorised values categories. For instance, in the existing patches, there are lots of categories missing which show up in the SQL packaged with the Koha installer. I think we only really want to worry about deleting categories that have been added by users, so we could just set that flag when users add via the Web UI. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Agnes Rivers-Moore <arm@hanover.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm@hanover.ca --- Comment #15 from Agnes Rivers-Moore <arm@hanover.ca> --- I had to get help deleting a couple of accidental categories. Anyone still interested in finishing this up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 25275 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|nick@bywatersolutions.com |jonathan.druart@bugs.koha-c | |ommunity.org QA Contact|julian.maurice@biblibre.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66022|0 |1 is obsolete| | Attachment #66023|0 |1 is obsolete| | Attachment #66024|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103833&action=edit Bug 17355: DB changes This patch adds a new authorised_value_category.is_system boolean/tinyint(1) DB field. Name 'is_system' is coming from existing tables account_credit_types and account_debit_types and should not be discussed here (if you disagree fill a new bug report and deal with naming issue separately) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103834&action=edit Bug 17355: DBIC changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103835&action=edit Bug 17355: DBIC changes - boolean flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103836&action=edit Bug 17355: Override delete methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103837&action=edit Bug 17355: DB changes - set is_system for categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103838&action=edit Bug 17355: Add the ability to remove authorised value categories This new patch set is adding a new DB field is_system to distinguish internal categories. The list of internal categories is in the patch "DB changes - set is_system for categories" and can be discussed/extended. Test plan: 1. - Create a new AV category - Create an authorised value - List the AVs for this category - Remove all the AVs for this category => You see 2 buttons "Add a new authorised value" and "Delete category 'XXX'" - Click the delete button => You get a popup - Accept => The category is deleted 2. - List the AV for Asort1 (internal category) /cgi-bin/koha/admin/authorised_values.pl?searchfield=Asort1 - Delete the AVs for this category (if there is any) => You do not see the "Delete category" button 3. - Create a new AV category 'foo' - Create an authorised value - Hit /admin/authorised_values.pl?op=delete_category&categor_name=foo => You get an error message (the category cannot be deleted if it has AV linked) 4. - Hit /admin/authorised_values.pl?op=delete_category&categor_name=Asort1 => You get an error message (the category Asort1 cannot be deleted, it's an internal category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Finding for QA:
3. - Create a new AV category 'foo' - Create an authorised value - Hit /admin/authorised_values.pl?op=delete_category&categor_name=foo => You get an error message (the category cannot be deleted if it has AV linked)
Message is « An error occurred when deleting this authorized value category. Check the logs. » Plack error logs don't show anything. Access logs show a 200 HTTP code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
4. - Hit /admin/authorised_values.pl?op=delete_category&categor_name=Asort1 => You get an error message (the category Asort1 cannot be deleted, it's an internal category.
Same. Plack error logs don't show anything. Access logs show a 200 HTTP code. No issue for the signing off IMO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103833|0 |1 is obsolete| | --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104099&action=edit Bug 17355: DB changes This patch adds a new authorised_value_category.is_system boolean/tinyint(1) DB field. Name 'is_system' is coming from existing tables account_credit_types and account_debit_types and should not be discussed here (if you disagree fill a new bug report and deal with naming issue separately) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103834|0 |1 is obsolete| | --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104100&action=edit Bug 17355: DBIC changes Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103835|0 |1 is obsolete| | --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104101&action=edit Bug 17355: DBIC changes - boolean flag Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103836|0 |1 is obsolete| | --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104102&action=edit Bug 17355: Override delete methods Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103837|0 |1 is obsolete| | --- Comment #29 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104103&action=edit Bug 17355: DB changes - set is_system for categories Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103838|0 |1 is obsolete| | --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 104104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104104&action=edit Bug 17355: Add the ability to remove authorised value categories This new patch set is adding a new DB field is_system to distinguish internal categories. The list of internal categories is in the patch "DB changes - set is_system for categories" and can be discussed/extended. Test plan: 0. - Apply patch - updatedabase 1. - Create a new AV category - Create an authorised value - List the AVs for this category - Remove all the AVs for this category => You see 2 buttons "Add a new authorised value" and "Delete category 'XXX'" - Click the delete button => You get a popup - Accept => The category is deleted 2. - List the AV for Asort1 (internal category) /cgi-bin/koha/admin/authorised_values.pl?searchfield=Asort1 - Delete the AVs for this category (if there is any) => You do not see the "Delete category" button 3. - Create a new AV category 'foo' - Create an authorised value - Hit /admin/authorised_values.pl?op=delete_category&categor_name=foo => You get an error message (expected because the category cannot be deleted if it has AV linked) => message text: => An error occurred when deleting this authorized value category. Check the logs. 4. - Hit /admin/authorised_values.pl?op=delete_category&categor_name=Asort1 => You get an error message (expected because the category Asort1 cannot be deleted, it's an internal category. => message text: => An error occurred when deleting this authorized value category. Check the logs. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #31 from Victor Grousset/tuxayo <victor@tuxayo.net> --- The following has been adding in the test plan: 0. - Apply patch - updatedabase Tried to clarify test plan about the error messages. Don't expect them to tell the cause. QA: which is fine IMHO, because the messages are there in case of direct access with by URL. Detailed parts: in 3: => You get an error message (expected because the category cannot be deleted if it has AV linked) => message text: => An error occurred when deleting this authorized value category. Check the logs. in 4: => You get an error message (expected because the category Asort1 cannot be deleted, it's an internal category. => message text: => An error occurred when deleting this authorized value category. Check the logs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104099|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104117&action=edit Bug 17355: DB changes This patch adds a new authorised_value_category.is_system boolean/tinyint(1) DB field. Name 'is_system' is coming from existing tables account_credit_types and account_debit_types and should not be discussed here (if you disagree fill a new bug report and deal with naming issue separately) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104100|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104118&action=edit Bug 17355: DBIC changes Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104101|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104119&action=edit Bug 17355: DBIC changes - boolean flag Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104102|0 |1 is obsolete| | --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104120&action=edit Bug 17355: Override delete methods Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104103|0 |1 is obsolete| | --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104121&action=edit Bug 17355: DB changes - set is_system for categories Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104104|0 |1 is obsolete| | --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104122&action=edit Bug 17355: Add the ability to remove authorised value categories This new patch set is adding a new DB field is_system to distinguish internal categories. The list of internal categories is in the patch "DB changes - set is_system for categories" and can be discussed/extended. Test plan: 0. - Apply patch - updatedabase 1. - Create a new AV category - Create an authorised value - List the AVs for this category - Remove all the AVs for this category => You see 2 buttons "Add a new authorised value" and "Delete category 'XXX'" - Click the delete button => You get a popup - Accept => The category is deleted 2. - List the AV for Asort1 (internal category) /cgi-bin/koha/admin/authorised_values.pl?searchfield=Asort1 - Delete the AVs for this category (if there is any) => You do not see the "Delete category" button 3. - Create a new AV category 'foo' - Create an authorised value - Hit /admin/authorised_values.pl?op=delete_category&categor_name=foo => You get an error message (expected because the category cannot be deleted if it has AV linked) => message text: => An error occurred when deleting this authorized value category. Check the logs. 4. - Hit /admin/authorised_values.pl?op=delete_category&categor_name=Asort1 => You get an error message (expected because the category Asort1 cannot be deleted, it's an internal category. => message text: => An error occurred when deleting this authorized value category. Check the logs. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104123&action=edit Bug 17355: (QA follow-up) Add description to updatedatabase entry Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This will make support staff's lives much easier. 2 comments: - I think the delete would be nice to have in the menu on the categories table as well (could be done laer9 - I wonder if 'is_internal' would work a bit better than 'is_system' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Jaki <jaki.frisina@leblibrary.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jaki.frisina@leblibrary.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104352&action=edit Bug 17355: Fix failing tests This patch makes the tests pass without deleting mandatory AV cats -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #42 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 104539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104539&action=edit Bug 17355: (QA follow-up) Fix used package name Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #43 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25651 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 [Bug 25651] Modifying an authorised value make it disappear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk@ckls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|madamyk@ckls.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 11267 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org