[Bug 18661] New: Make "Replace only included patron attributes" default on patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Bug ID: 18661 Summary: Make "Replace only included patron attributes" default on patron import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org "Replace only included patron attributes" on the patron import page is the less dangerous option and should be the default. If you forget to switch from "Replace all patron attributes" any additional attributes will be silently deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Te Rauhina Jackson <terauhina.jackson@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 --- Comment #1 from Te Rauhina Jackson <terauhina.jackson@gmail.com> --- Created attachment 70572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70572&action=edit Made "Replace only included patron attributes" default on patron import Test Plan: 1) Go to the import patrons page and notice that "Replace all patron attributes" is selected by default in the Patron Attributes section. 2) Apply this patch 3) Go back to the import patrons page and notice that "Replace only included patron attributes" is delected by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr Status|Needs Signoff |Failed QA --- Comment #2 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Problem on sandbox 8. Not tested. The sandbox you've requested is not ready. Some problems occurred applying patches from bug 18661: <h1>Something went wrong !</h1>Applying: Made Replace only included patron attributes default on patron import Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt error: Failed to merge in the changes. Patch failed at 0001 Made Replace only included patron attributes default on patron import The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 18661 - Make Replace only included patron attributes default on patron import 70572 - Made Replace only included patron attributes default on patron import Apply? [(y)es, (n)o, (i)nteractive] Patch left in tmpMade-Replace-only-included-patron-attributes-defau-C0CswV.patch . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Jack <jke0429@stacmail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jke0429@stacmail.net CC| |jke0429@stacmail.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Jack <jke0429@stacmail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jke0429@stacmail.net |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70572|0 |1 is obsolete| | --- Comment #3 from Jasmine Amohia <jasmineamohia.student@wegc.school.nz> --- Created attachment 84031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84031&action=edit Bug 18661: Made "Replace only included patron attributes" default on patron import Test Plan: 1) Go to the import patrons page and notice that "Replace all patron attributes" is selected by default in the Patron Attributes section. 2) Apply this patch 3) Go back to the import patrons page and notice that "Replace only included patron attributes" is delected by default. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jasmineamohia.student@wegc. | |school.nz Assignee|koha-bugs@lists.koha-commun |jasmineamohia.student@wegc. |ity.org |school.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Hi Jasmine. The patch works, but it duplicates the patron attributes form section and puts it AFTER the Notes section on the right hand side(depending on your browser window size). It should update the form section before the import button, which starts at around line 223. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84031|0 |1 is obsolete| | --- Comment #5 from Jasmine Amohia <jasmineamohia.student@wegc.school.nz> --- Created attachment 84085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84085&action=edit Bug 18661: Made "Replace only included patron attributes" default on patron import Test Plan: 1) Go to the import patrons page and notice that "Replace all patron attributes" is selected by default in the Patron Attributes section. 2) Apply this patch 3) Go back to the import patrons page and notice that "Replace only included patron attributes" is delected by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84085|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 84087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84087&action=edit Bug 18661: Made "Replace only included patron attributes" default on patron import Test Plan: 1) Go to the import patrons page and notice that "Replace all patron attributes" is selected by default in the Patron Attributes section. 2) Apply this patch 3) Go back to the import patrons page and notice that "Replace only included patron attributes" is delected by default. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from David Nind <david@davidnind.com> --- Thanks Jasmine! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84087|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84088&action=edit Bug 18661: Made "Replace only included patron attributes" default on patron import Test Plan: 1) Go to the import patrons page and notice that "Replace all patron attributes" is selected by default in the Patron Attributes section. 2) Apply this patch 3) Go back to the import patrons page and notice that "Replace only included patron attributes" is delected by default. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Jasmine! I'd be nice if you could add a little note to the "Text to go in the release notes" describing the change in behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |On the 'import patrons' release notes| |page, the "Replace all | |patron attributes" is | |automatically selected | |which is the more dangerous | |option. This patch sets the | |default selection as | |"Replace only included | |patron attributes" as it is | |a safer option. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Jasmine! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- A good enhancement, but it brings a change of functionality which could prove surprising to end users on the stable branch.. as such I will not be backporting this one to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org