[Bug 21478] New: Koha::Hold->suspend_hold allows suspending in transit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Bug ID: 21478 Summary: Koha::Hold->suspend_hold allows suspending in transit holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org My understanding is that both 'waiting' and 'in transit' holds are 'found', and in both cases suspending them should be disallowed. I haven't looked at the places in which this could happen, but the code implementing the checks in Koha::Hold clearly misses the use case. The method should be renamed to the new guidelines (->suspend) and it should raise exceptions in both cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Indeed, the condition exist template-side only. * in holds_table.inc (for request.pl) 177 [% IF SuspendHoldsIntranet %] 178 <td> 179 [% UNLESS ( hold.found ) %] * in holds.js (for "Check out", "Details" from the patron's module) 152 if ( oObj.found ) { 153 return ""; 154 } else if ( oObj.suspend == 1 ) { 155 return "<a class='hold-resume btn btn-default btn-xs' id='resume" + oObj.reserve_id + "'>" 156 + "<i class='fa fa-play'></i> " + RESUME + "</a>"; 157 } else { 158 return "<a class='hold-suspend btn btn-default btn-xs' id='suspend" + oObj.reserve_id + "'>" 159 + "<i class='fa fa-pause'></i> " + SUSPEND + "</a>"; 160 } Other calls to ModReserve do not suspend/resume, except the one from Koha/REST/V1/Hold.pm. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84409&action=edit Bug 21478: Add Koha::Exceptions::Hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84410&action=edit Bug 21478: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84411&action=edit Bug 21478: Make Koha::Hold->suspend reject found holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 [Bug 22206] Add route to handle holds suspensions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84409|0 |1 is obsolete| | Attachment #84410|0 |1 is obsolete| | Attachment #84411|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84432&action=edit Bug 21478: Add Koha::Exceptions::Hold Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84433&action=edit Bug 21478: Unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84434&action=edit Bug 21478: Make Koha::Hold->suspend reject found holds Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84432|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84456&action=edit Bug 21478: Add Koha::Exceptions::Hold Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84433|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84457&action=edit Bug 21478: Unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84434|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84458&action=edit Bug 21478: Make Koha::Hold->suspend reject found holds Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84487&action=edit Bug 21478: (QA follow-up) Make sure tests don't fail randomly Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Needs some work for 17.11.x. I'm not sure it is worth doing it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Fridolin SOMERS from comment #15)
Needs some work for 17.11.x. I'm not sure it is worth doing it.
No worries about it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org