https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21478 Bug ID: 21478 Summary: Koha::Hold->suspend_hold allows suspending in transit holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org My understanding is that both 'waiting' and 'in transit' holds are 'found', and in both cases suspending them should be disallowed. I haven't looked at the places in which this could happen, but the code implementing the checks in Koha::Hold clearly misses the use case. The method should be renamed to the new guidelines (->suspend) and it should raise exceptions in both cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.