[Bug 35032] New: Remove the use of "onclick" from Koha to MARC mapping template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35032 Bug ID: 35032 Summary: Remove the use of "onclick" from Koha to MARC mapping template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/koha2marclinks.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, testopia@bugs.koha-community.org There are a couple of uses of "onclick" in the Koha to MARC mapping template. These should be removed in favor of defining events in JavaScript. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35032 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35032 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156851&action=edit Bug 35032: Remove the use of "onclick" from Koha to MARC mapping template This patch eliminates two instances of "onclick" from the Koha to MARC mapping template, moving these event handlers into JS in the footer. To test, apply the patch and go to Administration -> Koha to MARC mapping. - Click "Add" next to a Koha field. - You should get a JS popup asking for entry of a MARC tag. Confirm that this process completes correctly. - Test a "Remove" link too. It should work to remove mapping from a Koha field. - Test the "Cancel" choice in both the "Add" and "Remove" cases to confirm that the operation is cancelled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35032 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156851|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 156877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156877&action=edit Bug 35032: Remove the use of "onclick" from Koha to MARC mapping template This patch eliminates two instances of "onclick" from the Koha to MARC mapping template, moving these event handlers into JS in the footer. To test, apply the patch and go to Administration -> Koha to MARC mapping. - Click "Add" next to a Koha field. - You should get a JS popup asking for entry of a MARC tag. Confirm that this process completes correctly. - Test a "Remove" link too. It should work to remove mapping from a Koha field. - Test the "Cancel" choice in both the "Add" and "Remove" cases to confirm that the operation is cancelled. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35032 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35032 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35032 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156877|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156988&action=edit Bug 35032: Remove the use of "onclick" from Koha to MARC mapping template This patch eliminates two instances of "onclick" from the Koha to MARC mapping template, moving these event handlers into JS in the footer. To test, apply the patch and go to Administration -> Koha to MARC mapping. - Click "Add" next to a Koha field. - You should get a JS popup asking for entry of a MARC tag. Confirm that this process completes correctly. - Test a "Remove" link too. It should work to remove mapping from a Koha field. - Test the "Cancel" choice in both the "Add" and "Remove" cases to confirm that the operation is cancelled. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35032 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35032 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35032 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 23.05.x It is minor so I skip. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org