[Bug 34849] New: Use template wrapper for breadcrumbs: OPAC part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Bug ID: 34849 Summary: Use template wrapper for breadcrumbs: OPAC part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org To continue the process started by Bug 32507, this patch will update several templates in the OPAC so that they use a template wrapper for breadcrumbs. - errors/errorpage.tt - opac-account.tt - opac-auth.tt - opac-curbside-pickups.tt - opac-discharge.tt - opac-holdshistory.tt - opac-illrequests.tt - opac-memberentry-update-submitted.tt - opac-memberentry.tt - opac-messaging.tt - opac-passwd.tt - opac-password-recovery.tt - opac-patron-consent.tt - opac-privacy.tt - opac-readingrecord.tt - opac-recalls.tt - opac-reset-password.tt - opac-routing-lists.tt - opac-search-history.tt - opac-shelves.tt - opac-tags.tt - opac-user.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155949&action=edit Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Purchase suggestions - Also test as a logged-out user with AnonSuggestions enabled. - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155949|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155951&action=edit Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - Routing lists (with RoutingSerials enabled) - Ask for a discharge (with useDischarge enabled) - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34852 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34852 [Bug 34852] Use template wrapper for breadcrumbs: OPAC part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155951|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155959&action=edit Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - Routing lists (with RoutingSerials enabled) - Ask for a discharge (with useDischarge enabled) - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34855 [Bug 34855] Use template wrapper for breadcrumbs: OPAC part 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34866 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34866 [Bug 34866] Use template wrapper for breadcrumbs: OPAC part 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de Status|Needs Signoff |Failed QA --- Comment #4 from Philip Orr <philip.orr@lmscloud.de> --- Every page except "Routing lists" has the correct links in the breadcrumb and everything looks correct. For "Routing lists" though, in the breadcrumb, the link to the user account links to .../cgi-bin/koha/opac-routing-lists.pl instead of .../cgi-bin/koha/opac-user.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 --- Comment #5 from Philip Orr <philip.orr@lmscloud.de> --- Also, qa complained about some lines: Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 346. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 349. |========================>| 24 / 24 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 341. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 344. |========================>| 24 / 24 (100.00%) Though everything still checked out OK, so I don't know if it's important. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155959|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157054&action=edit Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - Routing lists (with RoutingSerials enabled) - Ask for a discharge (with useDischarge enabled) - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157054|0 |1 is obsolete| | --- Comment #7 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 157064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157064&action=edit Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - Routing lists (with RoutingSerials enabled) - Ask for a discharge (with useDischarge enabled) - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157064|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157154&action=edit Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 This patch updates several OPAC templates so that they use a new WRAPPER for displaying breadcrumbs. The patch contains a minor CSS update, so you will have to rebuild the OPAC CSS for testings. Apply the patch and log in to the OPAC. Test each of the following pages and their variations. Breadcrumbs should look correct, and each link should be correct: - User summary - Charges - Personal details - Submit changes - Consents (with PrivacyPolicyConsent enabled) - Tags - Change password - Submit password change - Search history - Test when logged in and when not logged in - Checkout history - Privacy - Holds history - Recalls history - Messaging (with EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC enabled). - Lists - View private list - View public list - Edit list - Share list - Submit invitation - Create list - View list contents - Routing lists (with RoutingSerials enabled) - Ask for a discharge (with useDischarge enabled) - ILL requests - Curbside pickups - Error page: Navigate to a non-existent page Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34849 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is more an enhancement, not backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org