[Bug 33925] New: Improve translation of title tags: Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Bug ID: 33925 Summary: Improve translation of title tags: Serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 33906 This patch will modify serials templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155455&action=edit Bug 33925: Improve translation of title tags: Serials This patch updates serials templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers; Adding "page-section" <div> where it was lacking. To test, apply the patch and confirm that the following pages have the correct title tags: - Serials home - Serials search results - Subscription details - Subscription edit - Search for vendor - Search for bibliographic record - Subscription renew - Serial collection - Create and modify routing list - Preview routing list - View routing slip - Claims - Check expiration - With a subscription which has manual history enabled, click the "Edit history" link under the "Planning" tab. - Select multiple serial search results and batch edit - New subscription - Manage frequencies: Create and edit - Manage numbering patterns: Create and edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155455|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156569&action=edit Bug 33925: Improve translation of title tags: Serials This patch updates serials templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers; Adding "page-section" <div> where it was lacking. To test, apply the patch and confirm that the following pages have the correct title tags: - Serials home - Serials search results - Subscription details - Subscription edit - Search for vendor - Search for bibliographic record - Subscription renew - Serial collection - Create and modify routing list - Preview routing list - View routing slip - Claims - Check expiration - With a subscription which has manual history enabled, click the "Edit history" link under the "Planning" tab. - Select multiple serial search results and batch edit - New subscription - Manage frequencies: Create and edit - Manage numbering patterns: Create and edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Some minor changes required: 1. Serial collection - page title for edit serials has brackets with nothing in them: select a couple of editions and click on 'Edit serials' button, browser title page has "Serial edition () > [Serial name] > Serials > Koha (before patch this was "Serial edition [Serial name] > Serials > Koha"). 2. Edit routing list - serial name not in italics for page title: italics used for serial name on other pages, such as the detail page, serial collection; before the patch, the serial name was in italics (Editing routing list for Serial title - with "Serial title" in italics). 3. Check expiration - select a result and click on renew selected subscriptions: pop up window browser title has a ">" at the start: > Serials > Koha (before the patch, the title was "Serials subscription renew > Koha"). 4. Subscription history - serial name not in italics for page title: [Serial details page] > Planning > Manual history - Edit history. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156569|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161016&action=edit Bug 33925: Improve translation of title tags: Serials This patch updates serials templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers; Adding "page-section" <div> where it was lacking. To test, apply the patch and confirm that the following pages have the correct title tags: - Serials home - Serials search results - Subscription details - Subscription edit - Search for vendor - Search for bibliographic record - Subscription renew - Serial collection - Create and modify routing list - Preview routing list - View routing slip - Claims - Check expiration - With a subscription which has manual history enabled, click the "Edit history" link under the "Planning" tab. - Select multiple serial search results and batch edit - New subscription - Manage frequencies: Create and edit - Manage numbering patterns: Create and edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Loïc <loic.vassaux-artur@epitech.eu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |loic.vassaux-artur@epitech. | |eu Status|Needs Signoff |Signed Off --- Comment #5 from Loïc <loic.vassaux-artur@epitech.eu> --- For "With a subscription which has manual history enabled, click the "Edit history" link under the "Planning" tab." in the test plan the web page title is "Subscription history" and could maybe be "Edit subscription history". It's just a possible edit but it's not blocking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161016|0 |1 is obsolete| | --- Comment #6 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161238&action=edit Bug 33925: Improve translation of title tags: Serials This patch updates serials templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers; Adding "page-section" <div> where it was lacking. To test, apply the patch and confirm that the following pages have the correct title tags: - Serials home - Serials search results - Subscription details - Subscription edit - Search for vendor - Search for bibliographic record - Subscription renew - Serial collection - Create and modify routing list - Preview routing list - View routing slip - Claims - Check expiration - With a subscription which has manual history enabled, click the "Edit history" link under the "Planning" tab. - Select multiple serial search results and batch edit - New subscription - Manage frequencies: Create and edit - Manage numbering patterns: Create and edit Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161238|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 165102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165102&action=edit Bug 33925: Improve translation of title tags: Serials This patch updates serials templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers; Adding "page-section" <div> where it was lacking. To test, apply the patch and confirm that the following pages have the correct title tags: - Serials home - Serials search results - Subscription details - Subscription edit - Search for vendor - Search for bibliographic record - Subscription renew - Serial collection - Create and modify routing list - Preview routing list - View routing slip - Claims - Check expiration - With a subscription which has manual history enabled, click the "Edit history" link under the "Planning" tab. - Select multiple serial search results and batch edit - New subscription - Manage frequencies: Create and edit - Manage numbering patterns: Create and edit Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165102|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167790&action=edit Bug 33925: Improve translation of title tags: Serials This patch updates serials templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers; Adding "page-section" <div> where it was lacking. To test, apply the patch and confirm that the following pages have the correct title tags: - Serials home - Serials search results - Subscription details - Subscription edit - Search for vendor - Search for bibliographic record - Subscription renew - Serial collection - Create and modify routing list - Preview routing list - View routing slip - Claims - Check expiration - With a subscription which has manual history enabled, click the "Edit history" link under the "Planning" tab. - Select multiple serial search results and batch edit - New subscription - Manage frequencies: Create and edit - Manage numbering patterns: Create and edit Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167790|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170652&action=edit Bug 33925: Improve translation of title tags: Serials This patch updates serials templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers; Adding "page-section" <div> where it was lacking. To test, apply the patch and confirm that the following pages have the correct title tags: - Serials home - Serials search results - Subscription details - Subscription edit - Search for vendor - Search for bibliographic record - Subscription renew - Serial collection - Create and modify routing list - Preview routing list - View routing slip - Claims - Check expiration - With a subscription which has manual history enabled, click the "Edit history" link under the "Planning" tab. - Select multiple serial search results and batch edit - New subscription - Manage frequencies: Create and edit - Manage numbering patterns: Create and edit Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also includes some missing page sections :) QA'd by RM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch updates the release notes| |templates for the Serials | |pages to allow title tags | |to be more easily | |translated. It also updates | |some templates to add | |consistency for the page | |title, breadcrumb | |navigation and page headers | |and to add the | |"page-section" <div> where | |it was lacking. Keywords|release-notes-needed | CC| |philip.orr@lmscloud.de --- Comment #12 from Philip Orr <philip.orr@lmscloud.de> --- added release notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch updates the |This enhancement updates release notes|templates for the Serials |the templates for the |pages to allow title tags |serials pages to allow |to be more easily |title tags to be more |translated. It also updates |easily translated. It also |some templates to add |updates some templates to |consistency for the page |add consistency for the |title, breadcrumb |page title, breadcrumb |navigation and page headers |navigation, and page |and to add the |headers, and to add the |"page-section" <div> where |"page-section" <div> where |it was lacking. |it was lacking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not backport to 23.11.x to avoid translation work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #15 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Internal architecture, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org