[Bug 38126] New: Holds queue is allocating holds twice when using TransportCostMatrix and LocalHoldsPriority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Bug ID: 38126 Summary: Holds queue is allocating holds twice when using TransportCostMatrix and LocalHoldsPriority Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In MapItemsToHoldRequests we first attempt to fill holds with local priority - if we find any we mark the request 'allocated' then pass remaining holds to _allocateWithTransportCostMatrix, however, that routine doesn't filter out allocated holds To recreate: 1 - Enable RealTimeHoldsQueue 2 - Enable UseTransportCostMatrix 3 - Enable LocalHoldsPriority Give/Home/Home 4 - Administration - Transport cost matrix - enable transfers to/from Centreville and other libraries, add a cost, and save 5 - Find a bib with a Centerville item 6 - Place a hold for a centerville patron 7 - Circulation - Holds queue - All libraries 8 - Note hold is entered twice 9 - On command line: perl misc/cronjobs/holds/build_holds_queue.pl --force 10 - Run holds queue again, still there twice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172548&action=edit Bug 38126: Skip allocated holds when filling from transport cost matrix This patch simply weeds out allocated holds before filling from the matrix To test: 1 - Enable RealTimeHoldsQueue 2 - Enable UseTransportCostMatrix 3 - Enable LocalHoldsPriority Give/Home/Home 4 - Administration - Transport cost matrix - enable transfers to/from Centreville and other libraries, add a cost, and save 5 - Find a bib with a Centerville item 6 - Place a hold for a centerville patron 7 - Circulation - Holds queue - All libraries 8 - Note hold is entered twice 9 - On command line: perl misc/cronjobs/holds/build_holds_queue.pl --force 10 - Run holds queue again, still there twice 11 - Apply patch 12 - On command line: perl misc/cronjobs/holds/build_holds_queue.pl --force Confirm allocated only once 13 - Delete hold, place again from bib record (to test real time allocation) 14 - Confirm allocated only once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172548|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 172568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172568&action=edit Bug 38126: Skip allocated holds when filling from transport cost matrix This patch simply weeds out allocated holds before filling from the matrix To test: 1 - Enable RealTimeHoldsQueue 2 - Enable UseTransportCostMatrix 3 - Enable LocalHoldsPriority Give/Home/Home 4 - Administration - Transport cost matrix - enable transfers to/from Centreville and other libraries, add a cost, and save 5 - Find a bib with a Centerville item 6 - Place a hold for a centerville patron 7 - Circulation - Holds queue - All libraries 8 - Note hold is entered twice 9 - On command line: perl misc/cronjobs/holds/build_holds_queue.pl --force 10 - Run holds queue again, still there twice 11 - Apply patch 12 - On command line: perl misc/cronjobs/holds/build_holds_queue.pl --force Confirm allocated only once 13 - Delete hold, place again from bib record (to test real time allocation) 14 - Confirm allocated only once Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172568|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 172586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172586&action=edit Bug 38126: Skip allocated holds when filling from transport cost matrix This patch simply weeds out allocated holds before filling from the matrix To test: 1 - Enable RealTimeHoldsQueue 2 - Enable UseTransportCostMatrix 3 - Enable LocalHoldsPriority Give/Home/Home 4 - Administration - Transport cost matrix - enable transfers to/from Centreville and other libraries, add a cost, and save 5 - Find a bib with a Centerville item 6 - Place a hold for a centerville patron 7 - Circulation - Holds queue - All libraries 8 - Note hold is entered twice 9 - On command line: perl misc/cronjobs/holds/build_holds_queue.pl --force 10 - Run holds queue again, still there twice 11 - Apply patch 12 - On command line: perl misc/cronjobs/holds/build_holds_queue.pl --force Confirm allocated only once 13 - Delete hold, place again from bib record (to test real time allocation) 14 - Confirm allocated only once Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172586|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172697&action=edit Bug 38126: Skip allocated holds when filling from transport cost matrix This patch simply weeds out allocated holds before filling from the matrix To test: 1 - Enable RealTimeHoldsQueue 2 - Enable UseTransportCostMatrix 3 - Enable LocalHoldsPriority Give/Home/Home 4 - Administration - Transport cost matrix - enable transfers to/from Centreville and other libraries, add a cost, and save 5 - Find a bib with a Centerville item 6 - Place a hold for a centerville patron 7 - Circulation - Holds queue - All libraries 8 - Note hold is entered twice 9 - On command line: perl misc/cronjobs/holds/build_holds_queue.pl --force 10 - Run holds queue again, still there twice 11 - Apply patch 12 - On command line: perl misc/cronjobs/holds/build_holds_queue.pl --force Confirm allocated only once 13 - Delete hold, place again from bib record (to test real time allocation) 14 - Confirm allocated only once Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.05 released in| | Keywords|rel_24_05_candidate | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- *** Bug 37594 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826 [Bug 35826] Optimize building of holds queue based on transport cost matrix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35826 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38126 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org