[Bug 5922] New: Show waiting items for patron on return
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Bug #: 5922 Summary: Show waiting items for patron on return Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com I had a library suggesting a note on the check in screen when holds are waiting for the patron who is returning books. Discussion on IRC was that this message should be controlled by a sys pref. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-26 21:33:38 UTC --- Created attachment 3439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3439 Patch adding new syspref HoldNotifyAtCheckin This patch adds a new sys pref HoldNotifyAtCheckin. If ON librarian will be notified of waiting holds at this branch for the patron whose books are checked in. If OFF (default) not message will be shown. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3439|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-26 22:45:23 UTC --- Created attachment 3440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3440 Renamed syspref to WaitingNotifyAtCheckin -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Does not apply --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-03-28 00:31:56 UTC --- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 5922: Notify of waiting holds at checkin Using index info to reconstruct a base tree... <stdin>:25: trailing whitespace. <stdin>:26: trailing whitespace. if ( C4::Context->preference("WaitingNotifyAtCheckin") ) { <stdin>:29: trailing whitespace. my $waiting_holds; <stdin>:34: trailing whitespace. } <stdin>:36: trailing whitespace. $template->param( warning: squelched 2 whitespace errors warning: 7 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging circ/returns.pl Auto-merging installer/data/mysql/de-DE/mandatory/sysprefs.sql Auto-merging installer/data/mysql/en/mandatory/sysprefs.sql Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql Auto-merging installer/data/mysql/it-IT/necessari/sysprefs.sql Auto-merging installer/data/mysql/pl-PL/mandatory/sysprefs.sql Auto-merging installer/data/mysql/ru-RU/mandatory/system_preferences_full_optimal_for_install_only.sql Auto-merging installer/data/mysql/uk-UA/mandatory/system_preferences_full_optimal_for_install_only.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging kohaversion.pl CONFLICT (content): Merge conflict in kohaversion.pl Failed to merge in the changes. Patch failed at 0001 Bug 5922: Notify of waiting holds at checkin When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3440|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-28 06:37:40 UTC --- Created attachment 3458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3458 Rebases patch, fixed whitespace errors -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Guillaume Hatt <guillaume.hatt@enc.sorbonne.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guillaume.hatt@enc.sorbonne | |.fr AssignedTo|katrin.fischer@bsz-bw.de |guillaume.hatt@enc.sorbonne | |.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Guillaume Hatt <guillaume.hatt@enc.sorbonne.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Needs Signoff --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-05 02:34:46 UTC --- Hi Guillaume Did you send the signed off patch? I cant find it on the mailing list Chirs -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 --- Comment #6 from Guillaume Hatt <guillaume.hatt@enc.sorbonne.fr> 2011-04-05 08:19:46 UTC --- Signed off patch has been sent today. Guillaume -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|guillaume.hatt@enc.sorbonne |katrin.fischer@bsz-bw.de |.fr | --- Comment #7 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-06 13:51:55 UTC --- This bug is mentioned in: Bug 5922: Notify of waiting holds at checkin http://lists.koha-community.org/pipermail/koha-patches/2011-March/014235.htm... Bug 5922: Notify of waiting holds at checkin http://lists.koha-community.org/pipermail/koha-patches/2011-March/014236.htm... Bug 5922: Notify of waiting holds at checkin http://lists.koha-community.org/pipermail/koha-patches/2011-March/014237.htm... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-11 20:21:45 UTC --- This was signed off, but status wasn't changed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-13 02:49:40 UTC --- The signed off patch contains a patch of a patch??? Applied the original one instead. This was submitted for sign off before the feature freeze, pushing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> 2011-07-21 15:47:29 UTC --- Created attachment 4702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4702 Follow-up change - Adding patron name to dialog - Styling dialog as a message rather than an alert since it's informational rather than a warning -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> 2011-07-21 15:48:55 UTC --- Created attachment 4703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4703 Screenshot of the proposed change -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-01 01:03:29 UTC --- Pushed the follow up. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5922 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org