[Bug 32909] New: Item type icons broken when placing an item-level hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Bug ID: 32909 Summary: Item type icons broken when placing an item-level hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: a.roussos@dataly.gr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When placing an item-level hold in the Staff interface, the table at the bottom of the screen (under the "Place a hold on a specific item" heading) should display the icon associated with the item type of each item. This feature broke in v22.05.00 and is still broken [*] in the current master (ac1e80400d), as the <img> tag for the item type icon points to a path that begins with: /opac-tmpl/bootstrap/itemtypeimg instead of the correct path that begins with: /intranet-tmpl/prog/img/itemtypeimg So, instead of fetching the corresponding item type icon you get a 404 in your web server logs and the default 'broken image URL' image in your web browser. I will attach a couple of screenshots to demonstrate the problem. `git bisect` tells me that the relevant commit is d4855131e3b8e5852f221182ed9588f4ddc67368 from Bug 29660. [*] Please note: the bug outlined above occurs on Debian package installations. Koha instances created using koha-testing-docker or the Koha Sandboxes seem to be unaffected. I believe this has to do with the values of the <intrahtdocs> and <opachtdocs> settings in koha-conf.xml, and the fact that Gitified instances served by Apache use the same DocumentRoot path in their VirtualHost directives for both the OPAC and the Staff interface. However, when trying to reproduce this bug on Koha instances created with methods other than a Debian package install, you can still observe that the item type icon URL is wrong by right-clicking on the icon and selecting 'Inspect' to see its properties. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 --- Comment #1 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 146389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146389&action=edit When trying to place a hold, no item type icon is displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 --- Comment #2 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 146390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146390&action=edit When trying to place a hold, the item type icon is displayed correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24121, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32908 URL| |reserve/request.pl --- Comment #3 from Andreas Roussos <a.roussos@dataly.gr> --- Steps to reproduce: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon Then, visit the bibliographic record's details page in the Staff interface. Select 'Holds' on the left hand side, then pick a patron. The "Place a hold on ..." page should load. In the 'Item type' column of the table at the bottom of the screen notice that instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser. [If you try the above in a Dockerised Koha instance the icon will -most likely- be displayed just fine. However, you can still verify that it's being loaded from the wrong path by right-clicking on the icon and selecting 'Inspect'.] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |a.roussos@dataly.gr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 --- Comment #4 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 146391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146391&action=edit Bug 32909: Load item type icons from the correct path When placing an item-level hold in the Staff interface, the table at the bottom of the screen (under the "Place a hold on a specific item" heading) should display the icon associated with the item type of each item in the 'Item type' column. This feature broke in v22.05.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser. This patch fixes that. Test plan: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon 4) Visit the bibliographic record's details page in the Staff interface. Select 'Holds' on the left hand side, then pick a patron. The "Place a hold on ..." page should load. In the 'Item type' column of the table at the bottom of the screen notice that instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*] [*] In non-Debian package installs, the 'href' property of the item type icon's <img> tag should start with '/opac-tmpl/bootstrap/itemtypeimg' 5) Apply this patch, restart Plack and refresh the page. The item type icon should now be displayed correctly. KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect': the 'href' property of the <img> tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 --- Comment #5 from Andreas Roussos <a.roussos@dataly.gr> --- I just wanted to point out that this bug is similar to the one George reported in Bug 32908, but actually has a different scope as it occurs when trying to place a hold. It also affects a wider range of Koha versions (v22.05.00 onwards) and has a test plan that's slightly different. Which is why I decided to submit a separate bug report and not a follow-up patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Signed Off --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Andreas Roussos from comment #4)
Created attachment 146391 [details] [review] Bug 32909: Load item type icons from the correct path
When placing an item-level hold in the Staff interface, the table at the bottom of the screen (under the "Place a hold on a specific item" heading) should display the icon associated with the item type of each item in the 'Item type' column.
This feature broke in v22.05.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser.
This patch fixes that.
Test plan:
1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show'
2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon
3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon
4) Visit the bibliographic record's details page in the Staff interface. Select 'Holds' on the left hand side, then pick a patron. The "Place a hold on ..." page should load. In the 'Item type' column of the table at the bottom of the screen notice that instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*]
[*] In non-Debian package installs, the 'href' property of the item type icon's <img> tag should start with '/opac-tmpl/bootstrap/itemtypeimg'
5) Apply this patch, restart Plack and refresh the page. The item type icon should now be displayed correctly.
KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect': the 'href' property of the <img> tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg'
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146391|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146494&action=edit Bug 32909: Load item type icons from the correct path When placing an item-level hold in the Staff interface, the table at the bottom of the screen (under the "Place a hold on a specific item" heading) should display the icon associated with the item type of each item in the 'Item type' column. This feature broke in v22.05.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser. This patch fixes that. Test plan: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon 4) Visit the bibliographic record's details page in the Staff interface. Select 'Holds' on the left hand side, then pick a patron. The "Place a hold on ..." page should load. In the 'Item type' column of the table at the bottom of the screen notice that instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*] [*] In non-Debian package installs, the 'href' property of the item type icon's <img> tag should start with '/opac-tmpl/bootstrap/itemtypeimg' 5) Apply this patch, restart Plack and refresh the page. The item type icon should now be displayed correctly. KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect': the 'href' property of the <img> tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All working, No qa script issues.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.11 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.03,22.05.11 |23.05.00,22.11.03,22.05.11, released in| |21.11.19 CC| |arthur.suzuki@biblibre.com --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #13 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org