[Bug 22693] New: ILL "Price paid" column does not appear in column configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Bug ID: 22693 Summary: ILL "Price paid" column does not appear in column configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com Target Milestone: --- "Price paid" was added in bug 22121, it seems I forgot to add it to the column configuration list. Doh. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22121 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121 [Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie --- Comment #1 from Holly <hc@interleaf.ie> --- Just adding a comment to express that there is interest in seeing this feature added. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Patrick <pm@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pm@interleaf.ie --- Comment #2 from Patrick <pm@interleaf.ie> --- The 'Price Paid' field should be viewable and exportable (i.e. included in the output from the export function) in the ILL Requests screen. This is the functionality of the other columns in the table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #3 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Created attachment 145137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145137&action=edit Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@ptfs-europe.com Assignee|koha-bugs@lists.koha-commun |jacob.omara@ptfs-europe.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145137|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 145138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145138&action=edit Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This adds the "Price paid" release notes| |column to the inter-library | |loan requests table. This | |column is also configurable | |using the Columns button | |and in the table settings | |(Administration > | |Additional parameters > | |Table settings > | |Interlibrary loans > | |ill-requests). --- Comment #5 from David Nind <david@davidnind.com> --- Hi Jacob. One minor thing that needs fixing - the column title should be in sentence case, so "Price paid" instead of "Price Paid". I've also added a draft release note. David Testing notes (using KTD): 1. I enabled the FreeForm backend using the instructions at https://wiki.koha-community.org/wiki/ILL_backends -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145138|0 |1 is obsolete| | --- Comment #6 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Created attachment 145139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145139&action=edit Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145139|0 |1 is obsolete| | --- Comment #7 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Created attachment 145140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145140&action=edit Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #8 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Hi David, Thanks for the above, casing has been amended on the column and the commit has been reattached. Jacob -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just filed a bug about the missing price formatting - it might apply to this column as well (maybe a new bug?) Bug 32595 - Price format cost in ILL requests table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #10 from David Nind <david@davidnind.com> --- (In reply to Jacob O'Mara from comment #8)
Hi David,
Thanks for the above, casing has been amended on the column and the commit has been reattached.
Jacob
Thanks Jacob! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #11 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #9)
I just filed a bug about the missing price formatting - it might apply to this column as well (maybe a new bug?) Bug 32595 - Price format cost in ILL requests table
Can confirm that the formatting of the price paid doesn't change for any of the PriceFormat system preference options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, bug 22121 which this bug depends upon appears to claim it fixes the price formatting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. I take that back.. the code has completely changed since bug 22121 as far as I can tell. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I don't think we should hold this bug up with the formatting issue.. that should go into your formatting bug Katrin and we should expand your bug to catch all prices in the table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #14)
I don't think we should hold this bug up with the formatting issue.. that should go into your formatting bug Katrin and we should expand your bug to catch all prices in the table.
Sounds good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145140|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146527&action=edit Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Added David's sign-off line since he was the one who switched to sign-off. Thanks Jakob! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 --- Comment #19 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.11 released in| | --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.03,22.05.11 |23.05.00,22.11.03,22.05.11, released in| |21.11.19 CC| |arthur.suzuki@biblibre.com --- Comment #21 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #22 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org