[Bug 14997] New: Remove C4::Dates from tools (import / export)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Bug ID: 14997 Summary: Remove C4::Dates from tools (import / export) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org This patch removes C4::Dates from: - tools/export.pl - tools/import_borrowers.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 43315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43315&action=edit Bug 14997 - Remove C4::Dates from tools (import / export) This patch removes C4::Dates from: - tools/export.pl - tools/import_borrowers.pl Note: For testing, both need preparation without patch, see below. To test export: - Without patch applied, go to Home > Tools > Export data > Export bibliographic records - Define Start date / End date for Accession dates - Export bibliographic records as 'without-patch.mrc' - Do the same with patch, export as 'with-patch.mrc - Compare the files, they should be the same To test Import patrons: - Without patch - Go to Home > Tools > Import patrons - Create a patron categorie like 'TEST' (usful for filtering...) - Prepare a file with some patrons with category TEST to import. Fill date of birth, enrolment date, expiry date with values formatted in syspref format, in iso format and garbage - Import - Review the imported patrons (search for category TEST) - With patch: Change cardnumber and names in import file - Import - Review again and compare with results from previous import. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14870 Assignee|gmcharlt@gmail.com |veron@veron.ch Status|NEW |Needs Signoff Patch complexity|--- |Small patch Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 --- Comment #2 from Marc Véron <veron@veron.ch> --- Still appplies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43315|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 43856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43856&action=edit Bug 14997 - Remove C4::Dates from tools (import / export) This patch removes C4::Dates from: - tools/export.pl - tools/import_borrowers.pl Note: For testing, both need preparation without patch, see below. To test export: - Without patch applied, go to Home > Tools > Export data > Export bibliographic records - Define Start date / End date for Accession dates - Export bibliographic records as 'without-patch.mrc' - Do the same with patch, export as 'with-patch.mrc - Compare the files, they should be the same To test Import patrons: - Without patch - Go to Home > Tools > Import patrons - Create a patron categorie like 'TEST' (usful for filtering...) - Prepare a file with some patrons with category TEST to import. Fill date of birth, enrolment date, expiry date with values formatted in syspref format, in iso format and garbage - Import - Review the imported patrons (search for category TEST) - With patch: Change cardnumber and names in import file - Import - Review again and compare with results from previous import. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Status|Needs Signoff |Signed Off --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Exported MARC data was the same with and without patch. Borrower import without patch (mis)calculated dates in wrong format, like 2010-30-12 in yyy-mm-dd becoming 2012-06-15. After the patch, default values were used instead. Data in correct format was imported as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43856|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43937&action=edit [PASSED QA] Bug 14997 - Remove C4::Dates from tools (import / export) This patch removes C4::Dates from: - tools/export.pl - tools/import_borrowers.pl Note: For testing, both need preparation without patch, see below. To test export: - Without patch applied, go to Home > Tools > Export data > Export bibliographic records - Define Start date / End date for Accession dates - Export bibliographic records as 'without-patch.mrc' - Do the same with patch, export as 'with-patch.mrc - Compare the files, they should be the same To test Import patrons: - Without patch - Go to Home > Tools > Import patrons - Create a patron category like 'TEST' (useful for filtering...) - Prepare a file with some patrons with category TEST to import. Fill date of birth, enrolment date, expiry date with values formatted in syspref format, in iso format and garbage - Import - Review the imported patrons (search for category TEST) - With patch: Change cardnumber and names in import file - Import - Review again and compare with results from previous import. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org