http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored --- Comment #2 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ). The new field is in the Add a new subscription page of the serials, above the Library field. The patch was based on 3.8.3. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #4)

QA comments:

Hi Maxime,

1/+ `seriallifespan` TINYINT(1) DEFAULT -1 You cannot store '10' into a TINYINT(1)

2/ 3 loops can be created to avoid a list of 10 lines: [% FOREACH i IN [ 2 .. 10 ] %] <option value="[% i %]" [% IF ( seriallifespan == [% i %] ) %]selected="selected"[% END %]>[% i %] years</option> [% END %]

Furthermore you cannot write this line :-/ (see Bug 8407)

And: [% IF seriallifespan == -1 %] <span>Immortal</span> [% ELSIF ( seriallifespan == 1 ) %] <span>1 year</span> [% ELSIF ( seriallifespan >= 10 ) %] [% FOREACH i IN [ 2 .. 10 ] %] <span>[% seriallifespan %] years</span> [% END %] [% END %]

Something like that, I didn't test.

3/ Fonctionnaly what is the goal of this field? Indeed, you don't use this field, just store and display.

Failed QA for 1 and 2

I think its just 2, tt inside a tag that is a problem, tinyint(1) is 0 - 255 unsigned and -128 to 127 signed. select seriallifespan from subscription; +----------------+ | seriallifespan | +----------------+ | 10 | +----------------+ (I tested that when signing off) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #7 from Maxime Pelletier <pelletiermaxime@gmail.com> --- (In reply to comment #4)

QA comments:

Hi Maxime,

2/ 3 loops can be created to avoid a list of 10 lines: [% FOREACH i IN [ 2 .. 10 ] %] <option value="[% i %]" [% IF ( seriallifespan == [% i %] ) %]selected="selected"[% END %]>[% i %] years</option> [% END %]

Furthermore you cannot write this line :-/ (see Bug 8407)

And: [% IF seriallifespan == -1 %] <span>Immortal</span> [% ELSIF ( seriallifespan == 1 ) %] <span>1 year</span> [% ELSIF ( seriallifespan >= 10 ) %] [% FOREACH i IN [ 2 .. 10 ] %] <span>[% seriallifespan %] years</span> [% END %] [% END %]

Something like that, I didn't test.

I have to disagree on this. I don't think hardcoding the number and just translating the word year/years is the right way to go. I'm sure there's a language out there where the number is after or something like that. Id rather have 10 lines than an if/elseif/else. I don't understand bug 8407. Maybe translation for [IF] inside options is broken inside loops, but it's working for me in this patch. In french I have : <option value="-1" [% IF ( seriallifespan == -1 ) %]selected="selected"[% END %]>Immortel</option>. Anyway that doesn't mather because :

3/ Fonctionnaly what is the goal of this field? Indeed, you don't use this field, just store and display.

Good question. We use it with a saved sql report here attached. Anyway I wasn't really expecting this to be accepted. I think i'm fine leaving it here as Failed QA and to be an option if something needs it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #7)

I have to disagree on this. I don't think hardcoding the number and just translating the word year/years is the right way to go. I'm sure there's a language out there where the number is after or something like that.

I think it is possible to do that when you translate your po file.

I don't understand bug 8407. Maybe translation for [IF] inside options is broken inside loops, but it's working for me in this patch.

Yes, it works :) But the problem is the script xt/tt_valid.t does not accept this syntax. Then the test fails.

...

3/ Fonctionnaly what is the goal of this field? Indeed, you don't use this field, just store and display.

Good question. We use it with a saved sql report here attached. Anyway I wasn't really expecting this to be accepted. I think i'm fine leaving it here as Failed QA and to be an option if something needs it.

humm... ok :) But if this development is useful for some people it is a good idea to include it into Koha. Chris, what do you think about this development ? Do you think we want it ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #11 from Colin Campbell <colin.campbell@ptfs-europe.com> --- A suggestion: in English would not 'Permanent' be better terminology than 'Immortal'? Immortal intimates divinity, not a quality often associated with serials, (Infernal might be many peoples view!) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11513|0 |1 is obsolete| | --- Comment #13 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Created attachment 17600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17600&action=edit New patch that should apply in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17600|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19415&action=edit Bug 8587 - Add a serial lifespan field to serial subscriptions http://bugs.koha-community.org/show_bug.cgi?id=8587 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pelletiermaxime@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-29 00:00:00 |2013-10-25 last check this| | --- Comment #17 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@univ-lyon3.fr --- Comment #18 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 8587: <h1>Something went wrong !</h1>Applying: Bug 8587 - Add a serial lifespan field to serial subscriptions Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Serials.pm CONFLICT (content): Merge conflict in C4/Serials.pm Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Auto-merging serials/subscription-add.pl CONFLICT (content): Merge conflict in serials/subscription-add.pl Auto-merging serials/subscription-detail.pl Failed to merge in the changes. Patch failed at 0001 Bug 8587 - Add a serial lifespan field to serial subscriptions When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 8587 - Add a serial lifespan to serial subscriptions 19415 - Bug 8587 - Add a serial lifespan field to serial subscriptions 19416 - Bug 8587 - Add a serial lifespan to serial subscriptions - Followup - Change seriallifespan to serial_lifespan for readability Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-8587---Add-a-serial-lifespan-field-to-serial-s-TRyUC2.patch . -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19415|0 |1 is obsolete| | --- Comment #19 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30636&action=edit Bug 8587 - Add a serial lifespan field to serial subscriptions http://bugs.koha-community.org/show_bug.cgi?id=8587 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.beaulieu@inlibro.com --- Comment #21 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- I have fixed merge conflicts. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some notes and suggestions: 1) (blocker) There is a merge marker left in and the patch seems to add a bit too much code in serials/subscription-detail.tt - please remove and check. 2) (trivial) Please add the bug number to the database update. 3) Suggestion: Why limit to 10 years? I think translation would work with a variable: <span>[% serial_lifespan %] years</span>. That should give the translators something like: %s years where the sequence can be changed. 4) Suggestion: It think it would be nice to include a change to the help file or a patch to the manual (separately) where it's explained that this field is not tied to any functionality, but for use in reports. We already have a subscription end date and a subscription length, so this could cause a bit of confusion. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #23 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30953&action=edit Bug 8587 - Follow-up to Comment 22 1) Removed all useless code. 2) Bug number added in updatadatabase.pl . 3) I've reworked the input form. There is now a select box with 'Permanent' and 'Years' as values. A number input field appears when 'Years' is selected. Range is from 1 to n years. 4) Help message added in the intranet help. modified: installer/data/mysql/updatedatabase.pl modified: koha-tmpl/intranet-tmpl/prog/en/modules/help/serials/subscription-add.tt modified: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt modified: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30636|0 |1 is obsolete| | Attachment #30637|0 |1 is obsolete| | Attachment #30953|0 |1 is obsolete| | --- Comment #24 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 41217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41217&action=edit Bug 8587 - Add a serial lifespan field to serial subscriptions Adds a serial lifespan field to serial subscriptions. Allows a serial subscription to be considered "out of date" after the chosen time period. This version should now be both cleanly applicable and properly working. Test plan: 1) Apply patch 2) Run ./installer/data/mysql/updatedatabase.pl 3) Create subscription using the field "Serial lifespan" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, we have a new feature now that will allow to add new fields to subscriptions - I wonder if this development is still needed or could be covered by the new feature. I just tested it by defining a new field 'serial lifespan'. It shows on the subscription details and on the edit form. -- You are receiving this mail because: You are watching all bug changes.