[Bug 12517] New: Download and send list popups broken in bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Bug ID: 12517 Summary: Download and send list popups broken in bootstrap OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org In the bootstrap OPAC the download list and send list links do not trigger the correct popups because of a JavaScript error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29437&action=edit Bug 12517 - Download and send list popups broken in bootstrap OPAC A JavaScript error prevents the download list and send list links in the bootstrap OPAC from functioning correctly. A variable declaration was removed from basket.js during the creation of the theme but opac-shelves.tt was not changed accordingly. This patch corrects it. To test, view an existing shelf in the bootstrap OPAC and test the "download list" and "send list" links. They should each trigger popups without any errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29437|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29443&action=edit [SIGNED-OFF] Bug 12517 - Download and send list popups broken in bootstrap OPAC A JavaScript error prevents the download list and send list links in the bootstrap OPAC from functioning correctly. A variable declaration was removed from basket.js during the creation of the theme but opac-shelves.tt was not changed accordingly. This patch corrects it. To test, view an existing shelf in the bootstrap OPAC and test the "download list" and "send list" links. They should each trigger popups without any errors. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Popups pops again, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29481&action=edit [PASSED QA] Bug 12517 - Download and send list popups broken in bootstrap OPAC A JavaScript error prevents the download list and send list links in the bootstrap OPAC from functioning correctly. A variable declaration was removed from basket.js during the creation of the theme but opac-shelves.tt was not changed accordingly. This patch corrects it. To test, view an existing shelf in the bootstrap OPAC and test the "download list" and "send list" links. They should each trigger popups without any errors. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Popups pops again, no koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29443|0 |1 is obsolete| | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org