[Bug 22752] New: Show next available or item specific hold types in opac-user.pl#opac-user-holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Bug ID: 22752 Summary: Show next available or item specific hold types in opac-user.pl#opac-user-holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- When a patron is viewing the holds they've placed in opac-user.pl#opac-user-holds, it does not show the user if they have requested a specific item or the next available item. The patron should be given the ability to see this information, in case they incorrectly placed a hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Hold requests |OPAC Version|unspecified |master Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de Summary|Show next available or item |Show if a placed hold is |specific hold types in |record or item level in the |opac-user.pl#opac-user-hold |patron account in the OPAC |s | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Victoria Faafia <vfaafia29@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |vfaafia29@gmail.com Status|NEW |ASSIGNED CC| |vfaafia29@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Victoria Faafia <vfaafia29@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 --- Comment #1 from Victoria Faafia <vfaafia29@gmail.com> --- Created attachment 115294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115294&action=edit Bug 22752: Show if a placed hold is a record or item level in the patron account in the OPAC Test Plan 1. Have a record with an item 2. You will need to set a hold through staff account (to import books Cataloging>New from Z39.50/SRU> 3. Keyword(enter any keyword e.g pokemon) 4. tick library of congress 5. choose a title and click actions then import 6. 003 should be OSt 7. tab 9 koha item type can be books or whatever and press save 8. select the hold and place hold 9. on Koha OPAC click on your account and go to the holds and underneath the title it should say Only item and the barcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115294|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 115302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115302&action=edit Bug 22752: Show if a placed hold is a record or item level in the patron account in the OPAC Test Plan 1. Have a record with an item 2. You will need to set a hold through staff account (to import books Cataloging>New from Z39.50/SRU> 3. Keyword(enter any keyword e.g pokemon) 4. tick library of congress 5. choose a title and click actions then import 6. 003 should be OSt 7. tab 9 koha item type can be books or whatever and press save 8. select the hold and place hold 9. on Koha OPAC click on your account and go to the holds and underneath the title it should say Only item and the barcode Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes: - Worked as expected, I tested placing next available item and specific item holds - Works fine without needing to add a new record and item (it worked fine with existing example records and items) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115302|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115526&action=edit Bug 22752: Show if a placed hold is a record or item level in the patron account in the OPAC Test Plan 1. Have a record with an item 2. You will need to set a hold through staff account (to import books Cataloging>New from Z39.50/SRU> 3. Keyword(enter any keyword e.g pokemon) 4. tick library of congress 5. choose a title and click actions then import 6. 003 should be OSt 7. tab 9 koha item type can be books or whatever and press save 8. select the hold and place hold 9. on Koha OPAC click on your account and go to the holds and underneath the title it should say Only item and the barcode Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115527&action=edit Bug 22752: (QA follow-up) Add missing filters For security, we filter all template variables. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Victoria, I've added a minor follow-up to coax this through QA (https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_Filter_all_tem...), but otherwise this looks great. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's placed to close to the author in my opinion: https://snipboard.io/utPVk4.jpg Maybe we should add a new line? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115558&action=edit Bug 22752: (follow-up) Add style; Only show message about item-level holds I think it's generally assumed that a hold has, by default, been made at the bibliographic level. I think it's sufficent to add a note for only item-level holds. To test, apply the patch and log into the OPAC as a user who has multiple holds, some at the bibliographic level and some at the item level. - Go to Your summary --> Holds - Confirm that any item-level hold has a note under the title: "Item on hold <barcode>". - The note should be on a new line and styled differently than the other text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- My follow-up goes further than just adding some style. I can submit a less-opinionated patch if folks prefer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://snipboard.io/D6JH5R.jpg Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement to the release notes| |OPAC shows a logged in | |patron what item a hold was | |placed on, for item-level | |holds ("Item on hold: | |<barcode>" is added after | |the title). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show if a placed hold is |Show item-level hold |record or item level in the |details for patrons when |patron account in the OPAC |logged into their account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 --- Comment #12 from David Nind <david@davidnind.com> --- Updated the bug title to reflect the actual changes made, and added suggested text for the release notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Should we backport to 20.11.x ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org