[Bug 19116] New: Holds not set to waiting when "Confirm" is used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Bug ID: 19116 Summary: Holds not set to waiting when "Confirm" is used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When a hold with status transfer is checked in, we offer "Confirm" and "Print and confirm", both should set the item to waiting and create a pick-up letter if set up. But only the second option has this effect. To test: - Place holds on 2 items from another branch - Switch to that branch - Check them in at the other branch to set them into transport status (T) - Switch back to your homebranch - Check items in again, use the different confirm buttons and compare - Only "confirm and print" will be set to waiting, "confirm" remains in transport. Might be related to bug 19020. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19020 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Hm, same issue was fixed in 17940, but it is here again... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18438 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- And it is caused by bug 18438... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 [Bug 18438] Check in: Modal about holds hides important check in messages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- So we have to options - in hidden.bs.modal handler call some api to mark the hold waiting, which means to extend api first, svc nor rest don't support it or to get somehow the showed messages and and pass them to returns.pl too - because we don't won't the regression on 18438 funcionality I think... any opinions? Other solution? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you explain a bit about the dependency to the other bug? Just a bit confused because for me it looks like one button works, the other does not... so why not make one behave like the other (missing the deeper understanding here clearly :) ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Retested, had totally forgotten we switched to a modal there. Read through the other bug too, but not totally understanding the problem yet. What is strange: if the item is not from a transfer, the button seems to work correctly? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17940 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Found a fixed bug that reads similarly: bug 17940 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on|18438 | Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Katrin Fischer from comment #5)
Retested, had totally forgotten we switched to a modal there. Read through the other bug too, but not totally understanding the problem yet.
What is strange: if the item is not from a transfer, the button seems to work correctly?
Bug 18438 does make modal dissmiss without reloading whole page, but when the item is not transferred, the page normaly reloads and the the hold is marked waiting. These are two different modals in returns.tt: #hold-found1 - if the hold is already waiting - just dismissing the modal is OK, the hold is already marked waiting #hold-found2 - hold found, need to be marked waiting - the modal does not dismiss when confirm button clicked, but the form is confirmed and page reloads and mark the hold waiting. This modal is dismissed when ignore button is clicked - so hold is not marked as waiting When hold found and need transfer the #hold-found2 modal is used (just with other modal-footer because different button labels) When the hold is transferred the #hold-found1 is used, but should not, the hold is not waiting yet! The Waiting or Reserved status comes originally from C4::Reserves::CheckReserves, the 'T' status is considered waiting here - which is not true I tried to fix it, patch is comming I remove dependency on 18438 - it does not come from here, patch from bug 18438 just highlighted the problem Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 [Bug 18438] Check in: Modal about holds hides important check in messages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 66307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66307&action=edit Bug 19116: Hold not set to waiting after transfer Test plan: 0) Do not apply the patch 1) Place hold on item from another branch 2) Switch to that branch 3) Check them in at the other branch to set them into transport status (T) 4) Switch back to your homebranch 5) Check items in again, use the different confirm buttons and compare: Only "confirm and print" will be set to waiting, "confirm" remains in transport. 6) Apply the patch 7) Repeat 1-5 - now should work as expected - the hold is marked waiting on "confirm" button too 8) Check the hold from the same branch, to make sure this doesn't add regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Testing now - I think we might need a unit test for QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66307|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66511&action=edit Bug 19116: Hold not set to waiting after transfer Test plan: 0) Do not apply the patch 1) Place hold on item from another branch 2) Switch to that branch 3) Check them in at the other branch to set them into transport status (T) 4) Switch back to your homebranch 5) Check items in again, use the different confirm buttons and compare: Only "confirm and print" will be set to waiting, "confirm" remains in transport. 6) Apply the patch 7) Repeat 1-5 - now should work as expected - the hold is marked waiting on "confirm" button too 8) Check the hold from the same branch, to make sure this doesn't add regression Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx a lot, Josef! Works perfectly! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would suggest to invert the condition: If found eq 'T' then return "Reserved" Otherwise return "Waiting" We will need tests indeed. I have to admit that this subroutine (CheckReserves) always scared me, hard to say we are not going to break something. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Failed QA --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Can we have tests for this one please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can someone help out here and write the tests necessary please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66824&action=edit Bug 19116: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not recreate the issue with tests, someone else? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If I am reading the test correctly, you miss returning in the library the item is 'sourced at' in order to create the transport status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The problem is that the item is not in transit, but I haven't figured out how to fix the tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- is( $hold->found, "T", 'Hold is in transit' ); before you return it again at the pickup library. No matter what I try, I only get 'undef'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66824|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66947&action=edit Bug 19116: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Another try, the tests still pass with and without the fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #2)
And it is caused by bug 18438...
If this is caused by template changes, why do we need to fix it at package level? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 19273 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a template level fix/patch from Kyle on the linked bug 19273 - not sure what makes more sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #22)
(In reply to Josef Moravec from comment #2)
And it is caused by bug 18438...
If this is caused by template changes, why do we need to fix it at package level?
Which is why I'd suggest my fix on bug 19273 which is a one line template change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #26 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Kyle M Hall from comment #25)
(In reply to Jonathan Druart from comment #22)
(In reply to Josef Moravec from comment #2)
And it is caused by bug 18438...
If this is caused by template changes, why do we need to fix it at package level?
My fault, it is not caused by bug 18438, this bug just highlited the problem.
Which is why I'd suggest my fix on bug 19273 which is a one line template change.
The patch on bug 19273 just reverts the functionality provided by bug 18438... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- So better to fix the tests on this bug then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66511|0 |1 is obsolete| | Attachment #66947|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67079&action=edit Bug 19116: Hold not set to waiting after transfer Test plan: 0) Do not apply the patch 1) Place hold on item from another branch 2) Switch to that branch 3) Check them in at the other branch to set them into transport status (T) 4) Switch back to your homebranch 5) Check items in again, use the different confirm buttons and compare: Only "confirm and print" will be set to waiting, "confirm" remains in transport. 6) Apply the patch 7) Repeat 1-5 - now should work as expected - the hold is marked waiting on "confirm" button too 8) Check the hold from the same branch, to make sure this doesn't add regression Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67080&action=edit Bug 19116: Add tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #27)
So better to fix the tests on this bug then?
Katrin, I ran the unit tests on multiple data sets and they passed every time for me. I'm not willing to Pass QA without your approval though ; ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #30)
(In reply to Katrin Fischer from comment #27)
So better to fix the tests on this bug then?
Katrin, I ran the unit tests on multiple data sets and they passed every time for me. I'm not willing to Pass QA without your approval though ; )
The tests do not highlight the problem, they pass with and without the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #31)
(In reply to Kyle M Hall from comment #30)
(In reply to Katrin Fischer from comment #27)
So better to fix the tests on this bug then?
Katrin, I ran the unit tests on multiple data sets and they passed every time for me. I'm not willing to Pass QA without your approval though ; )
The tests do not highlight the problem, they pass with and without the patch.
Ah, thanks for the clarity. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67079|0 |1 is obsolete| | --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 67306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67306&action=edit Bug 19116: Hold not set to waiting after transfer Test plan: 0) Do not apply the patch 1) Place hold on item from another branch 2) Switch to that branch 3) Check them in at the other branch to set them into transport status (T) 4) Switch back to your homebranch 5) Check items in again, use the different confirm buttons and compare: Only "confirm and print" will be set to waiting, "confirm" remains in transport. 6) Apply the patch 7) Repeat 1-5 - now should work as expected - the hold is marked waiting on "confirm" button too 8) Check the hold from the same branch, to make sure this doesn't add regression Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 67307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67307&action=edit Bug 19116: (followup) Add tests to highlight the problem in CheckReserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67080|0 |1 is obsolete| | Attachment #67306|0 |1 is obsolete| | Attachment #67307|0 |1 is obsolete| | --- Comment #35 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 67308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67308&action=edit Bug 19116: Hold not set to waiting after transfer Test plan: 0) Do not apply the patch 1) Place hold on item from another branch 2) Switch to that branch 3) Check them in at the other branch to set them into transport status (T) 4) Switch back to your homebranch 5) Check items in again, use the different confirm buttons and compare: Only "confirm and print" will be set to waiting, "confirm" remains in transport. 6) Apply the patch 7) Repeat 1-5 - now should work as expected - the hold is marked waiting on "confirm" button too 8) Check the hold from the same branch, to make sure this doesn't add regression Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #36 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 67309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67309&action=edit Bug 19116: Add tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #37 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 67310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67310&action=edit Bug 19116: (followup) Add tests to highlight the problem in CheckReserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m --- Comment #38 from Julian Maurice <julian.maurice@biblibre.com> --- *** Bug 19020 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67309|0 |1 is obsolete| | --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67409&action=edit Bug 19116: Unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67310|0 |1 is obsolete| | --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67410&action=edit Bug 19116: (followup) Add tests to highlight the problem in CheckReserves Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67308|0 |1 is obsolete| | --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67411&action=edit Bug 19116: Hold not set to waiting after transfer Test plan: 0) Do not apply the patch 1) Place hold on item from another branch 2) Switch to that branch 3) Check them in at the other branch to set them into transport status (T) 4) Switch back to your homebranch 5) Check items in again, use the different confirm buttons and compare: Only "confirm and print" will be set to waiting, "confirm" remains in transport. 6) Apply the patch 7) Repeat 1-5 - now should work as expected - the hold is marked waiting on "confirm" button too 8) Check the hold from the same branch, to make sure this doesn't add regression Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am not confident with this patch, I am expecting side-effects. But I do not have anything else to suggest, let's give a try. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Joel Sasse <jsasse@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #44 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. Really dirty bug ;) thanks all for your job. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Depends on| |18438 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 [Bug 18438] Check in: Modal about holds hides important check in messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18438 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 [Bug 18438] Check in: Modal about holds hides important check in messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #46 from David Cook <dcook@prosentient.com.au> --- I'm confused... does this actually work? I see the following code in master: <div class="modal-footer"> <input type="hidden" name="cancel_reserve" value="0" /> <button type="submit" class="btn btn-default approve" data-dismiss="modal"> <i class="fa fa-check"></i> Confirm </button> <input type="hidden" name="print_slip" value="0" /> <button type="submit" class="btn btn-default print" onclick="this.form.print_slip.value = 1; this.form.submit();"> <i class="fa fa-print"></i> Print and confirm </button> <button type="submit" class="btn btn-default deny" onclick="this.form.cancel_reserve.value = 1; this.form.submit();"> <i class="fa fa-times"></i> Cancel hold </button> </div> "Print and confirm" and "Cancel hold" both work in the 17.05.03 but "Confirm" doesn't. If I add onclick="this.form.submit();" to the Confirm button, then it works. As per Kyle's patch on #19273, I think the problem is due to that data-dismiss attribute? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #47 from David Cook <dcook@prosentient.com.au> --- Especially when I don't see a data-dismiss attribute on any other button on that page. If you're not transferring, then this is what the code looks like: <button type="submit" class="btn btn-default approve"> <i class="fa fa-check"></i> Confirm hold </button> <button type="submit" class="btn btn-default print" onclick="this.form.print_slip.value = 1; this.form.submit();"> <i class="fa fa-print"></i> Print slip and confirm </button> So I think the answer is probably what Kyle did on the other bug report? Although I admit I haven't tested the current stable code or master... this is just analysis based on an older version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org