[Bug 42641] New: JavaScript errors on patron attribute types admin page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 Bug ID: 42641 Summary: JavaScript errors on patron attribute types admin page Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com There are some JS problems on the patron attribute types administration page which result in DataTables being broken on the page listing all attributes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |41067 Patch complexity|--- |Small patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41067 [Bug 41067] 'OPAC mandatory' attribute setting requires 'Editable in OPAC' to work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199289&action=edit Bug 42641: JavaScript errors on patron attribute types admin page This patch fixes some JavaScript errors on the patron attributes page. Vanilla JS doesn't automatically handle null variables like jQuery does. To test, apply the patch and go to Administration -> Patron attribute types. - If necessary, add multiple attribute types. - The table listing all attributes should be displayed as DataTable and there should be no errors in the console. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199289|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 199325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199325&action=edit Bug 42641: JavaScript errors on patron attribute types admin page This patch fixes some JavaScript errors on the patron attributes page. Vanilla JS doesn't automatically handle null variables like jQuery does. To test, apply the patch and go to Administration -> Patron attribute types. - If necessary, add multiple attribute types. - The table listing all attributes should be displayed as DataTable and there should be no errors in the console. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the "Patron release notes| |attribute types" page | |(Administration > Patrons | |and circulation > Patron | |attribute types). The | |standard table was not | |showing correctly because | |of JavaScript errors. The | |table was not showing the | |standard navigation and | |other table elements: | | . "Showing X to X of X | |entries" (above and below | |the table) | | . Search filter | | . Export options | | . Sorting controls for | |the columns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199325|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200477&action=edit Bug 42641: JavaScript errors on patron attribute types admin page This patch fixes some JavaScript errors on the patron attributes page. Vanilla JS doesn't automatically handle null variables like jQuery does. To test, apply the patch and go to Administration -> Patron attribute types. - If necessary, add multiple attribute types. - The table listing all attributes should be displayed as DataTable and there should be no errors in the console. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 --- Comment #4 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42641 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.02 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org