[Bug 42202] New: IndependentBranches shouldn't filter public branches in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 Bug ID: 42202 Summary: IndependentBranches shouldn't filter public branches in OPAC Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org There are a few places in the OPAC where we use the following: [% SET AllPublicBranches = Branches.all( search_params => { public => 1 }, selected => opac_name ) %] For instance, in the masthead library pulldown in the search bar, and the library dropdown in Advanced Search. However, IndependentBranches will make it so that only the logged in user's branch is retrieved, so the pull down disappears for non-superlibrarians in this scenario. This really makes no sense, since an unauthenticated user can see all the branches. Plus, the logged in user can do a search and then filter by any library. So... I reckon we should add "unfiltered => 1" for cases like masthead.inc and opac-advsearch.tt. I'll check the others to see if they should or shouldn't be filtered... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I suppose there is a use case where OpacPublic is disabled so all OPAC users are authenticated... although that seems a bit unlikely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #1)
I suppose there is a use case where OpacPublic is disabled so all OPAC users are authenticated... although that seems a bit unlikely.
Also, the opac-library.pl page would still list all the libraries... although that could be a different bug I suppose. Or maybe not considered a bug since it's just contact info. But then in the search results it will show all the different Holding libraries anyway. What do other people think of this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt and koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt are interesting as these are used for logged in users typically... and even if AnonSuggestions is on then that makes sense in a different context... So yeah I'll leave those alone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|IndependentBranches |IndependentBranches |shouldn't filter public |shouldn't filter public |branches in OPAC |branches in OPAC search, | |news, and most popular -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 196530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196530&action=edit Bug 42202: Unfilter branches for OPAC search, news, and most popular This change unfilters the branches for OPAC search, news, and most popular. This is most noticeable when using the IndependentBranches system preference. This change aligns the UX for both logged in and not logged in users __SETUP__ - Do not apply the patch yet - Log into Koha - Go to Administration > System preferences - Search for OpacAddMastheadLibraryPulldown system preference - Change it to "Add" and save the preference - Search for IndependentBranches system preference - Set it to "Yes" and save the preference - Search for OpacTopissue system preference - Set it to "Allow" and save the preference - Search for OpacNewsLibrarySelect system preference - Set it to "Show" and save the preference - Go to Patrons - Create or modify a patron with a username/password but no superlibrarian permission __TESTS__ - Go to the OPAC (and logout if you're already logged in) - Note that the library pull down saying "All libraries" is present in the masthead - Log in as your unprivileged user - Note that the library pull down saying "All libraries" is now hidden - Go to Advanced search and note there's no "Location and availability" option - Go to "Most popular" and note there's no "From:" library filter - Go to the home page and note it does not show a library selector for news - Apply the patch - Refresh the page - Note that the library pull down saying "All libraries" is present in the masthead - Note that the "From:" library filter now appears - Go to Advanced search and note "Location and availability" now appears - Go to the home page and note it now shows a library selector for news -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Asking for feedback in the Libraries MM channel as I haven't heard back from any developers on the Development MM channel. Plus, I think librarians/libraries will provide more useful feedback on this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- A bit surprised that I haven't gotten any feedback on this one. I'm thinking I'll try to cover that use case from Comment 1 as well... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196530|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 197819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197819&action=edit Bug 42202: Unfilter branches for OPAC search, news, and most popular This change unfilters the branches for OPAC search, news, and most popular. This is most noticeable when using the IndependentBranches system preference. This change aligns the UX for both logged in and not logged in users __SETUP__ - Do not apply the patch yet - Log into Koha - Go to Administration > System preferences - Search for OpacAddMastheadLibraryPulldown system preference - Change it to "Add" and save the preference - Search for IndependentBranches system preference - Set it to "Yes" and save the preference - Search for OpacTopissue system preference - Set it to "Allow" and save the preference - Search for OpacNewsLibrarySelect system preference - Set it to "Show" and save the preference - Go to Patrons - Create or modify a patron with a username/password but no superlibrarian permission __TESTS__ - Go to the OPAC (and logout if you're already logged in) - Note that the library pull down saying "All libraries" is present in the masthead - Log in as your unprivileged user - Note that the library pull down saying "All libraries" is now hidden - Go to Advanced search and note there's no "Location and availability" option - Go to "Most popular" and note there's no "From:" library filter - Go to the home page and note it does not show a library selector for news - Apply the patch - Refresh the page - Note that the library pull down saying "All libraries" is present in the masthead - Note that the "From:" library filter now appears - Go to Advanced search and note "Location and availability" now appears - Go to the home page and note it now shows a library selector for news Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the OPAC library release notes| |location filtering for | |logged in patrons when | |IndependentBranches is | |used. | | | |Logged in patrons now see | |the same options for | |library locations as | |unauthenticated patrons, | |for example: | |- Library pulldown for "All | |libraries" for the main | |search | |(OpacAddMastheadLibraryPull | |down system preference) | |- Advanced search "Location | |and availability" option | |- Most popular from filter | |(OpacTopissue system | |preference) | |- News selector | |(OpacNewsLibrarySelect | |system preference) | | | |Previously, the library | |location options were not | |shown when a patron was | |logged in. This made no | |sense, as unauthenticated | |user can see all the | |libraries. (A logged in | |patron could also do a | |search and then filter by | |any library location.) CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from David Cook <dcook@prosentient.com.au> --- I'm just not quite happy with this one yet... so going to Failed QA myself. I just worry that without OpacPublic on, it'll break things. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Actually I'm changing my mind. I think this is fine after all. Because even if they're using OpacPublic... they're still going to see the other branches in the search results, so it makes sense to show them in the library pull down, the top issues, the advanced search, and the library news. An argument could maybe be made about library news but I also think use of OpacNewsLibrarySelect is probably rare? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|IndependentBranches |IndependentBranches |shouldn't filter public |shouldn't filter public |branches in OPAC search, |libaries in OPAC search, |news, and most popular |news, and most popular -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | Patch complexity|--- |Trivial patch CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197819|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200474&action=edit Bug 42202: Unfilter branches for OPAC search, news, and most popular This change unfilters the branches for OPAC search, news, and most popular. This is most noticeable when using the IndependentBranches system preference. This change aligns the UX for both logged in and not logged in users __SETUP__ - Do not apply the patch yet - Log into Koha - Go to Administration > System preferences - Search for OpacAddMastheadLibraryPulldown system preference - Change it to "Add" and save the preference - Search for IndependentBranches system preference - Set it to "Yes" and save the preference - Search for OpacTopissue system preference - Set it to "Allow" and save the preference - Search for OpacNewsLibrarySelect system preference - Set it to "Show" and save the preference - Go to Patrons - Create or modify a patron with a username/password but no superlibrarian permission __TESTS__ - Go to the OPAC (and logout if you're already logged in) - Note that the library pull down saying "All libraries" is present in the masthead - Log in as your unprivileged user - Note that the library pull down saying "All libraries" is now hidden - Go to Advanced search and note there's no "Location and availability" option - Go to "Most popular" and note there's no "From:" library filter - Go to the home page and note it does not show a library selector for news - Apply the patch - Refresh the page - Note that the library pull down saying "All libraries" is present in the masthead - Note that the "From:" library filter now appears - Go to Advanced search and note "Location and availability" now appears - Go to the home page and note it now shows a library selector for news Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 --- Comment #11 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42202 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.02 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org