[Bug 18920] New: Some config values are not saved in koha-install-log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920 Bug ID: 18920 Summary: Some config values are not saved in koha-install-log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The koha-config values for DB_USE_TLS and FONT_DIR (for dejavu fonts) are not being saved in koha_install_log so the user is prompted for them when running perl Makefile.PL --prev-install-log ~/etc/koha/misc/koha-install-log they should be written to koha-install-log so that, like other config values they are not prompted for after initially being set -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 64956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64956&action=edit Patch to add missing values to install log To test - without patch applied when running Makefile.PL --prev-install-log /path/to/misc/koha-install-log user will always be prompted for whether db connection uses TLS and the location of DejaVu fonts With patch applied (and assuming the path is /etc/koha/misc substitute as required) run perl Makefile.PL --prev-install-log /etc/koha/misc/koha-install-log prompts for the above values will appear answer as before do a make upgrade rerun perl Makefile.PL -prev-install-log /etc/koha/misc/koha-install-log these variables are now read from the install log and not prompted for inspecting the installed koha-install.log there will now be values for DB_USE_TLS and FONT_DIR - there are also entries for DB_TLS_CA_CERTIFICATE, DB_TLS_CLIENT_CERTIFICATE and DB_TLS_CLIENT_KEY but these will only be set if DB_USE_TLS is set to yes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- NOTE: Untestable in a SYNC_REPO Windows Dev Box, due to ::'s in the man pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64956|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 68181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68181&action=edit Bug 18920 Save DB_USE_TLS and FONT_DIR to install log Configuration values should be included in the koha-install-log so that when running Makefile.PL with the --prev-install-log option values can be read from there and reapplied rather than prompting the user on each subsequent run. This adds FONT_DIR and DB_USE_TLS (and its dependent options) to koha-install-log so that the set values will be written by make during a make install or make upgrade Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68181|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68716&action=edit Bug 18920 Save DB_USE_TLS and FONT_DIR to install log Configuration values should be included in the koha-install-log so that when running Makefile.PL with the --prev-install-log option values can be read from there and reapplied rather than prompting the user on each subsequent run. This adds FONT_DIR and DB_USE_TLS (and its dependent options) to koha-install-log so that the set values will be written by make during a make install or make upgrade Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org