[Bug 7733] New: HidePatronName not working on moredetail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 Priority: P5 - low Change sponsored?: --- Bug ID: 7733 Assignee: oleonard@myacpl.org Summary: HidePatronName not working on moredetail QA Contact: koha.sekjal@gmail.com Severity: major Classification: Unclassified OS: All Reporter: nengard@gmail.com URL: koha/catalogue/moredetail.pl?biblionumber=6142 Hardware: All Status: NEW Version: master Component: Templates Product: Koha Created attachment 8272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8272&action=edit cardnumber instead of name showing When I have HidePatronName set to SHOW it's not showing the patron name on the moredetail page anymore, it only shows the barcode no matter what I set the preference to. The info is showing right on the detail page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 9205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9205&action=edit Bug 7733 - HidePatronName not working on moredetail Patch implements HidePatronName system preference for 'Checkout status' on moredetail (tab items from staff detail page). Also adds some new 'if' statements, so 'Serial enumeration' and 'Paid for?' are only shown when they are not empty. Silences warns in the logs. To test: - Toggle system preference for an issued item and check name/cardnumber are displayed correctly. - Check serial enumeration and Paid for? show when not empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer@bsz-bw.de Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de Severity|major |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9209&action=edit label in funny place The patch applies and shows the name right, but if the book is not checked out it puts the 'current renewals' label next to 'checkout status' instead of below it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9205|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 9211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9211&action=edit Bug 7733 - HidePatronName not working on moredetail Patch implements HidePatronName system preference for 'Checkout status' on moredetail (tab items from staff detail page). Also adds some new 'if' statements, so 'Serial enumeration' and 'Paid for?' are only shown when they are not empty. Silences warns in the logs. To test: - Toggle system preference for an issued item and check name/cardnumber are displayed correctly. - Check serial enumeration and Paid for? show when not empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It was a missing  . :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9211|0 |1 is obsolete| | --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9213&action=edit [SIGNED-OFF] Bug 7733 - HidePatronName not working on moredetail Patch implements HidePatronName system preference for 'Checkout status' on moredetail (tab items from staff detail page). Also adds some new 'if' statements, so 'Serial enumeration' and 'Paid for?' are only shown when they are not empty. Silences warns in the logs. To test: - Toggle system preference for an issued item and check name/cardnumber are displayed correctly. - Check serial enumeration and Paid for? show when not empty. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Ian Walls <koha.sekjal@gmail.com> --- Adds borrower name information to catalogue/moredetail if the system preference is set to show the patron name (keeps existing behavior of showing cardnumber otherwise). Cleans up spacing, and adds conditional checks for several variables before trying to display them. While technically out of scope for this bug report, these are minor changes and definite improvements, so they'll be given a pass. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |rel_3_8 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The patches for this bug do not apply to 3.6. If you want this included in 3.6.x, please rebase on 3.6.x and reset the version to rel_3_6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7733 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org