[Bug 27476] New: Improve link text for logging in on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Bug ID: 27476 Summary: Improve link text for logging in on OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt: <p><a href="[% shibbolethLoginUrl | $raw %]">If you have a Shibboleth account, please click here to log in.</a></p> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt: <p><a href="[% casServerUrl | $raw %]">Please click here to log in.</a><p> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt: <p><a href="[% casServerUrl | $raw %]">If you have a CAS account, please click here to log in.</a><p> "Here" should not be used as a link text as it doesn't contain any helpful information for people scanning the page for information and also is a problem for blind users using screen readers jumping from link to link on a page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Blocks| |26722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722 [Bug 26722] [Omnibus] Use descriptive link texts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ellawipatene@gmail.com Assignee|oleonard@myacpl.org |ellawipatene@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 --- Comment #1 from Ella <ellawipatene@gmail.com> --- Created attachment 115408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115408&action=edit Bug 27476: Improve link text for logging in on OPAC (Note: Must have Shibboleth and CAS added to OPAC) 1. (Before downloading patch) Go to OPAC 2. Search for an item in the search bar (i.e. type 'a') 3. On one of the items, click on 'Place hold' 4. The links should say 'If you have a Shibboleth account, please click here to log in', 'Please click here to log in' and 'If you have a CAS account, please click here to log in' 5. Add patch 6. Repeat steps 1-3 7. The links should now say 'Log in for Shibboleth account', 'Log in' and 'Log in for CAS account' NOTE: Also noticed on the initial log in box there was the same issue - here is the testing for that: 1. Go to OPAC home page 2. In the top right click 'Log in to your account' 3. The link should say 'If you have a Shibboleth account, please click here to log in.' 4. Apply patch 5. Repeat steps 1&2 6. The link should now say 'Log in for a Shibboleth account' Sponsored.by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I like this change, but I think "Log in /for/ a Shibboleth account" implies that you're trying to /get/ a Shibboleth account. I think it should be "Log in with..." or "Log in using..." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115408|0 |1 is obsolete| | --- Comment #3 from Ella <ellawipatene@gmail.com> --- Created attachment 115454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115454&action=edit Bug 27476: Improve link text for logging in on OPAC (Note: Must have Shibboleth and CAS added to OPAC) 1. (Before downloading patch) Go to OPAC 2. Search for an item in the search bar (i.e. type 'a') 3. On one of the items, click on 'Place hold' 4. The links should say 'If you have a Shibboleth account, please click here to log in', 'Please click here to log in' and 'If you have a CAS account, please click here to log in' 5. Add patch 6. Repeat steps 1-3 7. The links should now say 'Log in using a Shibboleth account', 'Log in' and 'Log in using a CAS account' NOTE: Also noticed on the initial log in box there was the same issue - here is the testing for that: 1. Go to OPAC home page 2. In the top right click 'Log in to your account' 3. The link should say 'If you have a Shibboleth account, please click here to log in.' 4. Apply patch 5. Repeat steps 1&2 6. The link should now say 'Log in for Shibboleth account' Sponsored.by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if this one could be misread: <p><a href="[% shibbolethLoginUrl | $raw %]">Log in for a Shibboleth account</a>.</p> I'd probably translate to something like "log here to create a Shibboleth account". Not a native speaker, but maybe "Log in using a Shibboleth account" like below would be a little clearer? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115454|0 |1 is obsolete| | --- Comment #5 from Ella <ellawipatene@gmail.com> --- Created attachment 115646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115646&action=edit Bug 27476: Improve link text for logging in on OPAC (Note: Must have Shibboleth and CAS added to OPAC) 1. (Before downloading patch) Go to OPAC 2. Search for an item in the search bar (i.e. type 'a') 3. On one of the items, click on 'Place hold' 4. The links should say 'If you have a Shibboleth account, please click here to log in', 'Please click here to log in' and 'If you have a CAS account, please click here to log in' 5. Add patch 6. Repeat steps 1-3 7. The links should now say 'Log in using a Shibboleth account', 'Log in' and 'Log in using a CAS account' NOTE: Also noticed on the initial log in box there was the same issue - here is the testing for that: 1. Go to OPAC home page 2. In the top right click 'Log in to your account' 3. The link should say 'If you have a Shibboleth account, please click here to log in.' 4. Apply patch 5. Repeat steps 1&2 6. The link should now say 'Log in using a Shibboleth account' Sponsored.by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115646|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115653&action=edit Bug 27476: Improve link text for logging in on OPAC (Note: Must have Shibboleth and CAS added to OPAC) 1. (Before downloading patch) Go to OPAC 2. Search for an item in the search bar (i.e. type 'a') 3. On one of the items, click on 'Place hold' 4. The links should say 'If you have a Shibboleth account, please click here to log in', 'Please click here to log in' and 'If you have a CAS account, please click here to log in' 5. Add patch 6. Repeat steps 1-3 7. The links should now say 'Log in using a Shibboleth account', 'Log in' and 'Log in using a CAS account' NOTE: Also noticed on the initial log in box there was the same issue - here is the testing for that: 1. Go to OPAC home page 2. In the top right click 'Log in to your account' 3. The link should say 'If you have a Shibboleth account, please click here to log in.' 4. Apply patch 5. Repeat steps 1&2 6. The link should now say 'Log in using a Shibboleth account' Sponsored.by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115653|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116195&action=edit Bug 27476: Improve link text for logging in on OPAC (Note: Must have Shibboleth and CAS added to OPAC) 1. (Before downloading patch) Go to OPAC 2. Search for an item in the search bar (i.e. type 'a') 3. On one of the items, click on 'Place hold' 4. The links should say 'If you have a Shibboleth account, please click here to log in', 'Please click here to log in' and 'If you have a CAS account, please click here to log in' 5. Add patch 6. Repeat steps 1-3 7. The links should now say 'Log in using a Shibboleth account', 'Log in' and 'Log in using a CAS account' NOTE: Also noticed on the initial log in box there was the same issue - here is the testing for that: 1. Go to OPAC home page 2. In the top right click 'Log in to your account' 3. The link should say 'If you have a Shibboleth account, please click here to log in.' 4. Apply patch 5. Repeat steps 1&2 6. The link should now say 'Log in using a Shibboleth account' Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works well, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Joel Coehoorn <jcoehoorn@york.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcoehoorn@york.edu --- Comment #11 from Joel Coehoorn <jcoehoorn@york.edu> --- In the case where the new ShibOnly preference is used, why do we even show this view at all? As soon as you visit the OPAC and click the 'Log in to your account' link from the home page, it should be as if you clicked 'Log in using a Shibboleth account' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Joel Coehoorn from comment #11)
In the case where the new ShibOnly preference is used, why do we even show this view at all? As soon as you visit the OPAC and click the 'Log in to your account' link from the home page, it should be as if you clicked 'Log in using a Shibboleth account'
Hi Joel, I think there was an overlap here - ShibOnly was added after work started on this patch. If it doesn't work with ShibOnly as you describe, please file a new bug report - I think what you suggest sure makes sense for the ShibOnly use case. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org