[Bug 31569] New: Remove GetImportsRecordRange from acqui/addorderiso2709
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Bug ID: 31569 Summary: Remove GetImportsRecordRange from acqui/addorderiso2709 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Refactor to use Koha::Import::Records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140659&action=edit Bug 31569: DB update and objects -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140660&action=edit Bug 31569: DO NOT PUSH Schema Updates RM: Please copy object class lines :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140661&action=edit Bug 31569: Remove GetImportRecordsRange from import_biblios_list This patch changes the way records are loaded for display when adding to a basket from a staged file To test: 1 - Stage a file of records for import 2 - Go to Acquisitions, find a vendor, create or find a basket 3 - Add to basket from staged file 4 - Choose the file 5 - Note the display of records 6 - Cancel 7 - Apply patch 8 - Stage from same file 9 - Note the display is unchanged -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140662&action=edit Bug 31569: Remove GetImportRecordsRange from import stage This patch removes the use of GetimportRecordsRange from the importing step To test: 0 - Apply patch 1 - Stage a marc file for import 2 - Add to basket from a staged file 3 - Select titles to import (don't select all) 4 - Fill out necessary fields, be sure to select itemtype on items tab 5 - Import 6 - Confirm titles successfully added to basket 7 - Confirm staged import not marked as imported 8 - Add to basket from same file 9 - Select rest of titles 10 - Import 11 - Confirm staged file now marked imported -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140663&action=edit Bug 31569: Remove GetImportRecordsRange from list step This patch removes the use of GetImportRecordsRange from the step of listing import batches to choose. It was only used for a count so is a simple replacement To test: 1 - Stage a number of files for import 2 - Import one of the files from tools 3 - Add to basket form a staged file 4 - Confirm staged baskets are listed, and imported basket is not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140664&action=edit Bug 31569: Remove unecessary imports By using objects a number of other routines are not needed: GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber To test: Grep for routines above in addorderiso2709 and confirm they are not used -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140665&action=edit Bug 31569: Add filters -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19358 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358 [Bug 19358] Purchase suggestions - enhancements to linking to orders -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140659|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140676&action=edit Bug 31569: DB update and objects Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140660|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140677&action=edit Bug 31569: DO NOT PUSH Schema Updates RM: Please copy object class lines :-) Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140661|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140678&action=edit Bug 31569: Remove GetImportRecordsRange from import_biblios_list This patch changes the way records are loaded for display when adding to a basket from a staged file To test: 1 - Stage a file of records for import 2 - Go to Acquisitions, find a vendor, create or find a basket 3 - Add to basket from staged file 4 - Choose the file 5 - Note the display of records 6 - Cancel 7 - Apply patch 8 - Stage from same file 9 - Note the display is unchanged Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140662|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140679&action=edit Bug 31569: Remove GetImportRecordsRange from import stage This patch removes the use of GetimportRecordsRange from the importing step To test: 0 - Apply patch 1 - Stage a marc file for import 2 - Add to basket from a staged file 3 - Select titles to import (don't select all) 4 - Fill out necessary fields, be sure to select itemtype on items tab 5 - Import 6 - Confirm titles successfully added to basket 7 - Confirm staged import not marked as imported 8 - Add to basket from same file 9 - Select rest of titles 10 - Import 11 - Confirm staged file now marked imported Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140663|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140680&action=edit Bug 31569: Remove GetImportRecordsRange from list step This patch removes the use of GetImportRecordsRange from the step of listing import batches to choose. It was only used for a count so is a simple replacement To test: 1 - Stage a number of files for import 2 - Import one of the files from tools 3 - Add to basket form a staged file 4 - Confirm staged baskets are listed, and imported basket is not Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140664|0 |1 is obsolete| | --- Comment #13 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140681&action=edit Bug 31569: Remove unecessary imports By using objects a number of other routines are not needed: GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber To test: Grep for routines above in addorderiso2709 and confirm they are not used Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140665|0 |1 is obsolete| | --- Comment #14 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140682&action=edit Bug 31569: Add filters Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31708 [Bug 31708] Remove SetImportRecordStatus from neworderempty.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31709 [Bug 31709] Replace SetMatchedBiblionumber method with object method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31710 [Bug 31710] Replace GetImportRangeRecords with object methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140676|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141504&action=edit Bug 31569: DB update and objects Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140677|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141505&action=edit Bug 31569: DO NOT PUSH Schema Updates RM: Please copy object class lines :-) Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140678|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141506&action=edit Bug 31569: Remove GetImportRecordsRange from import_biblios_list This patch changes the way records are loaded for display when adding to a basket from a staged file To test: 1 - Stage a file of records for import 2 - Go to Acquisitions, find a vendor, create or find a basket 3 - Add to basket from staged file 4 - Choose the file 5 - Note the display of records 6 - Cancel 7 - Apply patch 8 - Stage from same file 9 - Note the display is unchanged Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140679|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141507&action=edit Bug 31569: Remove GetImportRecordsRange from import stage This patch removes the use of GetimportRecordsRange from the importing step To test: 0 - Apply patch 1 - Stage a marc file for import 2 - Add to basket from a staged file 3 - Select titles to import (don't select all) 4 - Fill out necessary fields, be sure to select itemtype on items tab 5 - Import 6 - Confirm titles successfully added to basket 7 - Confirm staged import not marked as imported 8 - Add to basket from same file 9 - Select rest of titles 10 - Import 11 - Confirm staged file now marked imported Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140680|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141508&action=edit Bug 31569: Remove GetImportRecordsRange from list step This patch removes the use of GetImportRecordsRange from the step of listing import batches to choose. It was only used for a count so is a simple replacement To test: 1 - Stage a number of files for import 2 - Import one of the files from tools 3 - Add to basket form a staged file 4 - Confirm staged baskets are listed, and imported basket is not Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140681|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141509&action=edit Bug 31569: Remove unecessary imports By using objects a number of other routines are not needed: GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber To test: Grep for routines above in addorderiso2709 and confirm they are not used Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140682|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141510&action=edit Bug 31569: Add filters Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141511&action=edit Bug 31569: (QA follow-up) Remove additional spaces from ISBN/ISSN Before this change, the ISBN woudl display like: ( isbn ) This patch removes the additional spaces so the display is the same as without this patch set on current master: (isbn) Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 142031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142031&action=edit Bug 31569: (QA follow-up) Add missing entries in schema Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166 [Bug 32166] When adding to a basket from a staged file we may use the wrong inputs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31569 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org