[Bug 31807] New: Context for translation: Filter (verb) vs. Filter (noun)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Bug ID: 31807 Summary: Context for translation: Filter (verb) vs. Filter (noun) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr In the new MARC overlay rules, there is one instance of 'Filter' that is meant as a noun. In French (and maybe other languages), the noun and the verb are not the same word. Most instances of 'Filter' are meant as verbs (some are ambiguous and could be both, such as the column headers in Reports > Statistics wizards). MARC overlay rules is the only page where Filter as a verb doesn't really work. I propose we add some context to separate it from the other ones. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 141907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141907&action=edit Bug 31807: Context for translation: Filter (verb) vs. Filter (noun) This patch add the context 'noun' to the 'Filter' string in marc-overlay-rules.tt. This will separate that instance of 'Filter' from the other ones, where it is meant as a verb. To test: 1. Apply patch 2. Visit Administration > MARC overlay rules, make sure the page works (no errors) and that there is a column called 'Filter' 3. Update the po files gulp po:update --lang xx-XX for example, gulp po:update --lang fr-CA 4. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po), there should be an entry for 'Filter', with a line msgctxt that gives the 'noun' context 5. Update the file with a random word for the 'Filter' translation for example, I translated 'Filter' by 'Filter as a noun', just to see the difference \#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:83 msgctxt "noun" msgid "Filter" msgstr "Filter as a noun" 6. Install a new language 6.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA) cd misc/translator ./translate install xx-XX 6.2. In the Koha staff interface, go to Administration > Global system preferences 6.3. Search for language 6.4. Check the box next to the new language 6.5. Save 7. View the MARC overlay rules page in the new language, the 'Filter' column heading should be whatever you put in step 5 Optional test 8. In the staff interface in English, view one or more of these pages, the 'Filter' should be unchanged - Acquisitions > Late orders (Filter button) - Aquisitions > Search for vendor > Receive shipments (Filter heading on the left and Filter button) - Acquisitions > Search for vendor > Click vendor's name > Uncertain prices (Filter button) - Administration > Budgets > Click budget's name > Planning > Plan by ... (any option) (Filter heading on the left) - Reports > Use saved (Filter heading on the left) - Reports > Acquisitions statistics wizard (Filter column heading) - Reports > Patrons statistics wizard (Filter column heading) - Reports > Catalog statistics wizard (Filter column heading) - Reports > Circulation statistics wizard (Filter column heading) - Reports > Holds statistics wizard (Filter column heading) - Reports > Average loan time (Filter column heading) - Tools > News (Filter heading on the left) 9. View these same pages in the other language, the Filter should NOT be changed to whatever you put in step 5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I only added the noun context to the marc-overlay-rules page. I did not add the 'verb' context to the other pages. Let me know if this would be preferable. Step 8 contains all the other instances of 'Filter' in the staff interface. The buttons and section headings are certainly verbs, but I wasn't sure for the column headings. It could be both. So I abstained from making a decision. If someone thinks it's preferable to add the context everywhere, let me know which would be best for the column headings... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com Text to go in the| |This enhancement adds some release notes| |context for translators for | |the term "Filter" when used | |as a noun as opposed to a | |verb. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141907|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 141939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141939&action=edit Bug 31807: Context for translation: Filter (verb) vs. Filter (noun) This patch add the context 'noun' to the 'Filter' string in marc-overlay-rules.tt. This will separate that instance of 'Filter' from the other ones, where it is meant as a verb. To test: 1. Apply patch 2. Visit Administration > MARC overlay rules, make sure the page works (no errors) and that there is a column called 'Filter' 3. Update the po files gulp po:update --lang xx-XX for example, gulp po:update --lang fr-CA 4. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po), there should be an entry for 'Filter', with a line msgctxt that gives the 'noun' context 5. Update the file with a random word for the 'Filter' translation for example, I translated 'Filter' by 'Filter as a noun', just to see the difference \#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:83 msgctxt "noun" msgid "Filter" msgstr "Filter as a noun" 6. Install a new language 6.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA) cd misc/translator ./translate install xx-XX 6.2. In the Koha staff interface, go to Administration > Global system preferences 6.3. Search for language 6.4. Check the box next to the new language 6.5. Save 7. View the MARC overlay rules page in the new language, the 'Filter' column heading should be whatever you put in step 5 Optional test 8. In the staff interface in English, view one or more of these pages, the 'Filter' should be unchanged - Acquisitions > Late orders (Filter button) - Aquisitions > Search for vendor > Receive shipments (Filter heading on the left and Filter button) - Acquisitions > Search for vendor > Click vendor's name > Uncertain prices (Filter button) - Administration > Budgets > Click budget's name > Planning > Plan by ... (any option) (Filter heading on the left) - Reports > Use saved (Filter heading on the left) - Reports > Acquisitions statistics wizard (Filter column heading) - Reports > Patrons statistics wizard (Filter column heading) - Reports > Catalog statistics wizard (Filter column heading) - Reports > Circulation statistics wizard (Filter column heading) - Reports > Holds statistics wizard (Filter column heading) - Reports > Average loan time (Filter column heading) - Tools > News (Filter heading on the left) 9. View these same pages in the other language, the Filter should NOT be changed to whatever you put in step 5 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141939|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141944&action=edit Bug 31807: Context for translation: Filter (verb) vs. Filter (noun) This patch add the context 'noun' to the 'Filter' string in marc-overlay-rules.tt. This will separate that instance of 'Filter' from the other ones, where it is meant as a verb. To test: 1. Apply patch 2. Visit Administration > MARC overlay rules, make sure the page works (no errors) and that there is a column called 'Filter' 3. Update the po files gulp po:update --lang xx-XX for example, gulp po:update --lang fr-CA 4. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po), there should be an entry for 'Filter', with a line msgctxt that gives the 'noun' context 5. Update the file with a random word for the 'Filter' translation for example, I translated 'Filter' by 'Filter as a noun', just to see the difference \#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:83 msgctxt "noun" msgid "Filter" msgstr "Filter as a noun" 6. Install a new language 6.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA) cd misc/translator ./translate install xx-XX 6.2. In the Koha staff interface, go to Administration > Global system preferences 6.3. Search for language 6.4. Check the box next to the new language 6.5. Save 7. View the MARC overlay rules page in the new language, the 'Filter' column heading should be whatever you put in step 5 Optional test 8. In the staff interface in English, view one or more of these pages, the 'Filter' should be unchanged - Acquisitions > Late orders (Filter button) - Aquisitions > Search for vendor > Receive shipments (Filter heading on the left and Filter button) - Acquisitions > Search for vendor > Click vendor's name > Uncertain prices (Filter button) - Administration > Budgets > Click budget's name > Planning > Plan by ... (any option) (Filter heading on the left) - Reports > Use saved (Filter heading on the left) - Reports > Acquisitions statistics wizard (Filter column heading) - Reports > Patrons statistics wizard (Filter column heading) - Reports > Catalog statistics wizard (Filter column heading) - Reports > Circulation statistics wizard (Filter column heading) - Reports > Holds statistics wizard (Filter column heading) - Reports > Average loan time (Filter column heading) - Tools > News (Filter heading on the left) 9. View these same pages in the other language, the Filter should NOT be changed to whatever you put in step 5 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org