[Bug 11618] New: jQuery timepicker is not picked up by the i18n toolchain
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 Bug ID: 11618 Summary: jQuery timepicker is not picked up by the i18n toolchain Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Created attachment 24745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24745&action=edit Untranslatable text in jQuery timepicker The jQuery timepicker plugin has some strings that cannot be translated via Koha i18n toolchain. ("Time", "Hour", "Minute", "Now", "Done", ...) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 24755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24755&action=edit Bug 11618 - jQuery timepicker is not picked up by the i18n toolchain We handle internationalization of the jQuery datepicker by adding language configuration strings to calendar.inc which can be processed by the translation script. This patch adds a similar configuration file for the timepicker. This patch also upgrades the timepicker plugin to the latest version, minified, and places it outside the prog template directory for global use. The path in templates has been updated accordingly. CSS has been added to more completely hide the controls for seconds, milliseconds, and microseconds. To test, apply the patch and clear your cache so that the browser loads the new version of the jQuery plugin. Confirm that date and time selection still function correctly on the circulation page, the patron detail page, and the offline circulation page (circ/offline.pl). Test at least one datepicker instance which does not use the timepicker. Run translate update on a po file and confirm that the timepicker strings are now present. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24755|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25313&action=edit Bug 11618 - jQuery timepicker is not picked up by the i18n toolchain We handle internationalization of the jQuery datepicker by adding language configuration strings to calendar.inc which can be processed by the translation script. This patch adds a similar configuration file for the timepicker. This patch also upgrades the timepicker plugin to the latest version, minified, and places it outside the prog template directory for global use. The path in templates has been updated accordingly. CSS has been added to more completely hide the controls for seconds, milliseconds, and microseconds. To test, apply the patch and clear your cache so that the browser loads the new version of the jQuery plugin. Confirm that date and time selection still function correctly on the circulation page, the patron detail page, and the offline circulation page (circ/offline.pl). Test at least one datepicker instance which does not use the timepicker. Run translate update on a po file and confirm that the timepicker strings are now present. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25313|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25345&action=edit Bug 11618 - jQuery timepicker is not picked up by the i18n toolchain We handle internationalization of the jQuery datepicker by adding language configuration strings to calendar.inc which can be processed by the translation script. This patch adds a similar configuration file for the timepicker. This patch also upgrades the timepicker plugin to the latest version, minified, and places it outside the prog template directory for global use. The path in templates has been updated accordingly. CSS has been added to more completely hide the controls for seconds, milliseconds, and microseconds. To test, apply the patch and clear your cache so that the browser loads the new version of the jQuery plugin. Confirm that date and time selection still function correctly on the circulation page, the patron detail page, and the offline circulation page (circ/offline.pl). Test at least one datepicker instance which does not use the timepicker. Run translate update on a po file and confirm that the timepicker strings are now present. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Works as expected, no regression found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 12049 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org